unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Axel Svensson <svenssonaxel@gmail.com>
Cc: 57072@debbugs.gnu.org
Subject: bug#57072: [BUG] update-glyphless-char-display and variation selectors
Date: Thu, 11 Aug 2022 17:01:44 +0300	[thread overview]
Message-ID: <83leruq3p3.fsf@gnu.org> (raw)
In-Reply-To: <CAJ40yazh2uaaZPK=beRtMx8FLpZ03doLa7NoyvQiOVQDKL80og@mail.gmail.com> (message from Axel Svensson on Tue, 9 Aug 2022 16:56:37 +0200)

> From: Axel Svensson <svenssonaxel@gmail.com>
> Date: Tue, 9 Aug 2022 16:56:37 +0200
> Cc: 57072@debbugs.gnu.org
> 
> See new patch attached.
> 
> It turns out there are 256 variation selectors, so I've included some fixes for selectors 17-256 as well.
> admin/unidata/blocks.awk is an exception; it seems to deal with only VS 1-16, but I have not fixed it.
> 
> > Why are the acronyms you propose so long?  Why not use "VS01".."VS16"
> You're right, that is better. The attached patch is fixed to have shorter acronyms.
> The acronyms I've chosen are "VS-1" through "VS-9", "VS10" through "VS99" and "VS-100" through
> "VS-256".
> Not sure that's optimal, perhaps "VS01" or "VS 1" is better, what do you think?

I think "VS01" is better.

> diff --git a/lisp/international/characters.el b/lisp/international/characters.el
> index ca28222c81..78f8447208 100644
> --- a/lisp/international/characters.el
> +++ b/lisp/international/characters.el
> @@ -1243,7 +1243,8 @@ ?L
>  	   (#x1E026 . #x1E02A)
>  	   (#x1E8D0 . #x1E8D6)
>  	   (#x1E944 . #x1E94A)
> -	   (#xE0001 . #xE01EF))))
> +	   (#xE0001 . #xE01EF)
> +	   (#xE0100 . #xE01EF))))
>    (dolist (elt l)
>      (set-char-table-range char-width-table elt 0)))

This hunk is a mistake, I think: the original code already covered all
range of these characters.

Thanks.





  parent reply	other threads:[~2022-08-11 14:01 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-09  8:38 bug#57072: [BUG] update-glyphless-char-display and variation selectors Axel Svensson
2022-08-09  8:40 ` bug#57073: " Axel Svensson
2022-08-09 11:36 ` bug#57072: " Eli Zaretskii
2022-08-09 14:56   ` Axel Svensson
2022-08-09 16:23     ` Eli Zaretskii
2022-08-09 20:33       ` Axel Svensson
2022-08-10 13:10         ` Eli Zaretskii
2022-08-16 11:55           ` Robert Pluim
2022-08-16 12:01             ` Eli Zaretskii
2022-08-11 14:01     ` Eli Zaretskii [this message]
2022-08-11 14:58       ` Axel Svensson
2022-08-11 16:19         ` Eli Zaretskii
2022-08-12  3:33           ` Axel Svensson
2022-08-12  5:53             ` Eli Zaretskii
2022-08-12  6:50               ` Axel Svensson
2022-08-12  7:10                 ` Eli Zaretskii
2022-08-12  7:57                   ` Axel Svensson
2022-08-12 10:29                     ` Eli Zaretskii
2022-08-12 11:51                       ` Axel Svensson
2022-08-12 12:46                         ` Eli Zaretskii
2022-08-16  8:05                           ` Robert Pluim
2022-08-16 13:06                             ` Eli Zaretskii
2022-08-16 13:27                               ` Robert Pluim
2022-08-16 13:39                                 ` Axel Svensson
2022-08-16 14:48                                   ` Robert Pluim
2022-08-16 16:27                                     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83leruq3p3.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=57072@debbugs.gnu.org \
    --cc=svenssonaxel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).