From: Eli Zaretskii <eliz@gnu.org>
To: Joseph Turner <joseph@breatheoutbreathe.in>,
Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 63509@debbugs.gnu.org
Subject: bug#63509: [PATCH] Make copy-tree work with records
Date: Mon, 15 May 2023 14:26:31 +0300 [thread overview]
Message-ID: <83lehp25ug.fsf@gnu.org> (raw)
In-Reply-To: <87fs7yfdg2.fsf@breatheoutbreathe.in> (bug-gnu-emacs@gnu.org)
> Date: Sun, 14 May 2023 20:57:17 -0700
> From: Joseph Turner via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>
> copy-tree does not currently work with records:
It isn't documented to work with anything but cons cells or vectors.
> Attached patch fixes this behavior.
Thanks, but such a change must come with:
- NEWS entry
- update for the ELisp manual
- preferably added tests to regression-test this feature
I also think we should rename the second argument, as VECP no longer
fits.
> Please tell me if I misunderstand the intended behavior of copy-tree.
Adding Stefan in case he has comments.
next prev parent reply other threads:[~2023-05-15 11:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-15 3:57 bug#63509: [PATCH] Make copy-tree work with records Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-15 11:26 ` Eli Zaretskii [this message]
2023-05-15 14:42 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-15 17:59 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-18 10:53 ` Eli Zaretskii
2023-05-18 19:05 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-19 6:07 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83lehp25ug.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=63509@debbugs.gnu.org \
--cc=joseph@breatheoutbreathe.in \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).