From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63509: [PATCH] Make copy-tree work with records Date: Mon, 15 May 2023 14:26:31 +0300 Message-ID: <83lehp25ug.fsf@gnu.org> References: <87fs7yfdg2.fsf@breatheoutbreathe.in> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35679"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63509@debbugs.gnu.org To: Joseph Turner , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 15 13:27:11 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pyWMA-00094d-01 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 May 2023 13:27:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pyWM4-0000gw-5V; Mon, 15 May 2023 07:27:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pyWM2-0000gf-Dq for bug-gnu-emacs@gnu.org; Mon, 15 May 2023 07:27:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pyWM2-000360-4x for bug-gnu-emacs@gnu.org; Mon, 15 May 2023 07:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pyWM2-0001fl-0K for bug-gnu-emacs@gnu.org; Mon, 15 May 2023 07:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 May 2023 11:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63509 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63509-submit@debbugs.gnu.org id=B63509.16841499956370 (code B ref 63509); Mon, 15 May 2023 11:27:01 +0000 Original-Received: (at 63509) by debbugs.gnu.org; 15 May 2023 11:26:35 +0000 Original-Received: from localhost ([127.0.0.1]:42886 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pyWLb-0001eg-1b for submit@debbugs.gnu.org; Mon, 15 May 2023 07:26:35 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:52488) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pyWLZ-0001eP-IK for 63509@debbugs.gnu.org; Mon, 15 May 2023 07:26:34 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pyWLT-0002x5-S3; Mon, 15 May 2023 07:26:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=8ydSfIDldjDVQXeqeoWRrvqW4x98tyj99mW2U2bEYtg=; b=mCUjXGgd6/AN ufpuwS/g5IIDL/tKeYLwFlADnkUgcugIH6f0TiSIHjS32mgaThHztVE2zhc6IpN1bMrduQqW9D3MI G78WnVOZH54SPWWuFS372gELkIXG9CpSRbW8p2T6U1KNLbc55GgcQASFhtlD81K0KBB6VIF9qZikw kGPxVfiHeZP5LHc/FscArhp5J5xZEgGIQRYLoWWfC1qroIKsEiX1Dc5tRK62XUSGBRBqBz+wMzrKr BAAuNUYvvN3FccrknCyNtg0+RwCoVbeFUDyeU5XrBqZRXO4FU3XLE5K1F0+8jXXzDXKlWl0qBcH8t yNdqGZBjoBFnr5g89VN6BQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pyWLT-0000xB-C0; Mon, 15 May 2023 07:26:27 -0400 In-Reply-To: <87fs7yfdg2.fsf@breatheoutbreathe.in> (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261737 Archived-At: > Date: Sun, 14 May 2023 20:57:17 -0700 > From: Joseph Turner via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > copy-tree does not currently work with records: It isn't documented to work with anything but cons cells or vectors. > Attached patch fixes this behavior. Thanks, but such a change must come with: - NEWS entry - update for the ELisp manual - preferably added tests to regression-test this feature I also think we should rename the second argument, as VECP no longer fits. > Please tell me if I misunderstand the intended behavior of copy-tree. Adding Stefan in case he has comments.