bug#65539: [PATCH] ; Fix push-button when triggered by a single keypress

bug#65539: [PATCH] ; Fix push-button when triggered by a single keypress

[Steven Allen]

[-- Attachment #1: Type: text/plain, Size: 146 bytes --]


The following code was broken in the recent android merge:

    (keymap-set button-map "<return>" 'push-button)

The attached patch fixes this.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: fix push-button --]
[-- Type: text/x-patch, Size: 948 bytes --]

From c6270b325e322d5fc2c2eafba2661d7bc82ad47f Mon Sep 17 00:00:00 2001
From: Steven Allen <steven@stebalien.com>
Date: Fri, 25 Aug 2023 10:43:43 -0700
Subject: [PATCH] ; Fix push-button when triggered by a single keypress

* lisp/button.el (push-button): don't assume the event is a list, it may
be a single key.
---
 lisp/button.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/button.el b/lisp/button.el
index b01595943fc..bfe6ccc8d1f 100644
--- a/lisp/button.el
+++ b/lisp/button.el
@@ -492,7 +492,7 @@ push-button
 	    (if str-button
 	        ;; mode-line, header-line, or display string event.
 	        (button-activate str t)
-              (if (eq (car pos) 'touchscreen-down)
+              (if (eq (car-safe pos) 'touchscreen-down)
                   ;; If touch-screen-track tap returns nil, then the
                   ;; tap was cancelled.
                   (when (touch-screen-track-tap pos)
-- 
2.42.0

bug#65539: [PATCH] ; Fix push-button when triggered by a single keypress

[Eli Zaretskii]

> From: Steven Allen <steven@stebalien.com>
> Date: Fri, 25 Aug 2023 10:48:01 -0700
> 
> The following code was broken in the recent android merge:
> 
>     (keymap-set button-map "<return>" 'push-button)
> 
> The attached patch fixes this.

Thanks, installed on master, and closing the bug.