unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Spencer Baugh <sbaugh@janestreet.com>
Cc: mekeor@posteo.de, sbaugh@catern.com, 66283@debbugs.gnu.org,
	stefankangas@gmail.com
Subject: bug#66283: 30.0.50; which-function-mode: When configured to display in header, and toggling off, then does not remove header
Date: Sat, 14 Oct 2023 10:29:59 +0300	[thread overview]
Message-ID: <83lec5slu0.fsf@gnu.org> (raw)
In-Reply-To: <iercyxuv2t9.fsf@janestreet.com> (message from Spencer Baugh on Wed, 04 Oct 2023 11:13:06 -0400)

> From: Spencer Baugh <sbaugh@janestreet.com>
> Cc: Mekeor Melire <mekeor@posteo.de>,  Author <sbaugh@catern.com>,
>    66283@debbugs.gnu.org,  Committer <eliz@gnu.org>
> Date: Wed, 04 Oct 2023 11:13:06 -0400
> 
> Two fixes to the previous patch:
> 
> - There was always a bug with which-function-mode where if you enabled
>   it when there were already existing buffers, it would behave
>   differently than if you enabled it and then created those buffers.
>   Namely it would enable which-func-mode for every buffer, even if the
>   buffer didn't support imenu.  This is especially noticeable when
>   toggling which-function-mode and using the header line, so I fixed it.
> 
> - Also, I accidentally dropped a paren before submitting.  Now that's
>   fixed :)

Thanks, but how about some tests for these fixes?  It's high time
which-mode had some test suite, I think.





  parent reply	other threads:[~2023-10-14  7:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-30 20:41 bug#66283: 30.0.50; which-function-mode: When configured to display in header, and toggling off, then does not remove header Mekeor Melire
2023-10-04 13:57 ` Spencer Baugh
2023-10-04 14:56   ` Stefan Kangas
2023-10-04 15:13     ` Spencer Baugh
2023-10-04 19:19       ` Mekeor Melire
2023-10-04 20:33         ` Stefan Kangas
2023-10-14  7:29       ` Eli Zaretskii [this message]
2023-10-21 14:43         ` sbaugh
2023-10-29 11:24           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83lec5slu0.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=66283@debbugs.gnu.org \
    --cc=mekeor@posteo.de \
    --cc=sbaugh@catern.com \
    --cc=sbaugh@janestreet.com \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).