From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66283: 30.0.50; which-function-mode: When configured to display in header, and toggling off, then does not remove header Date: Sat, 14 Oct 2023 10:29:59 +0300 Message-ID: <83lec5slu0.fsf@gnu.org> References: <87edif9xqh.fsf@posteo.de> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36573"; mail-complaints-to="usenet@ciao.gmane.io" Cc: mekeor@posteo.de, sbaugh@catern.com, 66283@debbugs.gnu.org, stefankangas@gmail.com To: Spencer Baugh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 14 09:30:49 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qrZ6n-0009LR-2Q for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 14 Oct 2023 09:30:49 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qrZ6h-0006da-V8; Sat, 14 Oct 2023 03:30:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qrZ6d-0006dF-4e for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2023 03:30:42 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qrZ6c-0004C5-Lb for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2023 03:30:38 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qrZ70-00055I-2I for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2023 03:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Oct 2023 07:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66283 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed patch Original-Received: via spool by 66283-submit@debbugs.gnu.org id=B66283.169726863119498 (code B ref 66283); Sat, 14 Oct 2023 07:31:01 +0000 Original-Received: (at 66283) by debbugs.gnu.org; 14 Oct 2023 07:30:31 +0000 Original-Received: from localhost ([127.0.0.1]:47765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrZ6U-00054O-UA for submit@debbugs.gnu.org; Sat, 14 Oct 2023 03:30:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41322) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrZ6S-000549-Vj for 66283@debbugs.gnu.org; Sat, 14 Oct 2023 03:30:29 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qrZ60-0003lI-6L; Sat, 14 Oct 2023 03:30:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=YEqb50xKT/smhuHw7MlO0pZ9wIFz95tGU3vqjxDELRM=; b=boe1HqNStbzH phXsm9A6jOpTpeafn4ULF7BZIQ6g6bkym4owkmwew95zN7KMxEasoaZ4Myu27r+kxmF8cFM93WBSv JCKDSMXDSLKVAzODBoLu888+j9lBM/ZoGqlHyIapXdkTzm5kfoLLOOl43fByPAF5r0NNHVrBZ1H09 PBJ7t/D85+E4B83TSlqDWGh4OBjLE8NoTZlKWgsuzXYh3oH1J4kkA3UeK4LZxQHzDyCG7wmpXWz8h l2FVEcCWn7RjkR6VC/MRHxeYL+tFmZVgEAncoZbg3otoxrv9iKiVYIOxQ0j3F2TO9u2aylKm71Ds1 +96E6fFq2Wac/pC8YaNhbw==; In-Reply-To: (message from Spencer Baugh on Wed, 04 Oct 2023 11:13:06 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:272381 Archived-At: > From: Spencer Baugh > Cc: Mekeor Melire , Author , > 66283@debbugs.gnu.org, Committer > Date: Wed, 04 Oct 2023 11:13:06 -0400 > > Two fixes to the previous patch: > > - There was always a bug with which-function-mode where if you enabled > it when there were already existing buffers, it would behave > differently than if you enabled it and then created those buffers. > Namely it would enable which-func-mode for every buffer, even if the > buffer didn't support imenu. This is especially noticeable when > toggling which-function-mode and using the header line, so I fixed it. > > - Also, I accidentally dropped a paren before submitting. Now that's > fixed :) Thanks, but how about some tests for these fixes? It's high time which-mode had some test suite, I think.