* bug#16760: Ellipses lose all decorative features when 'invisible' overlay starts at a point where underlying text changes its 'face' property.
@ 2014-02-14 23:40 Pontus Michael
2016-02-04 21:05 ` Marcin Borkowski
0 siblings, 1 reply; 10+ messages in thread
From: Pontus Michael @ 2014-02-14 23:40 UTC (permalink / raw)
To: 16760
[-- Attachment #1: Type: text/plain, Size: 1788 bytes --]
I am able to reproduce this issue running emacs -Q with "GNU Emacs
24.3.50.1 (i686-pc-linux-gnu, GTK+ Version 3.6.3)".
I've wrote a snippet that will allow me to demonstrate this issue:
(let ((str (concat (propertize "red" 'face '((:foreground "red")))
(propertize "green" 'face '((:foreground "green")))
(propertize "blue" 'face '((:foreground "blue")))))
(printer (lambda (offset)
(let* ((pos1 (+ offset (point)))
(pos2 (+ 1 (length str) pos1)))
(insert str ?\s str ?\n)
(overlay-put (make-overlay pos1 (+ 3 pos1))
'face '((:inverse-video t)))
(overlay-put (make-overlay pos2 (+ 3 pos2))
'invisible 'outline)))))
(with-current-buffer (get-buffer-create "*test*")
(setq buffer-invisibility-spec '((outline . t)))
(text-scale-set 4)
(display-buffer (current-buffer))
(erase-buffer)
(mapc printer '(2 3 4))))
After running this code you will be able to see, in a new buffer, 3 lines
of 2 words, all words are the same, each line features three-letter long
overlay over each of the words, highlighting letters underneath them on
left side, and hiding them behind ellipses on right side.
Whenever an overlay spans from a point where there's a change to 'face'
text-property, produced ellipsis doesn't adopt face decoration of neither
side. Furthermore, ellipsis part of the buffer appears to ignore current
text-scale setting, which is being set to 4 for temporary buffer in my
example.
Thank you for your attention.
All corrections that may help me improve my further reports are welcomed.
[-- Attachment #2: Type: text/html, Size: 2109 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#16760: Ellipses lose all decorative features when 'invisible' overlay starts at a point where underlying text changes its 'face' property.
2014-02-14 23:40 bug#16760: Ellipses lose all decorative features when 'invisible' overlay starts at a point where underlying text changes its 'face' property Pontus Michael
@ 2016-02-04 21:05 ` Marcin Borkowski
2016-02-04 21:20 ` Eli Zaretskii
0 siblings, 1 reply; 10+ messages in thread
From: Marcin Borkowski @ 2016-02-04 21:05 UTC (permalink / raw)
To: Pontus Michael; +Cc: 16760
Hi all,
I confirm that this is reproducible on GNU Emacs 25.1.50.1. (I also
suspect that a similar problem exists with ellipsis in Org-mode, when
scaling the text. One discussion on the ML suggests a problem with
display tables.)
Best,
Marcin Borkowski
On 2014-02-15, at 03:40, Pontus Michael <m.pontus@gmail.com> wrote:
> I am able to reproduce this issue running emacs -Q with "GNU Emacs 24.3.50.1 (i686-pc-linux-gnu, GTK+ Version 3.6.3)".
> I've wrote a snippet that will allow me to demonstrate this issue:
>
> (let ((str (concat (propertize "red" 'face '((:foreground "red")))
> (propertize "green" 'face '((:foreground "green")))
> (propertize "blue" 'face '((:foreground "blue")))))
> (printer (lambda (offset)
> (let* ((pos1 (+ offset (point)))
> (pos2 (+ 1 (length str) pos1)))
> (insert str ?\s str ?\n)
> (overlay-put (make-overlay pos1 (+ 3 pos1))
> 'face '((:inverse-video t)))
> (overlay-put (make-overlay pos2 (+ 3 pos2))
> 'invisible 'outline)))))
> (with-current-buffer (get-buffer-create "*test*")
> (setq buffer-invisibility-spec '((outline . t)))
> (text-scale-set 4)
> (display-buffer (current-buffer))
> (erase-buffer)
> (mapc printer '(2 3 4))))
>
> After running this code you will be able to see, in a new buffer, 3 lines of 2 words, all words are the same, each line features three-letter long overlay over each of the words,
> highlighting letters underneath them on left side, and hiding them behind ellipses on right side.
>
> Whenever an overlay spans from a point where there's a change to 'face' text-property, produced ellipsis doesn't adopt face decoration of neither side. Furthermore, ellipsis
> part of the buffer appears to ignore current text-scale setting, which is being set to 4 for temporary buffer in my example.
>
> Thank you for your attention.
> All corrections that may help me improve my further reports are welcomed.
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#16760: Ellipses lose all decorative features when 'invisible' overlay starts at a point where underlying text changes its 'face' property.
2016-02-04 21:05 ` Marcin Borkowski
@ 2016-02-04 21:20 ` Eli Zaretskii
2016-02-07 20:43 ` Marcin Borkowski
0 siblings, 1 reply; 10+ messages in thread
From: Eli Zaretskii @ 2016-02-04 21:20 UTC (permalink / raw)
To: Marcin Borkowski; +Cc: m.pontus, 16760
> From: Marcin Borkowski <mbork@mbork.pl>
> Date: Thu, 04 Feb 2016 22:05:28 +0100
> Cc: 16760@debbugs.gnu.org
>
> I confirm that this is reproducible on GNU Emacs 25.1.50.1.
I think you are wrong, the original bug has been fixed (in Emacs 24.4,
AFAICT). If you disagree, please show a screenshot of what you see,
and please explain what is wrong with that. Because I cannot see in
25.0.90 anything of what the original report describes: the color of
the ellipsis in the second line and its scaling are correct.
Thanks.
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#16760: Ellipses lose all decorative features when 'invisible' overlay starts at a point where underlying text changes its 'face' property.
2016-02-04 21:20 ` Eli Zaretskii
@ 2016-02-07 20:43 ` Marcin Borkowski
2016-02-07 21:01 ` Eli Zaretskii
0 siblings, 1 reply; 10+ messages in thread
From: Marcin Borkowski @ 2016-02-07 20:43 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: m.pontus, 16760
[-- Attachment #1: Type: text/plain, Size: 973 bytes --]
On 2016-02-04, at 22:20, Eli Zaretskii <eliz@gnu.org> wrote:
>> From: Marcin Borkowski <mbork@mbork.pl>
>> Date: Thu, 04 Feb 2016 22:05:28 +0100
>> Cc: 16760@debbugs.gnu.org
>>
>> I confirm that this is reproducible on GNU Emacs 25.1.50.1.
>
> I think you are wrong, the original bug has been fixed (in Emacs 24.4,
> AFAICT). If you disagree, please show a screenshot of what you see,
> and please explain what is wrong with that. Because I cannot see in
> 25.0.90 anything of what the original report describes: the color of
> the ellipsis in the second line and its scaling are correct.
I attach the screenshot. IIUC, the ellipsis on the middle line should
at least have the size of the surrounding text, and most probably be
green.
The screenshot was taken with GNU Emacs 25.1.50.1, started as emacs -Q.
> Thanks.
Best,
--
Marcin Borkowski
http://octd.wmi.amu.edu.pl/en/Marcin_Borkowski
Faculty of Mathematics and Computer Science
Adam Mickiewicz University
[-- Attachment #2: 2016-02-07-214010_752x695_scrot.png --]
[-- Type: image/png, Size: 67978 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#16760: Ellipses lose all decorative features when 'invisible' overlay starts at a point where underlying text changes its 'face' property.
2016-02-07 20:43 ` Marcin Borkowski
@ 2016-02-07 21:01 ` Eli Zaretskii
2016-02-07 22:24 ` Marcin Borkowski
0 siblings, 1 reply; 10+ messages in thread
From: Eli Zaretskii @ 2016-02-07 21:01 UTC (permalink / raw)
To: Marcin Borkowski; +Cc: m.pontus, 16760
> From: Marcin Borkowski <mbork@mbork.pl>
> Cc: m.pontus@gmail.com, 16760@debbugs.gnu.org
> Date: Sun, 07 Feb 2016 21:43:37 +0100
>
> > I think you are wrong, the original bug has been fixed (in Emacs 24.4,
> > AFAICT). If you disagree, please show a screenshot of what you see,
> > and please explain what is wrong with that. Because I cannot see in
> > 25.0.90 anything of what the original report describes: the color of
> > the ellipsis in the second line and its scaling are correct.
>
> I attach the screenshot. IIUC, the ellipsis on the middle line should
> at least have the size of the surrounding text, and most probably be
> green.
>
> The screenshot was taken with GNU Emacs 25.1.50.1, started as emacs -Q.
Strange. Is that current master? I cannot reproduce this, neither on
master nor on emacs-25. Here, the dots on the 2nd line are of correct
size and their color is red.
If your builds are current, then I guess this is X specific.
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#16760: Ellipses lose all decorative features when 'invisible' overlay starts at a point where underlying text changes its 'face' property.
2016-02-07 21:01 ` Eli Zaretskii
@ 2016-02-07 22:24 ` Marcin Borkowski
2016-02-07 22:34 ` Stephen Berman
2016-02-08 3:29 ` Eli Zaretskii
0 siblings, 2 replies; 10+ messages in thread
From: Marcin Borkowski @ 2016-02-07 22:24 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: m.pontus, 16760
On 2016-02-07, at 22:01, Eli Zaretskii <eliz@gnu.org> wrote:
>> From: Marcin Borkowski <mbork@mbork.pl>
>> Cc: m.pontus@gmail.com, 16760@debbugs.gnu.org
>> Date: Sun, 07 Feb 2016 21:43:37 +0100
>>
>> > I think you are wrong, the original bug has been fixed (in Emacs 24.4,
>> > AFAICT). If you disagree, please show a screenshot of what you see,
>> > and please explain what is wrong with that. Because I cannot see in
>> > 25.0.90 anything of what the original report describes: the color of
>> > the ellipsis in the second line and its scaling are correct.
>>
>> I attach the screenshot. IIUC, the ellipsis on the middle line should
>> at least have the size of the surrounding text, and most probably be
>> green.
>>
>> The screenshot was taken with GNU Emacs 25.1.50.1, started as emacs -Q.
>
> Strange. Is that current master? I cannot reproduce this, neither on
> master nor on emacs-25. Here, the dots on the 2nd line are of correct
> size and their color is red.
Magit says: eb0643c master.
> If your builds are current, then I guess this is X specific.
Maybe. I'm on Fedora 22, with LXDE/Openbox, if that does matter. In
a few days (or weeks) I'll have access to another box with Arch; I'll
try to test it there.
Best,
--
Marcin Borkowski
http://octd.wmi.amu.edu.pl/en/Marcin_Borkowski
Faculty of Mathematics and Computer Science
Adam Mickiewicz University
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#16760: Ellipses lose all decorative features when 'invisible' overlay starts at a point where underlying text changes its 'face' property.
2016-02-07 22:24 ` Marcin Borkowski
@ 2016-02-07 22:34 ` Stephen Berman
2016-02-08 3:29 ` Eli Zaretskii
1 sibling, 0 replies; 10+ messages in thread
From: Stephen Berman @ 2016-02-07 22:34 UTC (permalink / raw)
To: Marcin Borkowski; +Cc: m.pontus, 16760
On Sun, 07 Feb 2016 23:24:37 +0100 Marcin Borkowski <mbork@mbork.pl> wrote:
> On 2016-02-07, at 22:01, Eli Zaretskii <eliz@gnu.org> wrote:
>
>>> From: Marcin Borkowski <mbork@mbork.pl>
>>> Cc: m.pontus@gmail.com, 16760@debbugs.gnu.org
>>> Date: Sun, 07 Feb 2016 21:43:37 +0100
>>>
>>> > I think you are wrong, the original bug has been fixed (in Emacs 24.4,
>>> > AFAICT). If you disagree, please show a screenshot of what you see,
>>> > and please explain what is wrong with that. Because I cannot see in
>>> > 25.0.90 anything of what the original report describes: the color of
>>> > the ellipsis in the second line and its scaling are correct.
>>>
>>> I attach the screenshot. IIUC, the ellipsis on the middle line should
>>> at least have the size of the surrounding text, and most probably be
>>> green.
>>>
>>> The screenshot was taken with GNU Emacs 25.1.50.1, started as emacs -Q.
>>
>> Strange. Is that current master? I cannot reproduce this, neither on
>> master nor on emacs-25. Here, the dots on the 2nd line are of correct
>> size and their color is red.
>
> Magit says: eb0643c master.
>
>> If your builds are current, then I guess this is X specific.
>
> Maybe. I'm on Fedora 22, with LXDE/Openbox, if that does matter. In
> a few days (or weeks) I'll have access to another box with Arch; I'll
> try to test it there.
With the code you posted, I get what Eli described, not what your
screenshot shows. My system:
In GNU Emacs 25.0.50.17 (x86_64-suse-linux-gnu, GTK+ Version 3.14.15)
of 2016-01-28
Repository revision: 8e5046a6e504c2eba349407251b3e2967ff1cfa9
Windowing system distributor 'The X.Org Foundation', version 11.0.11601000
System Description: openSUSE 13.2 (Harlequin) (x86_64)
Configured using:
'configure --with-xwidgets 'CFLAGS=-Og -g3''
Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND DBUS GCONF GSETTINGS NOTIFY
GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11
XWIDGETS
Also, DE is KDE 4.14.9.
Steve Berman
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#16760: Ellipses lose all decorative features when 'invisible' overlay starts at a point where underlying text changes its 'face' property.
2016-02-07 22:24 ` Marcin Borkowski
2016-02-07 22:34 ` Stephen Berman
@ 2016-02-08 3:29 ` Eli Zaretskii
2016-02-12 20:15 ` Marcin Borkowski
1 sibling, 1 reply; 10+ messages in thread
From: Eli Zaretskii @ 2016-02-08 3:29 UTC (permalink / raw)
To: Marcin Borkowski; +Cc: m.pontus, 16760
> From: Marcin Borkowski <mbork@mbork.pl>
> Cc: m.pontus@gmail.com, 16760@debbugs.gnu.org
> Date: Sun, 07 Feb 2016 23:24:37 +0100
>
> >> The screenshot was taken with GNU Emacs 25.1.50.1, started as emacs -Q.
> >
> > Strange. Is that current master? I cannot reproduce this, neither on
> > master nor on emacs-25. Here, the dots on the 2nd line are of correct
> > size and their color is red.
>
> Magit says: eb0643c master.
That's almost a month ago. It's possible that the fix was merged to
master later than that. Can you try a more recent repository? Or
build the emacs-25 branch?
Thanks.
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#16760: Ellipses lose all decorative features when 'invisible' overlay starts at a point where underlying text changes its 'face' property.
2016-02-08 3:29 ` Eli Zaretskii
@ 2016-02-12 20:15 ` Marcin Borkowski
2016-02-12 20:33 ` Eli Zaretskii
0 siblings, 1 reply; 10+ messages in thread
From: Marcin Borkowski @ 2016-02-12 20:15 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: m.pontus, 16760-done
On 2016-02-08, at 04:29, Eli Zaretskii <eliz@gnu.org> wrote:
>> From: Marcin Borkowski <mbork@mbork.pl>
>> Cc: m.pontus@gmail.com, 16760@debbugs.gnu.org
>> Date: Sun, 07 Feb 2016 23:24:37 +0100
>>
>> >> The screenshot was taken with GNU Emacs 25.1.50.1, started as emacs -Q.
>> >
>> > Strange. Is that current master? I cannot reproduce this, neither on
>> > master nor on emacs-25. Here, the dots on the 2nd line are of correct
>> > size and their color is red.
>>
>> Magit says: eb0643c master.
>
> That's almost a month ago. It's possible that the fix was merged to
> master later than that. Can you try a more recent repository? Or
> build the emacs-25 branch?
>
> Thanks.
Hi, Eli,
I finally checked this and it is indeed fixed in master. Also, the
problem with ellipses not scaling together woth the text in Org-mode
(which I suspected was related to this) seems also to be fixed. That is
really great, thank you! I'm closing this bug.
Best
--
Marcin Borkowski
http://octd.wmi.amu.edu.pl/en/Marcin_Borkowski
Faculty of Mathematics and Computer Science
Adam Mickiewicz University
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#16760: Ellipses lose all decorative features when 'invisible' overlay starts at a point where underlying text changes its 'face' property.
2016-02-12 20:15 ` Marcin Borkowski
@ 2016-02-12 20:33 ` Eli Zaretskii
0 siblings, 0 replies; 10+ messages in thread
From: Eli Zaretskii @ 2016-02-12 20:33 UTC (permalink / raw)
To: Marcin Borkowski; +Cc: m.pontus, 16760
> From: Marcin Borkowski <mbork@mbork.pl>
> Cc: m.pontus@gmail.com, 16760-done@debbugs.gnu.org
> Date: Fri, 12 Feb 2016 21:15:23 +0100
>
> I finally checked this and it is indeed fixed in master. Also, the
> problem with ellipses not scaling together woth the text in Org-mode
> (which I suspected was related to this) seems also to be fixed. That is
> really great, thank you! I'm closing this bug.
Great, thanks for testing and verifying the fix.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2016-02-12 20:33 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-14 23:40 bug#16760: Ellipses lose all decorative features when 'invisible' overlay starts at a point where underlying text changes its 'face' property Pontus Michael
2016-02-04 21:05 ` Marcin Borkowski
2016-02-04 21:20 ` Eli Zaretskii
2016-02-07 20:43 ` Marcin Borkowski
2016-02-07 21:01 ` Eli Zaretskii
2016-02-07 22:24 ` Marcin Borkowski
2016-02-07 22:34 ` Stephen Berman
2016-02-08 3:29 ` Eli Zaretskii
2016-02-12 20:15 ` Marcin Borkowski
2016-02-12 20:33 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).