From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: acm@muc.de, monnier@iro.umontreal.ca, 49944@debbugs.gnu.org
Subject: bug#49944: parse-partial-sexp fails to signal an error when (> START LIMIT).
Date: Tue, 10 Aug 2021 18:36:33 +0300 [thread overview]
Message-ID: <83k0ktfh1a.fsf@gnu.org> (raw)
In-Reply-To: <87o8a5xscc.fsf@gnus.org> (message from Lars Ingebrigtsen on Tue, 10 Aug 2021 16:54:59 +0200)
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: Eli Zaretskii <eliz@gnu.org>, acm@muc.de, 49944@debbugs.gnu.org
> Date: Tue, 10 Aug 2021 16:54:59 +0200
>
> > So, I don't care if we signal an error when START > END or if we "do
> > nothing" (as is customary in some language's `for` loops), but we should
> > always consider that OLDSTATE is the state that belongs with START and
> > hence we can't start parsing at END towards START because we don't know
> > what parsing state to use at END.
>
> Ah; thanks for the explanation.
>
> But I guess you'll get incorrect results if you pass in any OLDSTATE
> that doesn't belong to START, not just when START and END are swapped?
> It's just that if START/END obviously wrong (i.e., END is smaller than
> START), then the function here "helpfully" swaps them and things get
> even more confusing than they would normally be if you pass in a wrong
> OLDSTATE (or wrong START).
>
> So perhaps signalling an error here is the correct thing after all? (Or
> just not doing any swapping.)
The reordering is the side effect of calling validate_region, so we'd
need to expend extra effort NOT to reorder START and END.
How about just documenting that OLDSTATE should be the state at START,
and that's it?
next prev parent reply other threads:[~2021-08-10 15:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-08 18:01 bug#49944: parse-partial-sexp fails to signal an error when (> START LIMIT) Alan Mackenzie
2021-08-08 18:14 ` Lars Ingebrigtsen
2021-08-08 18:51 ` Alan Mackenzie
2021-08-09 12:42 ` Lars Ingebrigtsen
2021-08-09 16:50 ` Alan Mackenzie
2021-08-10 13:50 ` Lars Ingebrigtsen
2021-08-10 14:03 ` Eli Zaretskii
2021-08-10 14:41 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-10 14:54 ` Lars Ingebrigtsen
2021-08-10 15:07 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-10 15:36 ` Eli Zaretskii [this message]
2021-08-10 15:44 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-10 16:38 ` Eli Zaretskii
2021-08-11 11:04 ` Lars Ingebrigtsen
2021-08-21 13:24 ` Lars Ingebrigtsen
2021-08-21 14:05 ` Alan Mackenzie
2021-08-21 22:11 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-22 10:50 ` Alan Mackenzie
2021-08-22 15:02 ` Lars Ingebrigtsen
2021-08-22 22:54 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83k0ktfh1a.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=49944@debbugs.gnu.org \
--cc=acm@muc.de \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).