From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: acm@muc.de, larsi@gnus.org, 49944@debbugs.gnu.org
Subject: bug#49944: parse-partial-sexp fails to signal an error when (> START LIMIT).
Date: Tue, 10 Aug 2021 19:38:51 +0300 [thread overview]
Message-ID: <83czqlfe5g.fsf@gnu.org> (raw)
In-Reply-To: <jwvy2995mva.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Tue, 10 Aug 2021 11:44:55 -0400)
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Lars Ingebrigtsen <larsi@gnus.org>, acm@muc.de, 49944@debbugs.gnu.org
> Date: Tue, 10 Aug 2021 11:44:55 -0400
>
> > The reordering is the side effect of calling validate_region, so we'd
> > need to expend extra effort NOT to reorder START and END.
> >
> > How about just documenting that OLDSTATE should be the state at START,
> > and that's it?
>
> The current use of `validate_region` means that OLDSTATE will be used as
> the state at "either FROM or TO, whichever is smaller".
>
> So I don't understand what it is you're proposing: if we document
> that OLDSTATE should be the state at FROM, then we need to change the
> code so that it never swaps FROM and TO. And if we don't want to change
> the code, then we should document that OLDSTATE will be used as the
> state at TO when TO is smaller than FROM.
The latter. By documenting the expectations of the function, we leave
it to the callers to make sure their code works as intended.
next prev parent reply other threads:[~2021-08-10 16:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-08 18:01 bug#49944: parse-partial-sexp fails to signal an error when (> START LIMIT) Alan Mackenzie
2021-08-08 18:14 ` Lars Ingebrigtsen
2021-08-08 18:51 ` Alan Mackenzie
2021-08-09 12:42 ` Lars Ingebrigtsen
2021-08-09 16:50 ` Alan Mackenzie
2021-08-10 13:50 ` Lars Ingebrigtsen
2021-08-10 14:03 ` Eli Zaretskii
2021-08-10 14:41 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-10 14:54 ` Lars Ingebrigtsen
2021-08-10 15:07 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-10 15:36 ` Eli Zaretskii
2021-08-10 15:44 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-10 16:38 ` Eli Zaretskii [this message]
2021-08-11 11:04 ` Lars Ingebrigtsen
2021-08-21 13:24 ` Lars Ingebrigtsen
2021-08-21 14:05 ` Alan Mackenzie
2021-08-21 22:11 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-22 10:50 ` Alan Mackenzie
2021-08-22 15:02 ` Lars Ingebrigtsen
2021-08-22 22:54 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83czqlfe5g.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=49944@debbugs.gnu.org \
--cc=acm@muc.de \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).