From: Eli Zaretskii <eliz@gnu.org>
To: Vince Salvino <salvino@coderedcorp.com>
Cc: 51404@debbugs.gnu.org
Subject: bug#51404: Support system dark mode on Windows 10
Date: Sat, 30 Oct 2021 20:39:17 +0300 [thread overview]
Message-ID: <83k0huo1iy.fsf@gnu.org> (raw)
In-Reply-To: <ddm9cg097co1e4d11e8bh6c6.1635613989653@coderedcorp.com> (message from Vince Salvino on Sat, 30 Oct 2021 17:13:13 +0000)
> From: Vince Salvino <salvino@coderedcorp.com>
> CC: "51404@debbugs.gnu.org" <51404@debbugs.gnu.org>
> Date: Sat, 30 Oct 2021 17:13:13 +0000
>
> > define a variable exposed to Lisp using DEFVAR_BOOL; let's call it w32-follow-system-theme
>
> My thought would be to give the user a bit more control. Rather than saying to follow system theme or not, perhaps they could choose from 3 values: follow theme, light, or dark, e.g.:
>
> w32-system-theme:
> * nil: follow system theme (default)
> * light: force light mode (the old behavior)
> * dark: force dark mode
I'm not sure I understand why 'light' necessarily means the old
behavior: we didn't set any theme before this change, we just used the
Windows default. So maybe there should be 4 values:
nil: never follow the system theme (use Windows default)
t: always follow the system theme
light: force light theme (currently the same as nil)
dark: force dark theme.
> Second, could you provide an existing value from early-init that I
> could follow as an example?
early-init is a file, called literally "early-init.el". If you have
such a file in your ~/.emacs.d/ directory, Emacs will load it early on
during the startup.
> (I never knew early init was a thing, so I am going to research this - it will probably make my personal init customization a lot better too!)
The recommendation is to move to early-init.el only stuff that cannot
work in the normal init file. That's because early-init is processed
when some of the infrastructure is not yet set up, so things could
fail there that will work correctly in the init file.
next prev parent reply other threads:[~2021-10-30 17:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 4:46 bug#51404: Support system dark mode on Windows 10 Vince Salvino
2021-10-26 14:01 ` Eli Zaretskii
2021-10-26 16:18 ` Eli Zaretskii
2021-10-26 16:49 ` Vince Salvino
2021-10-26 17:05 ` Eli Zaretskii
2021-10-26 18:20 ` Vince Salvino
2021-10-27 21:41 ` Vince Salvino
2021-10-28 7:15 ` Eli Zaretskii
2021-10-30 10:34 ` Eli Zaretskii
2021-10-30 17:13 ` Vince Salvino
2021-10-30 17:39 ` Eli Zaretskii [this message]
2021-11-11 5:36 ` bug#47291: " Lars Ingebrigtsen
2021-11-11 7:51 ` Eli Zaretskii
2021-11-11 12:15 ` Lars Ingebrigtsen
2021-11-11 15:08 ` Eli Zaretskii
2021-11-12 3:00 ` Lars Ingebrigtsen
2021-11-12 6:19 ` Eli Zaretskii
2022-01-14 6:00 ` Vince Salvino
2022-01-23 0:00 ` Vince Salvino
2022-01-29 3:34 ` bug#51404: " Vince Salvino
2022-01-29 8:40 ` bug#51404: " Eli Zaretskii
2022-01-29 20:27 ` Vince Salvino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83k0huo1iy.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=51404@debbugs.gnu.org \
--cc=salvino@coderedcorp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).