From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: salvino@coderedcorp.com, 51404@debbugs.gnu.org, 47291@debbugs.gnu.org
Subject: bug#47291: bug#51404: Support system dark mode on Windows 10
Date: Thu, 11 Nov 2021 13:15:03 +0100 [thread overview]
Message-ID: <87wnle6g8o.fsf@gnus.org> (raw)
In-Reply-To: <83wnlf166j.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 11 Nov 2021 09:51:16 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
> I'm not sure unification is possible here, because the functionality
> is quite different, AFAICT. At least for the functionality in this
> bug report, we cannot apply the system theme to an existing frame, we
> can only apply it at frame creation time. So having a handler for
> such changes will be able to affect only the frames created after the
> change. Or at least that is my understanding; the code definitely
> applies the dark/light theme as part of creating a frame.
Gtk Emacs doesn't respond to dark mode either -- so we have the
opportunity to decide how to handle these things across the board.
Perhaps in Gtk Emacs, dynamic-setting-handle-config-changed-event should
also just set something that will make the next frame creation use
different colours?
> Also, having a dynamic thing that tracks changes in these settings
> would on Windows mean listening and processing a special window-system
> message, which seems to be WM_THEMECHANGED or maybe WM_SETTINGCHANGE.
> But that's not what the code installed in this bug report does.
>
> So the functionality seems similar, but the details differ.
But perhaps Windows should be listening to those events, too?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-11-11 12:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 4:46 bug#51404: Support system dark mode on Windows 10 Vince Salvino
2021-10-26 14:01 ` Eli Zaretskii
2021-10-26 16:18 ` Eli Zaretskii
2021-10-26 16:49 ` Vince Salvino
2021-10-26 17:05 ` Eli Zaretskii
2021-10-26 18:20 ` Vince Salvino
2021-10-27 21:41 ` Vince Salvino
2021-10-28 7:15 ` Eli Zaretskii
2021-10-30 10:34 ` Eli Zaretskii
2021-10-30 17:13 ` Vince Salvino
2021-10-30 17:39 ` Eli Zaretskii
2021-11-11 5:36 ` bug#47291: " Lars Ingebrigtsen
2021-11-11 7:51 ` Eli Zaretskii
2021-11-11 12:15 ` Lars Ingebrigtsen [this message]
2021-11-11 15:08 ` Eli Zaretskii
2021-11-12 3:00 ` Lars Ingebrigtsen
2021-11-12 6:19 ` Eli Zaretskii
2022-01-14 6:00 ` Vince Salvino
2022-01-23 0:00 ` Vince Salvino
2022-01-29 3:34 ` bug#51404: " Vince Salvino
2022-01-29 8:40 ` bug#51404: " Eli Zaretskii
2022-01-29 20:27 ` Vince Salvino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wnle6g8o.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=47291@debbugs.gnu.org \
--cc=51404@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=salvino@coderedcorp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).