bug#10309: 24.0.92; [wishlist] Add an option to disable "auto-refining" while moving between hunks in diff mode

bug#10309: 24.0.92; [wishlist] Add an option to disable "auto-refining" while moving between hunks in diff mode

[Dani Moncayo]

Severity: wishlist

In diff mode, the commands bound to M-n/M-p move the point to the
next/previous hunk, but they do one more thing: they also refine the
hunk where point jumps to.

I'd like to have the option to control (enable/disable) that automatic
refining, because:
* Sometimes I don't _need_ it (so my browsing could be faster).
* Sometimes I don't _want_ it (when the hunk contains many changed
lines, the refined hunk looks confusing).

TIA.

In GNU Emacs 24.0.92.1 (i386-mingw-nt5.1.2600)
 of 2011-12-10 on DANI-PC
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.6) --no-opt --cflags
-fno-omit-frame-pointer'

-- 
Dani Moncayo

bug#10309: 24.0.92; [wishlist] Add an option to disable "auto-refining" while moving between hunks in diff mode

[Andreas Schwab]

Dani Moncayo <dmoncayo@gmail.com> writes:

> I'd like to have the option to control (enable/disable) that automatic
> refining, because:

diff-auto-refine-mode

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

bug#10309: 24.0.92; [wishlist] Add an option to disable "auto-refining" while moving between hunks in diff mode

[Dani Moncayo]

>> I'd like to have the option to control (enable/disable) that automatic
>> refining, because:
>
> diff-auto-refine-mode

Ok, thanks.  Then:

1) I'd like to control whether that minor mode is enabled by default
after invoking the `diff' command.  Currently it is, and I'd like it
wasn't.

2) IMO, the info node "(emacs)Diff Mode" should explain the concept of
"refined hunks" and also the `diff-auto-refine' minor mode.


-- 
Dani Moncayo

bug#10309: 24.0.92; [wishlist] Add an option to disable "auto-refining" while movingbetween hunks in diff mode

[Drew Adams]

> IMO, the info node "(emacs)Diff Mode" should explain the concept of
> "refined hunks" and also the `diff-auto-refine' minor mode.

+1.

And instead of just saying "make it writable first", say "make it writable first
(`C-x C-q')" to let newbies know how to do that.  That costs only a few extra
characters and does not interrupt the flow.

bug#10309: 24.0.92; [wishlist] Add an option to disable "auto-refining" while moving between hunks in diff mode

[Juanma Barranquero]

On Fri, Dec 16, 2011 at 17:54, Dani Moncayo <dmoncayo@gmail.com> wrote:

> 1) I'd like to control whether that minor mode is enabled by default
> after invoking the `diff' command.  Currently it is, and I'd like it
> wasn't.

What about

  (setq-default diff-auto-refine-mode nil)

in your .emacs?

    Juanma

bug#10309: 24.0.92; [wishlist] Add an option to disable "auto-refining" while moving between hunks in diff mode

[Dani Moncayo]

>> 1) I'd like to control whether that minor mode is enabled by default
>> after invoking the `diff' command.  Currently it is, and I'd like it
>> wasn't.
>
> What about
>
>  (setq-default diff-auto-refine-mode nil)
>
> in your .emacs?

I thought it too, and it seems to work, but I saw the docstring of
that variable, and it seem to advise against changing the variable at
user-level:

  Non-nil if Diff-Auto-Refine mode is enabled.
  Use the command `diff-auto-refine-mode' to change this variable.

Why?

-- 
Dani Moncayo

bug#10309: 24.0.92; [wishlist] Add an option to disable "auto-refining" while moving between hunks in diff mode

[Juanma Barranquero]

On Fri, Dec 16, 2011 at 18:53, Dani Moncayo <dmoncayo@gmail.com> wrote:

> I thought it too, and it seems to work, but I saw the docstring of
> that variable, and it seem to advise against changing the variable at
> user-level:
>
>  Non-nil if Diff-Auto-Refine mode is enabled.
>  Use the command `diff-auto-refine-mode' to change this variable.
>
> Why?

Usually, every minor mode as as associated variable, but obviously the
work is done by the function (the variable just acts as a flag to know
whether the minor mode is active or not).

In this case, the minor mode is defined with ":init-value t", so it
defaults to active. If you check the macroexpansion of the minor-mode
definition, you'll see it does

  (defvar diff-auto-refine-mode t
    "Non-nil if Diff-Auto-Refine mode is enabled.
  Use the command `diff-auto-refine-mode' to change this variable.")
  (make-variable-buffer-local 'diff-auto-refine-mode)

so if you want it to default to disabled, you have to set it so.

    Juanma

bug#10309: 24.0.92; [wishlist] Add an option to disable "auto-refining" while moving between hunks in diff mode

[Dani Moncayo]

>> I thought it too, and it seems to work, but I saw the docstring of
>> that variable, and it seem to advise against changing the variable at
>> user-level:
>>
>>  Non-nil if Diff-Auto-Refine mode is enabled.
>>  Use the command `diff-auto-refine-mode' to change this variable.
>>
>> Why?
>
> Usually, every minor mode as as associated variable, but obviously the
> work is done by the function (the variable just acts as a flag to know
> whether the minor mode is active or not).
>
> In this case, the minor mode is defined with ":init-value t", so it
> defaults to active. If you check the macroexpansion of the minor-mode
> definition, you'll see it does
>
>  (defvar diff-auto-refine-mode t
>    "Non-nil if Diff-Auto-Refine mode is enabled.
>  Use the command `diff-auto-refine-mode' to change this variable.")
>  (make-variable-buffer-local 'diff-auto-refine-mode)
>
> so if you want it to default to disabled, you have to set it so.

I understand.

So, in the info node I mentioned before, please also explain this,
i.e., that the diff-auto-refine minor mode can be turned off by
default by setting the default value of `diff-auto-refine-mode' to
`nil'.

Thank you.

-- 
Dani Moncayo

bug#10309: 24.0.92; [wishlist] Add an option to disable "auto-refining" while moving between hunks in diff mode

[Eli Zaretskii]

> From: Juanma Barranquero <lekktu@gmail.com>
> Date: Fri, 16 Dec 2011 18:42:22 +0100
> Cc: Andreas Schwab <schwab@linux-m68k.org>, 10309@debbugs.gnu.org
> 
> On Fri, Dec 16, 2011 at 17:54, Dani Moncayo <dmoncayo@gmail.com> wrote:
> 
> > 1) I'd like to control whether that minor mode is enabled by default
> > after invoking the `diff' command.  Currently it is, and I'd like it
> > wasn't.
> 
> What about
> 
>   (setq-default diff-auto-refine-mode nil)
> 
> in your .emacs?

Or turn diff-auto-refine-mode off in the diff-mode-hook.

bug#10309: 24.0.92; [wishlist] Add an option to disable "auto-refining" while moving between hunks in diff mode

[Chong Yidong]

Dani Moncayo <dmoncayo@gmail.com> writes:

> 2) IMO, the info node "(emacs)Diff Mode" should explain the concept of
> "refined hunks" and also the `diff-auto-refine' minor mode.

Done.