From: Eli Zaretskii <eliz@gnu.org>
To: aidalgol@amuri.net
Cc: 18438@debbugs.gnu.org
Subject: bug#18438: 24.4.50; assertion failed in bidi.c
Date: Tue, 30 Sep 2014 18:24:15 +0300 [thread overview]
Message-ID: <83iok5ku74.fsf@gnu.org> (raw)
In-Reply-To: <6b19fab333f3d362ae61b30b299d7206@amuri.net>
> Date: Tue, 30 Sep 2014 11:28:35 +1300
> From: aidalgol@amuri.net
> Cc: Eli Zaretskii <eliz@gnu.org>, Ken Brown <kbrown@cornell.edu>
>
> On Mon, 29 Sep 2014 20:00:16 +0300, Eli Zaretskii wrote:
> >
> > Let's start by replacing eassert with its equivalent. Please run
> > with
> > the change below for some time and see if the assertions still
> > happen.
> >
> > (The purpose is to see whether small changes in the code have drastic
> > effects on the problem. If they do, it will be hard to know whether
> > some more serious change solves the problem or simply hides it.)
>
> Yes, they're still happening; I just got one after running with the
> patch for only a few hours.
OK, so far so good. How about the one below (which tries to reveal
the face of the beast)?
=== modified file 'src/bidi.c'
--- src/bidi.c 2014-04-06 15:56:01 +0000
+++ src/bidi.c 2014-09-30 15:21:28 +0000
@@ -326,7 +326,12 @@ bidi_get_type (int ch, bidi_dir_t overri
static void
bidi_check_type (bidi_type_t type)
{
- eassert (UNKNOWN_BT <= type && type <= NEUTRAL_ON);
+ if (!(suppress_checking || (UNKNOWN_BT <= type && type <= NEUTRAL_ON)))
+ {
+ fprintf (stderr, "\r\n%s:%d: bidi type %d is not in [%d..%d]\r\n",
+ __FILE__, __LINE__, type, UNKNOWN_BT, NEUTRAL_ON);
+ emacs_abort ();
+ }
}
/* Given a bidi TYPE of a character, return its category. */
next prev parent reply other threads:[~2014-09-30 15:24 UTC|newest]
Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 21:41 bug#18438: 24.4.50; assertion failed in bidi.c aidalgol
2014-09-10 0:16 ` Stefan Monnier
2014-09-10 18:55 ` Aidan Gauland
2014-09-10 19:09 ` Eli Zaretskii
2014-09-11 4:31 ` aidalgol
2014-09-11 13:18 ` Ken Brown
2014-09-12 1:51 ` aidalgol
2014-09-12 1:55 ` aidalgol
2014-09-12 6:00 ` Eli Zaretskii
2014-09-12 7:46 ` Eli Zaretskii
2014-09-16 1:04 ` aidalgol
2014-09-16 2:47 ` Eli Zaretskii
2014-09-16 2:59 ` aidalgol
2014-09-16 14:33 ` Eli Zaretskii
2014-09-16 22:42 ` aidalgol
2014-09-17 5:07 ` Eli Zaretskii
2014-09-18 4:55 ` aidalgol
2014-09-18 4:59 ` aidalgol
2014-09-18 14:42 ` Eli Zaretskii
2014-09-21 22:30 ` Ken Brown
2014-09-24 5:07 ` aidalgol
2014-09-24 14:06 ` Ken Brown
2014-09-24 15:01 ` Eli Zaretskii
2014-09-24 16:40 ` Ken Brown
2014-09-24 19:49 ` Eli Zaretskii
2014-09-28 23:03 ` aidalgol
2014-09-10 13:14 ` Ken Brown
2014-09-29 0:56 ` aidalgol
2014-09-29 6:23 ` Eli Zaretskii
2014-09-29 15:50 ` Ken Brown
2014-09-29 17:00 ` Eli Zaretskii
2014-09-29 22:28 ` aidalgol
2014-09-30 15:24 ` Eli Zaretskii [this message]
2014-09-30 16:09 ` Ken Brown
2014-09-30 16:27 ` Eli Zaretskii
2014-09-30 23:06 ` aidalgol
2014-10-01 2:39 ` Eli Zaretskii
2014-10-01 2:58 ` aidalgol
2014-10-01 14:42 ` Eli Zaretskii
2014-10-01 21:56 ` aidalgol
2014-10-01 2:40 ` Ken Brown
2014-10-08 22:20 ` aidalgol
2014-10-09 7:29 ` Eli Zaretskii
2014-10-10 2:21 ` aidalgol
2014-10-10 7:19 ` Eli Zaretskii
2014-10-10 7:26 ` Eli Zaretskii
2014-10-10 13:54 ` Ken Brown
2014-10-10 15:12 ` Eli Zaretskii
2014-10-10 17:14 ` Ken Brown
2014-10-11 1:57 ` Ken Brown
2014-10-11 7:11 ` Eli Zaretskii
2014-10-11 13:58 ` Ken Brown
2014-10-11 14:24 ` Eli Zaretskii
2014-10-11 16:33 ` Ken Brown
2014-10-11 16:52 ` Eli Zaretskii
2014-10-11 17:17 ` Ken Brown
2014-10-15 0:58 ` aidalgol
2014-10-15 5:13 ` Eli Zaretskii
2014-10-15 19:29 ` aidalgol
2014-10-16 7:27 ` Eli Zaretskii
2014-10-16 13:11 ` Ken Brown
2014-10-16 13:38 ` Eli Zaretskii
2014-10-19 14:39 ` Eli Zaretskii
2014-10-19 15:37 ` Ken Brown
2014-10-19 18:10 ` Eli Zaretskii
2014-10-19 19:49 ` aidalgol
2014-10-19 20:20 ` aidalgol
2014-10-20 15:46 ` Eli Zaretskii
2014-10-20 16:51 ` Eli Zaretskii
2014-10-20 19:35 ` Ivan Shmakov
2014-10-20 19:39 ` Eli Zaretskii
2014-10-20 20:02 ` Ivan Shmakov
2014-10-20 20:59 ` Ken Brown
2014-10-21 15:42 ` Eli Zaretskii
2014-10-21 16:18 ` Ken Brown
2014-10-21 19:38 ` aidalgol
2014-10-21 21:12 ` Ken Brown
2014-10-21 21:58 ` aidalgol
2014-10-21 22:21 ` Ken Brown
2014-10-21 22:38 ` aidalgol
2014-10-22 4:16 ` aidalgol
2014-10-22 15:24 ` Eli Zaretskii
2014-10-22 17:16 ` Eli Zaretskii
2014-10-22 20:39 ` Ken Brown
2014-10-23 20:38 ` aidalgol
2014-10-23 21:54 ` aidalgol
2014-10-24 6:50 ` Eli Zaretskii
2014-10-24 19:18 ` Ken Brown
2014-10-24 21:19 ` Ken Brown
2014-10-29 4:30 ` aidalgol
2014-10-29 12:15 ` Ken Brown
2014-10-29 14:37 ` Eli Zaretskii
2015-12-26 15:37 ` bug#17817: " Lars Ingebrigtsen
2015-12-26 15:43 ` Ken Brown
2014-10-29 14:17 ` Eli Zaretskii
2014-10-23 4:15 ` aidalgol
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83iok5ku74.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=18438@debbugs.gnu.org \
--cc=aidalgol@amuri.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).