From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#18438: 24.4.50; assertion failed in bidi.c Date: Tue, 30 Sep 2014 18:24:15 +0300 Message-ID: <83iok5ku74.fsf@gnu.org> References: <4745242cd3e424a6c4d5db0e8d3e33d0@amuri.net> <83h9zrlzc8.fsf@gnu.org> <54297FDB.6090606@cornell.edu> <837g0mmkf3.fsf@gnu.org> <6b19fab333f3d362ae61b30b299d7206@amuri.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1412090725 5926 80.91.229.3 (30 Sep 2014 15:25:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 30 Sep 2014 15:25:25 +0000 (UTC) Cc: 18438@debbugs.gnu.org To: aidalgol@amuri.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 30 17:25:18 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XYzIj-0008Ph-JB for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Sep 2014 17:25:17 +0200 Original-Received: from localhost ([::1]:43963 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYzIi-0002Og-V0 for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Sep 2014 11:25:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51052) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYzIa-0002Dv-1l for bug-gnu-emacs@gnu.org; Tue, 30 Sep 2014 11:25:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XYzIV-00028Q-37 for bug-gnu-emacs@gnu.org; Tue, 30 Sep 2014 11:25:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:36671) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYzIV-000287-0t for bug-gnu-emacs@gnu.org; Tue, 30 Sep 2014 11:25:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XYzIU-0004q8-60 for bug-gnu-emacs@gnu.org; Tue, 30 Sep 2014 11:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Sep 2014 15:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18438 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 18438-submit@debbugs.gnu.org id=B18438.141209066618550 (code B ref 18438); Tue, 30 Sep 2014 15:25:02 +0000 Original-Received: (at 18438) by debbugs.gnu.org; 30 Sep 2014 15:24:26 +0000 Original-Received: from localhost ([127.0.0.1]:56468 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XYzHt-0004p7-5h for submit@debbugs.gnu.org; Tue, 30 Sep 2014 11:24:25 -0400 Original-Received: from mtaout24.012.net.il ([80.179.55.180]:58541) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XYzHr-0004oy-74 for 18438@debbugs.gnu.org; Tue, 30 Sep 2014 11:24:24 -0400 Original-Received: from conversion-daemon.mtaout24.012.net.il by mtaout24.012.net.il (HyperSendmail v2007.08) id <0NCP00I00ZJJ0K00@mtaout24.012.net.il> for 18438@debbugs.gnu.org; Tue, 30 Sep 2014 18:18:32 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout24.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NCP00E92ZUW8050@mtaout24.012.net.il>; Tue, 30 Sep 2014 18:18:32 +0300 (IDT) In-reply-to: <6b19fab333f3d362ae61b30b299d7206@amuri.net> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:93915 Archived-At: > Date: Tue, 30 Sep 2014 11:28:35 +1300 > From: aidalgol@amuri.net > Cc: Eli Zaretskii , Ken Brown > > On Mon, 29 Sep 2014 20:00:16 +0300, Eli Zaretskii wrote: > > > > Let's start by replacing eassert with its equivalent. Please run > > with > > the change below for some time and see if the assertions still > > happen. > > > > (The purpose is to see whether small changes in the code have drastic > > effects on the problem. If they do, it will be hard to know whether > > some more serious change solves the problem or simply hides it.) > > Yes, they're still happening; I just got one after running with the > patch for only a few hours. OK, so far so good. How about the one below (which tries to reveal the face of the beast)? === modified file 'src/bidi.c' --- src/bidi.c 2014-04-06 15:56:01 +0000 +++ src/bidi.c 2014-09-30 15:21:28 +0000 @@ -326,7 +326,12 @@ bidi_get_type (int ch, bidi_dir_t overri static void bidi_check_type (bidi_type_t type) { - eassert (UNKNOWN_BT <= type && type <= NEUTRAL_ON); + if (!(suppress_checking || (UNKNOWN_BT <= type && type <= NEUTRAL_ON))) + { + fprintf (stderr, "\r\n%s:%d: bidi type %d is not in [%d..%d]\r\n", + __FILE__, __LINE__, type, UNKNOWN_BT, NEUTRAL_ON); + emacs_abort (); + } } /* Given a bidi TYPE of a character, return its category. */