unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#35307: sql.el - Product "ms" is missing  "prompt-cont-regexp"
@ 2019-04-17 17:10 Sebastián Monía
  2019-04-18 13:55 ` Eli Zaretskii
  0 siblings, 1 reply; 5+ messages in thread
From: Sebastián Monía @ 2019-04-17 17:10 UTC (permalink / raw)
  To: 35307

[-- Attachment #1: Type: text/plain, Size: 779 bytes --]

I've noticed this in the past but for reason didn't notice I should report it until I downloaded the Emacs 27 Alpha recently and had to fix it again.
The configuration for MS SQL Server in sql.el is missing "prompt-cont-regexp" and thus breaks when you launch SQLi.

All that is needed is the following:

(ms
     :name "Microsoft"
     :font-lock sql-mode-ms-font-lock-keywords
     :sqli-program sql-ms-program
     :sqli-options sql-ms-options
     :sqli-login sql-ms-login-params
     :sqli-comint-func sql-comint-ms
     :prompt-regexp "^[0-9]*>"
      ;; below the new line
     :prompt-cont-regexp "^[0-9]*>"
      ;; above the new line
     :prompt-length 5
     :syntax-alist ((?@ . "_"))
     :terminator ("^go" . "go"))


Thank you!
Sebastián


[-- Attachment #2: Type: text/html, Size: 2939 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#35307: sql.el - Product "ms" is missing "prompt-cont-regexp"
  2019-04-17 17:10 bug#35307: sql.el - Product "ms" is missing "prompt-cont-regexp" Sebastián Monía
@ 2019-04-18 13:55 ` Eli Zaretskii
  2019-04-18 16:18   ` Glenn Morris
  2019-04-21  5:35   ` Michael Mauger
  0 siblings, 2 replies; 5+ messages in thread
From: Eli Zaretskii @ 2019-04-18 13:55 UTC (permalink / raw)
  To: Sebastián Monía, Michael Mauger; +Cc: 35307

> From: Sebastián Monía
> 	<seb.hoagie@outlook.com>
> Date: Wed, 17 Apr 2019 17:10:22 +0000
> 
> I've noticed this in the past but for reason didn't notice I should report it until I downloaded the Emacs 27 Alpha
> recently and had to fix it again.
> The configuration for MS SQL Server in sql.el is missing "prompt-cont-regexp" and thus breaks when you
> launch SQLi.
> 
> All that is needed is the following:
> 
> (ms
>      :name "Microsoft"
>      :font-lock sql-mode-ms-font-lock-keywords
>      :sqli-program sql-ms-program
>      :sqli-options sql-ms-options
>      :sqli-login sql-ms-login-params
>      :sqli-comint-func sql-comint-ms
>      :prompt-regexp "^[0-9]*>"
>       ;; below the new line
>      :prompt-cont-regexp "^[0-9]*>"
>       ;; above the new line
>      :prompt-length 5
>      :syntax-alist ((?@ . "_"))
>      :terminator ("^go" . "go"))

Thanks.  Michael, could you please look into this?





^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#35307: sql.el - Product "ms" is missing "prompt-cont-regexp"
  2019-04-18 13:55 ` Eli Zaretskii
@ 2019-04-18 16:18   ` Glenn Morris
  2019-04-21  5:35   ` Michael Mauger
  1 sibling, 0 replies; 5+ messages in thread
From: Glenn Morris @ 2019-04-18 16:18 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: Michael Mauger, Sebastián Monía, 35307


See also
https://debbugs.gnu.org/24483
https://debbugs.gnu.org/27586

(and probably
https://debbugs.gnu.org/cgi/pkgreport.cgi?include=subject%3Asql;package=emacs )





^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#35307: sql.el - Product "ms" is missing "prompt-cont-regexp"
  2019-04-18 13:55 ` Eli Zaretskii
  2019-04-18 16:18   ` Glenn Morris
@ 2019-04-21  5:35   ` Michael Mauger
  2019-04-21  6:12     ` Eli Zaretskii
  1 sibling, 1 reply; 5+ messages in thread
From: Michael Mauger @ 2019-04-21  5:35 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 35307-close@debbugs.gnu.org, Sebastián Monía


‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Thursday, April 18, 2019 9:55 AM, Eli Zaretskii <eliz@gnu.org> wrote:

> > From: Sebastián Monía
>
> > seb.hoagie@outlook.com
> > Date: Wed, 17 Apr 2019 17:10:22 +0000
> > I've noticed this in the past but for reason didn't notice I should report it until I downloaded the Emacs 27 Alpha
> > recently and had to fix it again.
> > The configuration for MS SQL Server in sql.el is missing "prompt-cont-regexp" and thus breaks when you
> > launch SQLi.
> > All that is needed is the following:
> > (ms
> > :name "Microsoft"
> > :font-lock sql-mode-ms-font-lock-keywords
> > :sqli-program sql-ms-program
> > :sqli-options sql-ms-options
> > :sqli-login sql-ms-login-params
> > :sqli-comint-func sql-comint-ms
> > :prompt-regexp "^[0-9]>"
> > ;; below the new line
> > :prompt-cont-regexp "^[0-9]>";; above the new line
> > :prompt-length 5
> > :syntax-alist ((?@ . "_"))
> > :terminator ("^go" . "go"))
>
> Thanks. Michael, could you please look into this?

The property has been added to the ms dialect, and the code has been enhanced to
properly handle the absence of the property.

--
MICHAEL@MAUGER.COM // FSF and EFF member // GNU Emacs sql.el maintainer






^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#35307: sql.el - Product "ms" is missing "prompt-cont-regexp"
  2019-04-21  5:35   ` Michael Mauger
@ 2019-04-21  6:12     ` Eli Zaretskii
  0 siblings, 0 replies; 5+ messages in thread
From: Eli Zaretskii @ 2019-04-21  6:12 UTC (permalink / raw)
  To: Michael Mauger; +Cc: seb.hoagie, 35307

> Date: Sun, 21 Apr 2019 05:35:02 +0000
> From: Michael Mauger <mmauger@protonmail.com>
> Cc: Sebastián Monía <seb.hoagie@outlook.com>, "35307-close@debbugs.gnu.org" <35307-close@debbugs.gnu.org>
> 
> The property has been added to the ms dialect, and the code has been enhanced to
> properly handle the absence of the property.

Thanks!





^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-04-21  6:12 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-17 17:10 bug#35307: sql.el - Product "ms" is missing "prompt-cont-regexp" Sebastián Monía
2019-04-18 13:55 ` Eli Zaretskii
2019-04-18 16:18   ` Glenn Morris
2019-04-21  5:35   ` Michael Mauger
2019-04-21  6:12     ` Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).