* bug#20694: 25.0.50; Please bind `p' and `n' in apropos-mode
@ 2015-05-30 0:27 Juliusz Chroboczek
2016-12-13 2:18 ` Justin Timmons
2019-09-29 23:40 ` Stefan Kangas
0 siblings, 2 replies; 12+ messages in thread
From: Juliusz Chroboczek @ 2015-05-30 0:27 UTC (permalink / raw)
To: 20694
Severity: wishlist
In apropos-mode, the keys `p' and `n' should jump to the previous/next
label (not button).
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#20694: 25.0.50; Please bind `p' and `n' in apropos-mode
2015-05-30 0:27 bug#20694: 25.0.50; Please bind `p' and `n' in apropos-mode Juliusz Chroboczek
@ 2016-12-13 2:18 ` Justin Timmons
2019-09-29 23:40 ` Stefan Kangas
1 sibling, 0 replies; 12+ messages in thread
From: Justin Timmons @ 2016-12-13 2:18 UTC (permalink / raw)
To: Juliusz Chroboczek; +Cc: 20694
[-- Attachment #1: Type: text/plain, Size: 287 bytes --]
I wrote up a quick set of functions which accomplishes this and added them
to the apropos-mode keymap - see the attached patch file.
The functions search forward (or backwards) for the 'apropos-symbol
face; there could be a cleaner way to do this, but this seems to work
pretty well.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Patch to add symbol movement to apropos-mode --]
[-- Type: text/x-patch, Size: 1296 bytes --]
diff --git a/lisp/apropos.el b/lisp/apropos.el
index 7c9ec12..d5a9a3a 100644
--- a/lisp/apropos.el
+++ b/lisp/apropos.el
@@ -160,6 +160,10 @@ If value is `verbose', the computed score is shown for each match."
;; definition of RET, so that users can use it anywhere in an
;; apropos item, not just on top of a button.
(define-key map "\C-m" 'apropos-follow)
+
+ ;; Movement keys
+ (define-key map "n" 'apropos-next-symbol)
+ (define-key map "p" 'apropos-previous-symbol)
map)
"Keymap used in Apropos mode.")
@@ -1209,6 +1213,24 @@ as a heading."
(error "There is nothing to follow here"))))
+(defun apropos-next-symbol ()
+ "Move cursor down to the next symbol in an apropos-mode buffer."
+ (interactive)
+ (forward-line)
+ (while (and (not (eq (face-at-point) 'apropos-symbol))
+ (< (point) (point-max)))
+ (forward-line)))
+
+
+(defun apropos-previous-symbol ()
+ "Move cursor back to the last symbol in an apropos-mode buffer."
+ (interactive)
+ (forward-line -1)
+ (while (and (not (eq (face-at-point) 'apropos-symbol))
+ (> (point) (point-min)))
+ (forward-line -1)))
+
+
(defun apropos-describe-plist (symbol)
"Display a pretty listing of SYMBOL's plist."
(help-setup-xref (list 'apropos-describe-plist symbol)
^ permalink raw reply related [flat|nested] 12+ messages in thread
* bug#20694: 25.0.50; Please bind `p' and `n' in apropos-mode
2015-05-30 0:27 bug#20694: 25.0.50; Please bind `p' and `n' in apropos-mode Juliusz Chroboczek
2016-12-13 2:18 ` Justin Timmons
@ 2019-09-29 23:40 ` Stefan Kangas
2019-10-02 0:50 ` Justin Timmons
1 sibling, 1 reply; 12+ messages in thread
From: Stefan Kangas @ 2019-09-29 23:40 UTC (permalink / raw)
To: Justin Timmons; +Cc: 20694, Juliusz Chroboczek
Justin Timmons <justinmtimmons@gmail.com> writes:
> I wrote up a quick set of functions which accomplishes this and added them
> to the apropos-mode keymap - see the attached patch file.
>
> The functions search forward (or backwards) for the 'apropos-symbol
> face; there could be a cleaner way to do this, but this seems to work
> pretty well.
Hi Justin,
Your patch looks good to me, and also seems to be working. However, I
can only find one previous contribution from you, and together with
that you get more than the 15 lines in total contributed which we can
accept without a copyright assignment.
In order to accept your patch, we therefore need you to sign Copyright
assignments paper. This is a simple and quick procedure technically.
You can find more information on the reasons why we do this here:
https://www.gnu.org/licenses/why-assign.html
Would you be willing to sign such papers? If yes, someone on this
list will help you get the process going. Please let us know.
Best regards,
Stefan Kangas
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#20694: 25.0.50; Please bind `p' and `n' in apropos-mode
2019-09-29 23:40 ` Stefan Kangas
@ 2019-10-02 0:50 ` Justin Timmons
2019-10-02 9:40 ` Stefan Kangas
0 siblings, 1 reply; 12+ messages in thread
From: Justin Timmons @ 2019-10-02 0:50 UTC (permalink / raw)
To: Stefan Kangas; +Cc: 20694, Juliusz Chroboczek
Yes, I’m fine with that - just send over whatever forms I need to fill out!
> On Sep 29, 2019, at 7:40 PM, Stefan Kangas <stefan@marxist.se> wrote:
>
> Justin Timmons <justinmtimmons@gmail.com> writes:
>
>> I wrote up a quick set of functions which accomplishes this and added them
>> to the apropos-mode keymap - see the attached patch file.
>>
>> The functions search forward (or backwards) for the 'apropos-symbol
>> face; there could be a cleaner way to do this, but this seems to work
>> pretty well.
>
> Hi Justin,
>
> Your patch looks good to me, and also seems to be working. However, I
> can only find one previous contribution from you, and together with
> that you get more than the 15 lines in total contributed which we can
> accept without a copyright assignment.
>
> In order to accept your patch, we therefore need you to sign Copyright
> assignments paper. This is a simple and quick procedure technically.
> You can find more information on the reasons why we do this here:
> https://www.gnu.org/licenses/why-assign.html
>
> Would you be willing to sign such papers? If yes, someone on this
> list will help you get the process going. Please let us know.
>
> Best regards,
> Stefan Kangas
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#20694: 25.0.50; Please bind `p' and `n' in apropos-mode
2019-10-02 0:50 ` Justin Timmons
@ 2019-10-02 9:40 ` Stefan Kangas
2019-10-02 15:13 ` Eli Zaretskii
0 siblings, 1 reply; 12+ messages in thread
From: Stefan Kangas @ 2019-10-02 9:40 UTC (permalink / raw)
To: Justin Timmons, Eli Zaretskii; +Cc: 20694, Juliusz Chroboczek
Justin Timmons <justinmtimmons@gmail.com> writes:
> Yes, I’m fine with that - just send over whatever forms I need to fill out!
[...]
> > In order to accept your patch, we therefore need you to sign Copyright
> > assignments paper. This is a simple and quick procedure technically.
> > You can find more information on the reasons why we do this here:
> > https://www.gnu.org/licenses/why-assign.html
> >
> > Would you be willing to sign such papers? If yes, someone on this
> > list will help you get the process going. Please let us know.
Great! Thanks for your contribution.
Eli, could you please help Justin Timmons get started with the
assignment process?
Best regards,
Stefan Kangas
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#20694: 25.0.50; Please bind `p' and `n' in apropos-mode
2019-10-02 9:40 ` Stefan Kangas
@ 2019-10-02 15:13 ` Eli Zaretskii
2020-01-15 4:41 ` Stefan Kangas
0 siblings, 1 reply; 12+ messages in thread
From: Eli Zaretskii @ 2019-10-02 15:13 UTC (permalink / raw)
To: Stefan Kangas; +Cc: justinmtimmons, 20694, jch
> From: Stefan Kangas <stefan@marxist.se>
> Date: Wed, 2 Oct 2019 11:40:11 +0200
> Cc: Juliusz Chroboczek <jch@pps.univ-paris-diderot.fr>, 20694@debbugs.gnu.org
>
> > > Would you be willing to sign such papers? If yes, someone on this
> > > list will help you get the process going. Please let us know.
>
> Great! Thanks for your contribution.
>
> Eli, could you please help Justin Timmons get started with the
> assignment process?
Done.
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#20694: 25.0.50; Please bind `p' and `n' in apropos-mode
2019-10-02 15:13 ` Eli Zaretskii
@ 2020-01-15 4:41 ` Stefan Kangas
2020-01-15 5:33 ` Justin Timmons
0 siblings, 1 reply; 12+ messages in thread
From: Stefan Kangas @ 2020-01-15 4:41 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 20694, justinmtimmons, jch
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Stefan Kangas <stefan@marxist.se>
>> Date: Wed, 2 Oct 2019 11:40:11 +0200
>> Cc: Juliusz Chroboczek <jch@pps.univ-paris-diderot.fr>, 20694@debbugs.gnu.org
>>
>> > > Would you be willing to sign such papers? If yes, someone on this
>> > > list will help you get the process going. Please let us know.
>>
>> Great! Thanks for your contribution.
>>
>> Eli, could you please help Justin Timmons get started with the
>> assignment process?
>
> Done.
That was 14 weeks ago.
What is the current status on this? Do we have the copyright
assignment for Justin Timmons on file?
Best regards,
Stefan Kangas
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#20694: 25.0.50; Please bind `p' and `n' in apropos-mode
2020-01-15 4:41 ` Stefan Kangas
@ 2020-01-15 5:33 ` Justin Timmons
2020-01-15 6:02 ` Stefan Kangas
0 siblings, 1 reply; 12+ messages in thread
From: Justin Timmons @ 2020-01-15 5:33 UTC (permalink / raw)
To: Stefan Kangas; +Cc: 20694, Juliusz Chroboczek
[-- Attachment #1: Type: text/plain, Size: 961 bytes --]
Sorry for dropping the thread on this - was getting married around that
time so life got a bit hectic! I just sent the assignment information over
so it should be ready to go soon.
Justin
On Tue, Jan 14, 2020 at 11:41 PM Stefan Kangas <stefan@marxist.se> wrote:
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> From: Stefan Kangas <stefan@marxist.se>
> >> Date: Wed, 2 Oct 2019 11:40:11 +0200
> >> Cc: Juliusz Chroboczek <jch@pps.univ-paris-diderot.fr>,
> 20694@debbugs.gnu.org
> >>
> >> > > Would you be willing to sign such papers? If yes, someone on this
> >> > > list will help you get the process going. Please let us know.
> >>
> >> Great! Thanks for your contribution.
> >>
> >> Eli, could you please help Justin Timmons get started with the
> >> assignment process?
> >
> > Done.
>
> That was 14 weeks ago.
>
> What is the current status on this? Do we have the copyright
> assignment for Justin Timmons on file?
>
> Best regards,
> Stefan Kangas
>
[-- Attachment #2: Type: text/html, Size: 1686 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#20694: 25.0.50; Please bind `p' and `n' in apropos-mode
2020-01-15 5:33 ` Justin Timmons
@ 2020-01-15 6:02 ` Stefan Kangas
2020-04-16 4:09 ` Stefan Kangas
0 siblings, 1 reply; 12+ messages in thread
From: Stefan Kangas @ 2020-01-15 6:02 UTC (permalink / raw)
To: Justin Timmons; +Cc: 20694, Juliusz Chroboczek
Justin Timmons <justinmtimmons@gmail.com> writes:
> Sorry for dropping the thread on this - was getting married around
> that time so life got a bit hectic!
Congratulations!
> I just sent the assignment information over so it should be ready to
> go soon.
Fantastic. Once the papers are sorted, we will be able to install
your patch.
Best regards,
Stefan Kangas
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#20694: 25.0.50; Please bind `p' and `n' in apropos-mode
2020-01-15 6:02 ` Stefan Kangas
@ 2020-04-16 4:09 ` Stefan Kangas
2020-04-16 5:30 ` Eli Zaretskii
0 siblings, 1 reply; 12+ messages in thread
From: Stefan Kangas @ 2020-04-16 4:09 UTC (permalink / raw)
To: Justin Timmons; +Cc: 20694, Juliusz Chroboczek
Stefan Kangas <stefan@marxist.se> writes:
>> I just sent the assignment information over so it should be ready to
>> go soon.
>
> Fantastic. Once the papers are sorted, we will be able to install
> your patch.
13 weeks have passed, any news here? Thanks in advance.
Best regards,
Stefan Kangas
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#20694: 25.0.50; Please bind `p' and `n' in apropos-mode
2020-04-16 4:09 ` Stefan Kangas
@ 2020-04-16 5:30 ` Eli Zaretskii
2020-04-17 4:31 ` Stefan Kangas
0 siblings, 1 reply; 12+ messages in thread
From: Eli Zaretskii @ 2020-04-16 5:30 UTC (permalink / raw)
To: Stefan Kangas; +Cc: justinmtimmons, 20694, jch
> From: Stefan Kangas <stefan@marxist.se>
> Cc: Eli Zaretskii <eliz@gnu.org>, 20694@debbugs.gnu.org, Juliusz Chroboczek <jch@pps.univ-paris-diderot.fr>
> Date: Thu, 16 Apr 2020 06:09:50 +0200
>
> Stefan Kangas <stefan@marxist.se> writes:
>
> >> I just sent the assignment information over so it should be ready to
> >> go soon.
> >
> > Fantastic. Once the papers are sorted, we will be able to install
> > your patch.
>
> 13 weeks have passed, any news here? Thanks in advance.
The paperwork is done, Justin's assignment is on file.
Thanks.
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#20694: 25.0.50; Please bind `p' and `n' in apropos-mode
2020-04-16 5:30 ` Eli Zaretskii
@ 2020-04-17 4:31 ` Stefan Kangas
0 siblings, 0 replies; 12+ messages in thread
From: Stefan Kangas @ 2020-04-17 4:31 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 20694, justinmtimmons, jch
close 20694 28.1
thanks
Eli Zaretskii <eliz@gnu.org> writes:
> The paperwork is done, Justin's assignment is on file.
Thanks.
I've added a ChangeLog and NEWS entry and pushed the patch to master
as commit 763ec05cc1.
Best regards,
Stefan Kangas
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2020-04-17 4:31 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-30 0:27 bug#20694: 25.0.50; Please bind `p' and `n' in apropos-mode Juliusz Chroboczek
2016-12-13 2:18 ` Justin Timmons
2019-09-29 23:40 ` Stefan Kangas
2019-10-02 0:50 ` Justin Timmons
2019-10-02 9:40 ` Stefan Kangas
2019-10-02 15:13 ` Eli Zaretskii
2020-01-15 4:41 ` Stefan Kangas
2020-01-15 5:33 ` Justin Timmons
2020-01-15 6:02 ` Stefan Kangas
2020-04-16 4:09 ` Stefan Kangas
2020-04-16 5:30 ` Eli Zaretskii
2020-04-17 4:31 ` Stefan Kangas
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).