From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: bshanks3@hotmail.com, 28542@debbugs.gnu.org
Subject: bug#28542: Temporary failure in name resolution while quitting emacs
Date: Sun, 06 Dec 2020 21:17:55 +0200 [thread overview]
Message-ID: <83im9eagm4.fsf@gnu.org> (raw)
In-Reply-To: <874kkzf69l.fsf@gnus.org> (message from Lars Ingebrigtsen on Sun, 06 Dec 2020 13:50:14 +0100)
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: bshanks3@hotmail.com, 28542@debbugs.gnu.org
> Date: Sun, 06 Dec 2020 13:50:14 +0100
>
> Sure, a prompt with a timeout would be fine by me.
>
> Looking at the code again:
>
> /* Fsignal calls emacs_abort () if it sees that waiting_for_input is
> set. */
> waiting_for_input = 0;
> if (noninteractive)
> safe_run_hooks (Qkill_emacs_hook);
> else
> run_hook (Qkill_emacs_hook);
>
> Would it make sense to create a new Lisp-level function to do the
> run-hook/prompting stuff, and call out to that? And move the setting of
> waiting_for_input into the "then" branch?
I think it'd be good to have a run_hook_with_timeout function, yes.
Whether it should be exposed to Lisp, I'm less certain: what would be
the use case that isn't this single place?
As for zeroing waiting_for_input: it's almost certainly shouldn't be
part of that, since it should always be zero when Emacs signals an
error. We do this here because this might be exiting due to a fatal
signal, in which case all bets are off, and we should better be safe
than sorry.
next prev parent reply other threads:[~2020-12-06 19:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 17:13 bug#28542: Temporary failure in name resolution while quitting emacs Baylis Shanks
2020-11-30 10:53 ` Lars Ingebrigtsen
2020-11-30 16:21 ` Eli Zaretskii
2020-12-02 9:47 ` Lars Ingebrigtsen
2020-12-02 15:06 ` Eli Zaretskii
2020-12-03 8:47 ` Lars Ingebrigtsen
2020-12-03 15:16 ` Eli Zaretskii
2020-12-04 9:34 ` Lars Ingebrigtsen
2020-12-04 9:50 ` Robert Pluim
2020-12-04 18:41 ` Glenn Morris
2020-12-06 12:53 ` Lars Ingebrigtsen
2020-12-04 11:42 ` Eli Zaretskii
2020-12-06 12:50 ` Lars Ingebrigtsen
2020-12-06 19:17 ` Eli Zaretskii [this message]
2020-12-07 14:43 ` Lars Ingebrigtsen
2020-12-07 16:01 ` Eli Zaretskii
2020-12-07 16:16 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83im9eagm4.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=28542@debbugs.gnu.org \
--cc=bshanks3@hotmail.com \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).