From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#28542: Temporary failure in name resolution while quitting emacs Date: Sun, 06 Dec 2020 21:17:55 +0200 Message-ID: <83im9eagm4.fsf@gnu.org> References: <87lfejcdzv.fsf@gnus.org> <83o8jeke73.fsf@gnu.org> <875z5k5yks.fsf@gnus.org> <837dq0gsc7.fsf@gnu.org> <87o8jbxoml.fsf@gnus.org> <83h7p2gbs4.fsf@gnu.org> <875z5hoqx2.fsf@gnus.org> <83pn3per1t.fsf@gnu.org> <874kkzf69l.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27906"; mail-complaints-to="usenet@ciao.gmane.io" Cc: bshanks3@hotmail.com, 28542@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 06 20:19:21 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1klzZ2-0007AU-Pm for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Dec 2020 20:19:20 +0100 Original-Received: from localhost ([::1]:52644 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1klzZ1-0001KU-SV for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Dec 2020 14:19:19 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48782) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1klzYk-0001KJ-N6 for bug-gnu-emacs@gnu.org; Sun, 06 Dec 2020 14:19:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39782) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1klzYk-0000xa-Fz for bug-gnu-emacs@gnu.org; Sun, 06 Dec 2020 14:19:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1klzYk-00008n-CR for bug-gnu-emacs@gnu.org; Sun, 06 Dec 2020 14:19:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 Dec 2020 19:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28542 X-GNU-PR-Package: emacs Original-Received: via spool by 28542-submit@debbugs.gnu.org id=B28542.1607282300480 (code B ref 28542); Sun, 06 Dec 2020 19:19:02 +0000 Original-Received: (at 28542) by debbugs.gnu.org; 6 Dec 2020 19:18:20 +0000 Original-Received: from localhost ([127.0.0.1]:51328 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klzY4-00007g-1n for submit@debbugs.gnu.org; Sun, 06 Dec 2020 14:18:20 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58730) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klzY2-00007U-MP for 28542@debbugs.gnu.org; Sun, 06 Dec 2020 14:18:18 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:41322) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1klzXt-0000kX-L6; Sun, 06 Dec 2020 14:18:10 -0500 Original-Received: from [176.228.60.248] (port=2189 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1klzXs-0001rq-4Y; Sun, 06 Dec 2020 14:18:09 -0500 In-Reply-To: <874kkzf69l.fsf@gnus.org> (message from Lars Ingebrigtsen on Sun, 06 Dec 2020 13:50:14 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:195157 Archived-At: > From: Lars Ingebrigtsen > Cc: bshanks3@hotmail.com, 28542@debbugs.gnu.org > Date: Sun, 06 Dec 2020 13:50:14 +0100 > > Sure, a prompt with a timeout would be fine by me. > > Looking at the code again: > > /* Fsignal calls emacs_abort () if it sees that waiting_for_input is > set. */ > waiting_for_input = 0; > if (noninteractive) > safe_run_hooks (Qkill_emacs_hook); > else > run_hook (Qkill_emacs_hook); > > Would it make sense to create a new Lisp-level function to do the > run-hook/prompting stuff, and call out to that? And move the setting of > waiting_for_input into the "then" branch? I think it'd be good to have a run_hook_with_timeout function, yes. Whether it should be exposed to Lisp, I'm less certain: what would be the use case that isn't this single place? As for zeroing waiting_for_input: it's almost certainly shouldn't be part of that, since it should always be zero when Emacs signals an error. We do this here because this might be exiting due to a fatal signal, in which case all bets are off, and we should better be safe than sorry.