unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: dick <dick.r.chiang@gmail.com>
Cc: 52302@debbugs.gnu.org
Subject: bug#52302: 28.0.50; [PATCH] Overlay strings should not increment vpos
Date: Sun, 05 Dec 2021 21:47:59 +0200	[thread overview]
Message-ID: <83ilw23kb4.fsf@gnu.org> (raw)
In-Reply-To: <87mtlej2hl.fsf@dick> (message from dick on Sun, 05 Dec 2021 14:06:14 -0500)

> From: dick <dick.r.chiang@gmail.com>
> Cc: 52302@debbugs.gnu.org
> Date: Sun, 05 Dec 2021 14:06:14 -0500
> 
> Just want to get `move_it_to` right on a (MOVE_TO_VPOS | MOVE_TO_POS) to
> a line ending in an invisible string.

Are you using "invisible" here as in "text with the invisible
property"?  Or does "invisible" mean "not shown on display"?  If the
latter, then I don't understand what does visibility have to do with
coordinates maintained by move_it_to -- that function doesn't care
whether the text it traverses is or isn't shown.

> This is nicely tested in
> `xdisp-tests--minibuffer-resizing` in reference to bug#43519, but the
> erstwhile fix was a paper-over (calling move_it_vertically_backward with
> arg 0 as many times as it took to get back to line start, then adding a
> long-winded justification -- no dearth of those).

I see just one call to move_it_vertically_backward, not "as many as".
And the long comment explains why we call move_it_to (also a single
call), not move_it_vertically_backward.  So I don't understand what
you are saying here.

And the overall motivation is also not clear -- is it just to save us
one call to move_it_vertically_backward?





  reply	other threads:[~2021-12-05 19:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-05 17:37 bug#52302: 28.0.50; [PATCH] Overlay strings should not increment vpos dick.r.chiang
2021-12-05 18:34 ` Eli Zaretskii
2021-12-05 18:52   ` dick
2021-12-05 19:06   ` dick
2021-12-05 19:47     ` Eli Zaretskii [this message]
2021-12-05 22:10       ` dick
2021-12-06 19:47 ` dick
2021-12-06 20:02   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83ilw23kb4.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=52302@debbugs.gnu.org \
    --cc=dick.r.chiang@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).