From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#52302: 28.0.50; [PATCH] Overlay strings should not increment vpos Date: Sun, 05 Dec 2021 21:47:59 +0200 Message-ID: <83ilw23kb4.fsf@gnu.org> References: <87v903hs0w.fsf@dick> <83lf0y3np1.fsf@gnu.org> <87mtlej2hl.fsf@dick> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26859"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 52302@debbugs.gnu.org To: dick Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 05 20:49:24 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mtxVk-0006go-3q for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Dec 2021 20:49:24 +0100 Original-Received: from localhost ([::1]:51394 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mtxVi-0000j5-Kd for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Dec 2021 14:49:22 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54788) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mtxVO-0000iR-Dl for bug-gnu-emacs@gnu.org; Sun, 05 Dec 2021 14:49:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47982) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mtxVO-0000kX-06 for bug-gnu-emacs@gnu.org; Sun, 05 Dec 2021 14:49:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mtxVN-0003Ci-Ub for bug-gnu-emacs@gnu.org; Sun, 05 Dec 2021 14:49:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Dec 2021 19:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52302 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 52302-submit@debbugs.gnu.org id=B52302.163873369812214 (code B ref 52302); Sun, 05 Dec 2021 19:49:01 +0000 Original-Received: (at 52302) by debbugs.gnu.org; 5 Dec 2021 19:48:18 +0000 Original-Received: from localhost ([127.0.0.1]:59518 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtxUg-0003Aw-D6 for submit@debbugs.gnu.org; Sun, 05 Dec 2021 14:48:18 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:53980) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtxUe-0003Af-Rd for 52302@debbugs.gnu.org; Sun, 05 Dec 2021 14:48:17 -0500 Original-Received: from [2001:470:142:3::e] (port=47882 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mtxUZ-0000gQ-Il; Sun, 05 Dec 2021 14:48:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=P/e2ryQ9GLNaCgLWSGhzitVRf27OrU9bvwgZZAoearw=; b=mOsGMRwU1XsT wAGNDVbZAMJOWaegD0PMegMovK8f+ayF57DvcRZZfxg3LgqLc7uFKzkn2G8x8ZRbPkt3rtR9m6UWL swUglDReJ8C6TiXLmGZ9wANSP3/7kSP3ay3T1nddqENVht8gHTvm8dxihIPEfZeppS4IkVEpU7bTr mvqN1mDXQlIs0QJaMVAZhXTcegw69LfHBQrZ583lKQ8ycqGD16Rh1sOYkSgRPNdp9FhBY7zc4FH1k f4FdmYr80JJVw7aQ4JAHrW9E/PrfoXnVv2PEmKp73qcDiUxa4JIdoZAmCiSfytCi4KSNYfVIcCwfL d697Qps+YKk/75eU6Zvcmg==; Original-Received: from [87.69.77.57] (port=2232 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mtxUS-0005Xl-C5; Sun, 05 Dec 2021 14:48:11 -0500 In-Reply-To: <87mtlej2hl.fsf@dick> (message from dick on Sun, 05 Dec 2021 14:06:14 -0500) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:221642 Archived-At: > From: dick > Cc: 52302@debbugs.gnu.org > Date: Sun, 05 Dec 2021 14:06:14 -0500 > > Just want to get `move_it_to` right on a (MOVE_TO_VPOS | MOVE_TO_POS) to > a line ending in an invisible string. Are you using "invisible" here as in "text with the invisible property"? Or does "invisible" mean "not shown on display"? If the latter, then I don't understand what does visibility have to do with coordinates maintained by move_it_to -- that function doesn't care whether the text it traverses is or isn't shown. > This is nicely tested in > `xdisp-tests--minibuffer-resizing` in reference to bug#43519, but the > erstwhile fix was a paper-over (calling move_it_vertically_backward with > arg 0 as many times as it took to get back to line start, then adding a > long-winded justification -- no dearth of those). I see just one call to move_it_vertically_backward, not "as many as". And the long comment explains why we call move_it_to (also a single call), not move_it_vertically_backward. So I don't understand what you are saying here. And the overall motivation is also not clear -- is it just to save us one call to move_it_vertically_backward?