From: Eli Zaretskii <eliz@gnu.org>
To: Gemini Lasswell <gazally@runbox.com>, Alan Mackenzie <acm@muc.de>
Cc: 25077@debbugs.gnu.org
Subject: bug#25077: 25.1; Incorrect Edebug spec for c-lang-defvar
Date: Sat, 04 Feb 2017 13:27:45 +0200 [thread overview]
Message-ID: <83h94a8aby.fsf@gnu.org> (raw)
In-Reply-To: <m2h96orczn.fsf@rainbow.local> (message from Gemini Lasswell on Wed, 30 Nov 2016 11:20:28 -0800)
> From: Gemini Lasswell <gazally@runbox.com>
> Date: Wed, 30 Nov 2016 11:20:28 -0800
>
> The Edebug spec for c-lang-defvar doesn't allow for the use of
> 'dont-doc, which prevents the use of Edebug and Testcover on
> cc-langs.el.
>
> To reproduce, using emacs -Q starting at the root of the Emacs
> sources:
>
> M-: (require 'cc-langs) RET
> C-x C-f lisp/progmodes/cc-langs.el RET
> C-s dont-doc RET
> C-u C-M-x
>
> Result: edebug-syntax-error: Invalid read syntax: stringp, "failed"
>
> I tried this change to the Edebug spec for c-lang-defvar, and it makes
> Edebug work on all the c-lang-defvar uses in this file:
>
> (def-edebug-spec c-lang-defvar
> (&define name def-form &optional &or ("quote" "dont-doc") stringp))
>
> Alternatively, the 'dont-doc could be removed from the 7 places it is
> used. The majority of c-lang-defvar calls simply omit the docstring,
> and the code in c-lang-defvar is not doing any checking for dont-doc,
> it simply ignores that parameter if it is not a string.
Alan, could you please look into this?
Thanks.
next prev parent reply other threads:[~2017-02-04 11:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-30 19:20 bug#25077: 25.1; Incorrect Edebug spec for c-lang-defvar Gemini Lasswell
2017-02-04 11:27 ` Eli Zaretskii [this message]
2017-02-04 16:23 ` Alan Mackenzie
2017-02-18 16:10 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83h94a8aby.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=25077@debbugs.gnu.org \
--cc=acm@muc.de \
--cc=gazally@runbox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).