From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#25077: 25.1; Incorrect Edebug spec for c-lang-defvar Date: Sat, 04 Feb 2017 13:27:45 +0200 Message-ID: <83h94a8aby.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1486207752 5515 195.159.176.226 (4 Feb 2017 11:29:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 4 Feb 2017 11:29:12 +0000 (UTC) Cc: 25077@debbugs.gnu.org To: Gemini Lasswell , Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Feb 04 12:29:08 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZyWh-0001FA-1h for geb-bug-gnu-emacs@m.gmane.org; Sat, 04 Feb 2017 12:29:07 +0100 Original-Received: from localhost ([::1]:38821 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZyWm-0000fF-HG for geb-bug-gnu-emacs@m.gmane.org; Sat, 04 Feb 2017 06:29:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48251) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZyWg-0000f9-A2 for bug-gnu-emacs@gnu.org; Sat, 04 Feb 2017 06:29:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cZyWc-0004Kj-A5 for bug-gnu-emacs@gnu.org; Sat, 04 Feb 2017 06:29:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57348) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cZyWc-0004Kf-6u; Sat, 04 Feb 2017 06:29:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cZyWc-0008Vd-2E; Sat, 04 Feb 2017 06:29:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bug-cc-mode@gnu.org Resent-Date: Sat, 04 Feb 2017 11:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25077 X-GNU-PR-Package: emacs,cc-mode X-GNU-PR-Keywords: Original-Received: via spool by 25077-submit@debbugs.gnu.org id=B25077.148620768432646 (code B ref 25077); Sat, 04 Feb 2017 11:29:02 +0000 Original-Received: (at 25077) by debbugs.gnu.org; 4 Feb 2017 11:28:04 +0000 Original-Received: from localhost ([127.0.0.1]:55547 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZyVg-0008UU-Gk for submit@debbugs.gnu.org; Sat, 04 Feb 2017 06:28:04 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:57098) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZyVf-0008Tz-KZ for 25077@debbugs.gnu.org; Sat, 04 Feb 2017 06:28:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cZyVW-0003pE-KO for 25077@debbugs.gnu.org; Sat, 04 Feb 2017 06:27:58 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47867) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZyVW-0003p5-HK; Sat, 04 Feb 2017 06:27:54 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1394 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cZyVV-0004uG-OP; Sat, 04 Feb 2017 06:27:54 -0500 In-reply-to: (message from Gemini Lasswell on Wed, 30 Nov 2016 11:20:28 -0800) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:128945 Archived-At: > From: Gemini Lasswell > Date: Wed, 30 Nov 2016 11:20:28 -0800 > > The Edebug spec for c-lang-defvar doesn't allow for the use of > 'dont-doc, which prevents the use of Edebug and Testcover on > cc-langs.el. > > To reproduce, using emacs -Q starting at the root of the Emacs > sources: > > M-: (require 'cc-langs) RET > C-x C-f lisp/progmodes/cc-langs.el RET > C-s dont-doc RET > C-u C-M-x > > Result: edebug-syntax-error: Invalid read syntax: stringp, "failed" > > I tried this change to the Edebug spec for c-lang-defvar, and it makes > Edebug work on all the c-lang-defvar uses in this file: > > (def-edebug-spec c-lang-defvar > (&define name def-form &optional &or ("quote" "dont-doc") stringp)) > > Alternatively, the 'dont-doc could be removed from the 7 places it is > used. The majority of c-lang-defvar calls simply omit the docstring, > and the code in c-lang-defvar is not doing any checking for dont-doc, > it simply ignores that parameter if it is not a string. Alan, could you please look into this? Thanks.