* bug#40805: 27.0.91; fringe bitmap values for ? and ! do not match comment in fringe.c
@ 2020-04-24 0:46 Trevor Spiteri
2020-04-25 9:13 ` Eli Zaretskii
0 siblings, 1 reply; 2+ messages in thread
From: Trevor Spiteri @ 2020-04-24 0:46 UTC (permalink / raw)
To: 40805
In src/fringe.c, the question-mark bitmap shown in the comments would
result in the code:
static unsigned short question_mark_bits[] = {
0x3c, 0x7e, 0xc3, 0xc3, 0x0c, 0x18, 0x18, 0x00, 0x18, 0x18};
and the exclamation-mark bitmap in the code:
static unsigned short exclamation_mark_bits[] = {
0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x00, 0x18, 0x18};
I'm guessing they are different by mistake, but they aren't really used
so the error went undetected.
In GNU Emacs 27.0.91 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.13, cairo version 1.16.0)
of 2020-04-23 built on desktop
Repository revision: ba6104d1e8db4e8db2f12acaebf092ef579c6632
Repository branch: emacs-27
^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#40805: 27.0.91; fringe bitmap values for ? and ! do not match comment in fringe.c
2020-04-24 0:46 bug#40805: 27.0.91; fringe bitmap values for ? and ! do not match comment in fringe.c Trevor Spiteri
@ 2020-04-25 9:13 ` Eli Zaretskii
0 siblings, 0 replies; 2+ messages in thread
From: Eli Zaretskii @ 2020-04-25 9:13 UTC (permalink / raw)
To: Trevor Spiteri; +Cc: 40805
> From: Trevor Spiteri <tspiteri@ieee.org>
> Date: Fri, 24 Apr 2020 02:46:44 +0200
>
> In src/fringe.c, the question-mark bitmap shown in the comments would
> result in the code:
>
> static unsigned short question_mark_bits[] = {
> 0x3c, 0x7e, 0xc3, 0xc3, 0x0c, 0x18, 0x18, 0x00, 0x18, 0x18};
>
> and the exclamation-mark bitmap in the code:
>
> static unsigned short exclamation_mark_bits[] = {
> 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x00, 0x18, 0x18};
Thanks, I fixed this on the master branch.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-25 9:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-24 0:46 bug#40805: 27.0.91; fringe bitmap values for ? and ! do not match comment in fringe.c Trevor Spiteri
2020-04-25 9:13 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).