unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Paul Pogonyshev <pogonyshev@gmail.com>
Cc: gerd.moellmann@gmail.com, 57433-done@debbugs.gnu.org
Subject: bug#57433: Emacs no longer moves point into visible port of the buffer
Date: Sat, 27 Aug 2022 18:55:40 +0300	[thread overview]
Message-ID: <83h71xznnn.fsf@gnu.org> (raw)
In-Reply-To: <CAG7Bpapw=WU=Eq=YO2haLfvOqA_6RaOdC19jxE=pK3X0nwnqeQ@mail.gmail.com> (message from Paul Pogonyshev on Sat, 27 Aug 2022 17:47:32 +0200)

> From: Paul Pogonyshev <pogonyshev@gmail.com>
> Date: Sat, 27 Aug 2022 17:47:32 +0200
> Cc: Eli Zaretskii <eliz@gnu.org>, 57433@debbugs.gnu.org
> 
> > Strange.  Could you please double-check that you have commit
> > a2d62456a7b8da27fb9b64f71b6ce588f2d73287 in your worktree?
> 
> I have rebuilt Emacs and now it works. I previously tried with applying
> the patch from "In that case, can you see if the patch below solves the
> original issue with Magit?" locally, but apparently did something wrong.
> 
> So yes, it works for me now, sorry.

No need to be sorry, thanks for testing the fix.  I'm therefore
closing the bug.

> > I think you are reading too much into what that text says.  It says
> > that point moves to the edge of such a sequence, and that is what
> > happens here.  No more, no less.
> 
> Yeah, I see now that if you move with C-b, the point disappears within
> the diff for the previous file, even with Emacs 28, and then Magit
> misbehaves. To be honest, I'm not sure if that is useful (or maybe there
> is some reason for moving "to the edge" rather than outside an
> invisible sequence), but that's certainly not a regression in Emacs.

The "reason" is largely a side-effect of the implementation, I
suspect.





  reply	other threads:[~2022-08-27 15:55 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-26 16:32 bug#57433: Emacs no longer moves point into visible port of the buffer Paul Pogonyshev
2022-08-27  6:55 ` Gerd Möllmann
2022-08-27  8:08   ` Gerd Möllmann
2022-08-27  8:53     ` Gerd Möllmann
2022-08-27  9:33       ` Eli Zaretskii
2022-08-27  9:55         ` Gerd Möllmann
2022-08-27  9:58         ` Eli Zaretskii
2022-08-27 10:02           ` Gerd Möllmann
2022-08-27 10:19             ` Eli Zaretskii
2022-08-27 10:43               ` Gerd Möllmann
2022-08-27 11:08                 ` Eli Zaretskii
2022-08-27 14:07                   ` Paul Pogonyshev
2022-08-27 14:28                     ` Gerd Möllmann
2022-08-27 15:47                       ` Paul Pogonyshev
2022-08-27 15:55                         ` Eli Zaretskii [this message]
2022-08-27 16:06                           ` Paul Pogonyshev
2022-08-27 16:12                             ` Paul Pogonyshev
2022-08-27 16:29                               ` Eli Zaretskii
2022-08-27 16:32                                 ` Paul Pogonyshev
2022-08-27 16:37                                   ` Paul Pogonyshev
2022-08-27 16:56                                   ` Eli Zaretskii
2022-08-27 17:01                                     ` Paul Pogonyshev
2022-08-27 17:11                                       ` Paul Pogonyshev
2022-08-27 16:25                             ` Eli Zaretskii
2022-08-27 15:13                     ` Eli Zaretskii
2022-08-27  9:47 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83h71xznnn.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=57433-done@debbugs.gnu.org \
    --cc=gerd.moellmann@gmail.com \
    --cc=pogonyshev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).