From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#57433: Emacs no longer moves point into visible port of the buffer Date: Sat, 27 Aug 2022 18:55:40 +0300 Message-ID: <83h71xznnn.fsf@gnu.org> References: <83y1vayqrm.fsf@gnu.org> <83v8qeypm5.fsf@gnu.org> <83sfliyonr.fsf@gnu.org> <83pmgmymdw.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32773"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gerd.moellmann@gmail.com, 57433-done@debbugs.gnu.org To: Paul Pogonyshev Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 27 17:56:12 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oRyAN-0008Hp-BM for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 27 Aug 2022 17:56:11 +0200 Original-Received: from localhost ([::1]:51492 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oRyAM-0001ff-8w for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 27 Aug 2022 11:56:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52476) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRyAE-0001de-F3 for bug-gnu-emacs@gnu.org; Sat, 27 Aug 2022 11:56:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38886) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oRyAE-00011e-6F for bug-gnu-emacs@gnu.org; Sat, 27 Aug 2022 11:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oRyAE-0003i4-2P for bug-gnu-emacs@gnu.org; Sat, 27 Aug 2022 11:56:02 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Aug 2022 15:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 57433 X-GNU-PR-Package: emacs Mail-Followup-To: 57433@debbugs.gnu.org, eliz@gnu.org, pogonyshev@gmail.com Original-Received: via spool by 57433-done@debbugs.gnu.org id=D57433.166161574414234 (code D ref 57433); Sat, 27 Aug 2022 15:56:01 +0000 Original-Received: (at 57433-done) by debbugs.gnu.org; 27 Aug 2022 15:55:44 +0000 Original-Received: from localhost ([127.0.0.1]:56867 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRy9w-0003hW-7y for submit@debbugs.gnu.org; Sat, 27 Aug 2022 11:55:44 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53146) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRy9u-0003hI-2K for 57433-done@debbugs.gnu.org; Sat, 27 Aug 2022 11:55:42 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:56188) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRy9o-0000ze-Q8; Sat, 27 Aug 2022 11:55:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Zx6+F17GZ12BR5l6gh5pVGS544o/l0gcwT47FkyV6tA=; b=Kdju4PN1XhBu TMZU7Or4jGda14JTmWpsRc4AknR39n3hSxcKzf+n+Gu88tENmPI/S68yjzbO9wCpS276vjsuvBZBm 5eqqjNInVZ6JMgKbaVEyCBi2Bu85xY+PDjar3XAOXFM2BuVZixHgcixZXgKLdXau3dnZbVFUU5wsp Pz5tiWPY7teZ4VCi8WXcswH2tvnkpTAzh2XSYcKg8hjd+0r8ANshv6UmosQ4X6d6Qy31KXp9eDnda /RnG1Jc1hAdaw/9QGw1ujF4tXJ3p1ntMpkf7bcp/lMVnGCnemCkmRVdzTSzsZvimasF+GFBqFDPZl mVWgIAqfzvmDBWdMnGiXzg==; Original-Received: from [87.69.77.57] (port=4270 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRy9c-0008Co-JV; Sat, 27 Aug 2022 11:55:34 -0400 In-Reply-To: (message from Paul Pogonyshev on Sat, 27 Aug 2022 17:47:32 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:240947 Archived-At: > From: Paul Pogonyshev > Date: Sat, 27 Aug 2022 17:47:32 +0200 > Cc: Eli Zaretskii , 57433@debbugs.gnu.org > > > Strange. Could you please double-check that you have commit > > a2d62456a7b8da27fb9b64f71b6ce588f2d73287 in your worktree? > > I have rebuilt Emacs and now it works. I previously tried with applying > the patch from "In that case, can you see if the patch below solves the > original issue with Magit?" locally, but apparently did something wrong. > > So yes, it works for me now, sorry. No need to be sorry, thanks for testing the fix. I'm therefore closing the bug. > > I think you are reading too much into what that text says. It says > > that point moves to the edge of such a sequence, and that is what > > happens here. No more, no less. > > Yeah, I see now that if you move with C-b, the point disappears within > the diff for the previous file, even with Emacs 28, and then Magit > misbehaves. To be honest, I'm not sure if that is useful (or maybe there > is some reason for moving "to the edge" rather than outside an > invisible sequence), but that's certainly not a regression in Emacs. The "reason" is largely a side-effect of the implementation, I suspect.