unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: lux <lx@shellcodes.org>
Cc: 59544@debbugs.gnu.org, stefankangas@gmail.com
Subject: bug#59544: [PATCH] Fixed lib-src/etags.c command execute vulnerability
Date: Sat, 26 Nov 2022 16:49:56 +0200	[thread overview]
Message-ID: <83h6ylsrcb.fsf@gnu.org> (raw)
In-Reply-To: <tencent_0B66566A766A94EE00E45DC327831B387709@qq.com> (message from lux on Sat, 26 Nov 2022 22:26:22 +0800)

> Date: Sat, 26 Nov 2022 22:26:22 +0800
> Cc: stefankangas@gmail.com, 59544@debbugs.gnu.org
> From: lux <lx@shellcodes.org>
> 
> Yes, but I think it violates the original author's intention, and it 
> seems that there is no occasion to use this parameter in etags?
> 
> /*
>   * Read a line of text from `stream' into `lbp', excluding the
>   * newline or CR-NL, if any.  Return the number of characters read from
>   * `stream', which is the length of the line including the newline.
>   *
>   * On DOS or Windows we do not count the CR character, if any before the
>   * NL, in the returned length; this mirrors the behavior of Emacs on those
>   * platforms (for text files, it translates CR-NL to NL as it reads in the
>   * file).

The above is about the character counts written in TAGS tables, which are
produced by etags, not by ctags.  Files produced by crags only count lines,
not characters.  So the above comment is not relevant to ctags.

More importantly, the original tags file could have been written by a
utility other than our ctags, and I don't think we should change the EOL
format of such a file when we update it.





  parent reply	other threads:[~2022-11-26 14:49 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-24 15:27 bug#59544: [PATCH] Fixed lib-src/etags.c command execute vulnerability lux
2022-11-24 18:01 ` Eli Zaretskii
2022-11-24 18:12   ` Stefan Kangas
2022-11-24 18:38     ` Eli Zaretskii
2022-11-25  3:45       ` lux
2022-11-25  6:41       ` lux
2022-11-25  7:53         ` Stefan Kangas
2022-11-25  8:38           ` lux
2022-11-25  8:56             ` Stefan Kangas
2022-11-25 12:19               ` Eli Zaretskii
2022-11-25 12:18         ` Eli Zaretskii
2022-11-25 16:02           ` lux
2022-11-26  0:43             ` Stefan Kangas
2022-11-26  2:30               ` lux
2022-11-26  3:09               ` lux
2022-11-26  9:47                 ` Stefan Kangas
2022-11-26 10:14                   ` Eli Zaretskii
     [not found]                     ` <tencent_A9399566146BF66A0CEFAEE4B3C285839109@qq.com>
2022-11-26 12:28                       ` Eli Zaretskii
2022-11-26 13:03                         ` Stefan Kangas
2022-11-26 14:15                           ` Eli Zaretskii
     [not found]                         ` <tencent_F5BD82AD38AB67E06AB86AE8EE5EE577C309@qq.com>
2022-11-26 14:30                           ` Eli Zaretskii
2022-11-26 13:21                 ` Eli Zaretskii
     [not found]                   ` <tencent_63F9E4F0AB6043CE8C198E1AAA9AD9BB1A07@qq.com>
2022-11-26 14:17                     ` Eli Zaretskii
     [not found]                       ` <tencent_0B66566A766A94EE00E45DC327831B387709@qq.com>
2022-11-26 14:49                         ` Eli Zaretskii [this message]
     [not found]                           ` <tencent_B9EE8C5FCD5A8DCF9D8AFC56787AF00AE706@qq.com>
2022-11-26 17:11                             ` Eli Zaretskii
2022-11-27  3:05                               ` lux
2022-11-27  6:35                               ` lux
2022-11-27 14:15                                 ` Eli Zaretskii
2022-11-27 14:31                                   ` Eli Zaretskii
     [not found]                                   ` <tencent_67B00527E64C548D4ECDF55D977C75B84B06@qq.com>
2022-11-27 18:07                                     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83h6ylsrcb.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=59544@debbugs.gnu.org \
    --cc=lx@shellcodes.org \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).