From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: 59544@debbugs.gnu.org, lx@shellcodes.org
Subject: bug#59544: [PATCH] Fixed lib-src/etags.c command execute vulnerability
Date: Sat, 26 Nov 2022 12:14:56 +0200 [thread overview]
Message-ID: <83cz9at42n.fsf@gnu.org> (raw)
In-Reply-To: <CADwFkmkO1BgBdKke5ieKqie97SfmB5FShGmm_Q5tNjePzmmVfA@mail.gmail.com> (message from Stefan Kangas on Sat, 26 Nov 2022 01:47:25 -0800)
> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Sat, 26 Nov 2022 01:47:25 -0800
> Cc: Eli Zaretskii <eliz@gnu.org>, 59544@debbugs.gnu.org
>
> lux <lx@shellcodes.org> writes:
>
> > 在 2022/11/26 08:43, Stefan Kangas 写道:
> >
> > Other than that, LGTM.
> >
> >> + char *buf = xmalloc (buf_len);
> >
> > The buf variable is not released after use, I added free (buf)
>
> Thanks. I think we should aim to push this security fix ASAP.
>
> Eli, any additional comments on the patch?
Please don't push, the patch was posted just a few hours ago. I have a lot
to do on my hands, and will get to reviewing this in due time. We've lived
with this "security issue" for decades, so I see nothing here that justifies
"ASAP".
I find the tendency to rush with installing changes bad for the quality of
our code. I always wait at least for a week before installing myself, and
suggest that you do the same. Doing so lets others chime in and provide
valuable input and comments.
Thanks in advance.
next prev parent reply other threads:[~2022-11-26 10:14 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-24 15:27 bug#59544: [PATCH] Fixed lib-src/etags.c command execute vulnerability lux
2022-11-24 18:01 ` Eli Zaretskii
2022-11-24 18:12 ` Stefan Kangas
2022-11-24 18:38 ` Eli Zaretskii
2022-11-25 3:45 ` lux
2022-11-25 6:41 ` lux
2022-11-25 7:53 ` Stefan Kangas
2022-11-25 8:38 ` lux
2022-11-25 8:56 ` Stefan Kangas
2022-11-25 12:19 ` Eli Zaretskii
2022-11-25 12:18 ` Eli Zaretskii
2022-11-25 16:02 ` lux
2022-11-26 0:43 ` Stefan Kangas
2022-11-26 2:30 ` lux
2022-11-26 3:09 ` lux
2022-11-26 9:47 ` Stefan Kangas
2022-11-26 10:14 ` Eli Zaretskii [this message]
[not found] ` <tencent_A9399566146BF66A0CEFAEE4B3C285839109@qq.com>
2022-11-26 12:28 ` Eli Zaretskii
2022-11-26 13:03 ` Stefan Kangas
2022-11-26 14:15 ` Eli Zaretskii
[not found] ` <tencent_F5BD82AD38AB67E06AB86AE8EE5EE577C309@qq.com>
2022-11-26 14:30 ` Eli Zaretskii
2022-11-26 13:21 ` Eli Zaretskii
[not found] ` <tencent_63F9E4F0AB6043CE8C198E1AAA9AD9BB1A07@qq.com>
2022-11-26 14:17 ` Eli Zaretskii
[not found] ` <tencent_0B66566A766A94EE00E45DC327831B387709@qq.com>
2022-11-26 14:49 ` Eli Zaretskii
[not found] ` <tencent_B9EE8C5FCD5A8DCF9D8AFC56787AF00AE706@qq.com>
2022-11-26 17:11 ` Eli Zaretskii
2022-11-27 3:05 ` lux
2022-11-27 6:35 ` lux
2022-11-27 14:15 ` Eli Zaretskii
2022-11-27 14:31 ` Eli Zaretskii
[not found] ` <tencent_67B00527E64C548D4ECDF55D977C75B84B06@qq.com>
2022-11-27 18:07 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83cz9at42n.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=59544@debbugs.gnu.org \
--cc=lx@shellcodes.org \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).