From: Eli Zaretskii <eliz@gnu.org>
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: cohen@andy.bu.edu, 62812@debbugs.gnu.org, jimjoe@gmx.net
Subject: bug#62812: [PATCH] Re: bug#62812: 29.0.60; Persistent article cache not working properly
Date: Thu, 24 Aug 2023 08:50:06 +0300 [thread overview]
Message-ID: <83h6opq99t.fsf@gnu.org> (raw)
In-Reply-To: <87lee1hfje.fsf@ericabrahamsen.net> (message from Eric Abrahamsen on Wed, 23 Aug 2023 09:47:17 -0700)
> From: Eric Abrahamsen <eric@ericabrahamsen.net>
> Cc: James Thomas <jimjoe@gmx.net>, Andrew G Cohen <cohen@andy.bu.edu>,
> 62812@debbugs.gnu.org
> Date: Wed, 23 Aug 2023 09:47:17 -0700
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> From: James Thomas <jimjoe@gmx.net>
> >> Date: Wed, 23 Aug 2023 19:07:51 +0530
> >>
> >> James Thomas wrote:
> >>
> >> > Turned out to be a trivial fix:
> >> >
> >> > diff --git a/lisp/gnus/nnmail.el b/lisp/gnus/nnmail.el
> >> > index e8f157392d4..904b564409a 100644
> >> > --- a/lisp/gnus/nnmail.el
> >> > +++ b/lisp/gnus/nnmail.el
> >> > @@ -667,7 +667,9 @@ nnmail-parse-active
> >> > (cond ((symbolp group)
> >> > (symbol-name group))
> >> > ((numberp group)
> >> > - (number-to-string group))))
> >> > + (number-to-string group))
> >> > + ((stringp group)
> >> > + group)))
> >> > (if (and (numberp (setq max (read buffer)))
> >> > (numberp (setq min (read buffer))))
> >> > (push (list group (cons min max))
> >>
> >> And it'll merely make it the same as this already-existing code
> >> elsewhere:
> >>
> >> diff -u --label ./lisp/gnus/gnus-start.el --label \#\<buffer\ gnus-start.el\> ./lisp/gnus/gnus-start.el /tmp/buffer-content-IYvzRp
> >> --- ./lisp/gnus/gnus-start.el
> >> +++ #<buffer gnus-start.el>
> >> @@ -2149,8 +2149,6 @@
> >> (number-to-string group))
> >> ((symbolp group)
> >> (symbol-name group))
> >> - ((stringp group)
> >> - group)))))
> >> (numberp (setq max (read cur)))
> >> (numberp (setq min (read cur)))
> >> (null (progn
> >>
> >> --
> >
> > Eric, Andrew: any comments?
>
> Yes! This looks like a correct fix to me.
OK, but now I'm confused regarding which change(s) to install. This
discussion includes 3 changes, so which ones are proposed and
approved? James, would you please post a single consolidated patch
you think should be installed, with the appropriate commit log
message?
Thanks.
next prev parent reply other threads:[~2023-08-24 5:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 10:06 bug#62812: 29.0.60; Persistent article cache not working properly James Thomas
[not found] ` <handler.62812.B.16813804012844.ack@debbugs.gnu.org>
2023-04-20 10:30 ` bug#62812: [PATCH] " James Thomas
2023-04-20 10:58 ` James Thomas
2023-08-09 7:13 ` bug#62812: [BUMP, PATCH] " James Thomas
2023-08-23 13:37 ` bug#62812: [PATCH] " James Thomas
2023-08-23 13:56 ` Eli Zaretskii
2023-08-23 16:47 ` Eric Abrahamsen
2023-08-24 5:50 ` Eli Zaretskii [this message]
2023-08-24 7:29 ` James Thomas
2023-08-24 7:43 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83h6opq99t.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=62812@debbugs.gnu.org \
--cc=cohen@andy.bu.edu \
--cc=eric@ericabrahamsen.net \
--cc=jimjoe@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).