From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62812: [PATCH] Re: bug#62812: 29.0.60; Persistent article cache not working properly Date: Thu, 24 Aug 2023 08:50:06 +0300 Message-ID: <83h6opq99t.fsf@gnu.org> References: <87cz4814gs.fsf@gmx.net> <87y1mmdex6.fsf_-_@gmx.net> <87v8d57uc0.fsf@gmx.net> <833509svzg.fsf@gnu.org> <87lee1hfje.fsf@ericabrahamsen.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31671"; mail-complaints-to="usenet@ciao.gmane.io" Cc: cohen@andy.bu.edu, 62812@debbugs.gnu.org, jimjoe@gmx.net To: Eric Abrahamsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 24 07:50:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qZ3Ec-00082c-Cm for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 24 Aug 2023 07:50:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qZ3EM-00024U-8V; Thu, 24 Aug 2023 01:50:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZ3EF-000245-Fp for bug-gnu-emacs@gnu.org; Thu, 24 Aug 2023 01:49:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qZ3EE-0007fY-QB for bug-gnu-emacs@gnu.org; Thu, 24 Aug 2023 01:49:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qZ3EI-0007PI-HB; Thu, 24 Aug 2023 01:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Thu, 24 Aug 2023 05:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62812 X-GNU-PR-Package: emacs,gnus Original-Received: via spool by 62812-submit@debbugs.gnu.org id=B62812.169285619528454 (code B ref 62812); Thu, 24 Aug 2023 05:50:02 +0000 Original-Received: (at 62812) by debbugs.gnu.org; 24 Aug 2023 05:49:55 +0000 Original-Received: from localhost ([127.0.0.1]:35931 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZ3EA-0007Or-F8 for submit@debbugs.gnu.org; Thu, 24 Aug 2023 01:49:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49116) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZ3E7-0007Oa-TH for 62812@debbugs.gnu.org; Thu, 24 Aug 2023 01:49:53 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZ3Dy-0007bh-8t; Thu, 24 Aug 2023 01:49:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=TYpTPNMR3SJJvt7JoJR/YCWyrtE37A3QoVvHA9HXXkw=; b=jL8c8PnoPKSB sce33YEuEtpXxLPPWaBqI3JM58ATcGc7fAP9hn1do4NCE96zIUlqo596Ldljurv34dxMfzsObYubx tUS5IzGtkmJDnwTwTb8Ll+tuyvWV7PZQ27uGDcpGOIQXxBEk/UazbQHapBwEtR3cng4m1XGawyQK0 7urQ8jU111ScWsJhprlSOt5coK5Nk0TdC4TLgS6Ds7eq+TpponcZG+qOYj0WplFnaCldVSCz63x6y KRR7FERxqAIeNeywKa2Ud/MvOKNwDdTY4AW02HaJlqO30p05kthmd7q9K+HbQ80r57XFnSB7XOSQD r+8uYTHIB/OItzHLU06wWQ==; In-Reply-To: <87lee1hfje.fsf@ericabrahamsen.net> (message from Eric Abrahamsen on Wed, 23 Aug 2023 09:47:17 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268302 Archived-At: > From: Eric Abrahamsen > Cc: James Thomas , Andrew G Cohen , > 62812@debbugs.gnu.org > Date: Wed, 23 Aug 2023 09:47:17 -0700 > > Eli Zaretskii writes: > > >> From: James Thomas > >> Date: Wed, 23 Aug 2023 19:07:51 +0530 > >> > >> James Thomas wrote: > >> > >> > Turned out to be a trivial fix: > >> > > >> > diff --git a/lisp/gnus/nnmail.el b/lisp/gnus/nnmail.el > >> > index e8f157392d4..904b564409a 100644 > >> > --- a/lisp/gnus/nnmail.el > >> > +++ b/lisp/gnus/nnmail.el > >> > @@ -667,7 +667,9 @@ nnmail-parse-active > >> > (cond ((symbolp group) > >> > (symbol-name group)) > >> > ((numberp group) > >> > - (number-to-string group)))) > >> > + (number-to-string group)) > >> > + ((stringp group) > >> > + group))) > >> > (if (and (numberp (setq max (read buffer))) > >> > (numberp (setq min (read buffer)))) > >> > (push (list group (cons min max)) > >> > >> And it'll merely make it the same as this already-existing code > >> elsewhere: > >> > >> diff -u --label ./lisp/gnus/gnus-start.el --label \#\ ./lisp/gnus/gnus-start.el /tmp/buffer-content-IYvzRp > >> --- ./lisp/gnus/gnus-start.el > >> +++ # > >> @@ -2149,8 +2149,6 @@ > >> (number-to-string group)) > >> ((symbolp group) > >> (symbol-name group)) > >> - ((stringp group) > >> - group))))) > >> (numberp (setq max (read cur))) > >> (numberp (setq min (read cur))) > >> (null (progn > >> > >> -- > > > > Eric, Andrew: any comments? > > Yes! This looks like a correct fix to me. OK, but now I'm confused regarding which change(s) to install. This discussion includes 3 changes, so which ones are proposed and approved? James, would you please post a single consolidated patch you think should be installed, with the appropriate commit log message? Thanks.