unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#17663: 24.4.50; arc-mode.el has unrar-free hard-coded
@ 2014-06-02  9:05 Dieter Deyke
  2014-06-02 14:12 ` Stefan Monnier
  0 siblings, 1 reply; 10+ messages in thread
From: Dieter Deyke @ 2014-06-02  9:05 UTC (permalink / raw)
  To: 17663




    arc-mode.el in the trunk has unrar-free hard-coded. unrar-free is no
    longer available in debian testing, and did not work correctly when
    it was available in the past. It would be better to use unar/lsar
    instead, see http://unarchiver.c3.cx/





In GNU Emacs 24.4.50.1 (i686-pc-linux-gnu, GTK+ Version 2.24.23)
 of 2014-05-30 on deyke2
Windowing system distributor `The X.Org Foundation', version 11.0.11501000
System Description:	Debian GNU/Linux testing (jessie)

Configured using:
 `configure --prefix=/usr/local/emacs'

Configured features:
XPM JPEG TIFF GIF PNG RSVG SOUND GPM DBUS GCONF GSETTINGS NOTIFY LIBXML2
FREETYPE LIBOTF XFT ZLIB

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Dired by name

Minor modes in effect:
  delete-selection-mode: t
  cua-mode: t
  msb-mode: t
  icomplete-mode: t
  show-paren-mode: t
  which-function-mode: t
  display-time-mode: t
  tooltip-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  buffer-read-only: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
<down> <return> C-s 3 SPC j u n SPC 1 4 <left> <left> 
<left> <left> <left> <left> <left> <left> 4 <delete> 
C-s C-s <down> C-s 4 SPC j u n SPC 1 4 <left> <left> 
<left> <left> <left> <left> <left> <left> 3 <delete> 
<f9> <help-echo> <help-echo> M-x t e r m <tab> <return> 
<return> c d SPC <return> . / c a <tab> m a <tab> <return> 
<up> <return> <help-echo> <f5> M-x a p t <tab> e a 
<tab> <return> u n a r <return> <f6> C-s u n a r <next> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <return> <down> <down> <C-down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <C-down> 
<down> <down> <down> <up> <C-down> <C-down> <C-down> 
<C-down> <C-down> <C-down> <C-down> <down> <down> <down> 
<down> <down> <down> <right> <right> <right> <right> 
<right> <right> <right> <right> <right> <right> C-c 
n <help-echo> <help-echo> <help-echo> <down-mouse-1> 
<mouse-1> C-x C-f ~ / d e s k <tab> <return> <return> 
C-x 1 <down> <down> <down> <down> <down> <down> <return> 
<down> <down> <down> <down> <down> <down> <C-down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <C-down> <C-down> <C-down> <C-down> 
<C-down> <C-down> <C-down> <C-down> <C-down> <C-down> 
<C-down> <C-down> <C-down> <C-down> <C-down> <C-down> 
<C-down> <C-down> <C-down> <C-down> <C-down> <C-down> 
<C-down> <next> <f5> <f5> d x <up> <return> g <help-echo> 
<help-echo> <help-echo> M-x r e p o <tab> r t <tab> 
b u <tab> <return> <S-f7> <switch-frame> C-x d <switch-frame> 
<down-mouse-1> <mouse-movement> <mouse-1> C-x d / u 
s r / l o <tab> e m <tab> <return> <down> <down> <return> 
<down> <return> <return> <down> <return> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <return> <switch-frame> <down-mouse-1> 
<mouse-movement> <mouse-1> M-x <up> <return>

Recent messages:
Killed inactive buffer: essen.
Killed inactive buffer: database.
Building Debian package lists...done.
Mark saved where search started
Parsing archive file...done.
Deleting...done
Making completion list...
byte-code: Command attempted to use minibuffer while in minibuffer
uncompressing arc-mode.el.gz...done
Note: file is write protected

Load-path shadows:
/home/deyke/.emacs.d/elpa/emms-20140529.1117/tq hides /usr/local/emacs/share/emacs/24.4.50/lisp/emacs-lisp/tq

Features:
(shadow nnir emacsbug sendmail add-log arc-mode archive-mode thingatpt
apt-utils swbuff term ehelp w3m-form w3m browse-url w3m-hist w3m-fb
bookmark-w3m w3m-ems w3m-ccl ccl w3m-favicon w3m-image w3m-proc w3m-util
qp tabify dd-misc cal-move misearch multi-isearch vc-git time-stamp
copyright flow-fill mm-archive gnus-picon smiley gnus-cite gnus-async
gnus-bcklg gnus-ml disp-table gnus-topic nnrss mm-url nndraft nnmh
gnus-agent gnus-srvr gnus-score score-mode nnvirtual gnus-msg nnfolder
nnml gnus-cache bbdb-gnus gnus-art mm-uu mml2015 epg-config mm-view
mml-smime smime dig gnus-sum bbdb-snarf mail-extr bbdb-com warnings
network-stream starttls nntp gnus-group gnus-undo spam-stat gnus-start
gnus-cloud nnimap nnmail mail-source tls utf7 nnoo parse-time gnus-spec
gnus-int gnus-range gnus-win gnus gnus-ems nnheader session view
cal-china lunar solar cal-dst cal-bahai cal-islam cal-hebrew holidays
hol-loaddefs diary-lib diary-loaddefs cal-iso vc-fossil tempbuf
org-element org-rmail org-mhe org-irc org-info org-gnus org-docview
doc-view jka-compr image-mode org-bibtex bibtex org-bbdb org-w3m
org-agenda org org-macro org-footnote org-pcomplete pcomplete org-list
org-faces org-entities noutline outline org-version ob-emacs-lisp ob
ob-tangle org-src ob-ref ob-lob ob-table ob-keys ob-exp ob-comint comint
ansi-color ob-core ob-eval org-compat org-macs org-loaddefs find-func
cal-menu calendar cal-loaddefs generic-x rcirc ring netrc
emms-librefm-stream xml emms-librefm-scrobbler emms-playlist-limit
emms-volume easy-mmode emms-volume-amixer emms-i18n emms-history
emms-score emms-stream-info emms-metaplaylist-mode emms-bookmarks
emms-cue emms-mode-line-icon emms-browser sort emms-playlist-sort
emms-last-played emms-player-xine emms-player-mpd tq emms-playing-time
emms-lyrics emms-url url url-proxy url-privacy url-expand url-methods
url-history url-cookie url-domsuf url-util url-parse auth-source eieio
byte-opt bytecomp byte-compile cconv eieio-core gnus-util password-cache
url-vars mailcap emms-streams emms-tag-editor emms-mark emms-mode-line
emms-cache emms-info-ogginfo emms-info-mp3info emms-info later-do
emms-playlist-mode emms-player-vlc advice emms-player-mplayer
emms-player-simple emms-source-playlist emms-source-file locate
emms-setup emms emms-compat bongo mule-util lastfm-submit allout cl-macs
color-theme wid-edit cl gv cl-loaddefs cl-lib server message-x message
format-spec rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse
rfc2231 rfc2047 rfc2045 ietf-drums mm-util help-fns mail-prsvr
mailabbrev mail-utils gmm-utils mailheader bbdb-autoloads bbdb timezone
delsel cua-base msb icomplete mic-paren paren dired which-func imenu
time avoid sudoku-autoloads info easymenu package time-date tooltip
electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd
tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment
lisp-mode prog-mode register page menu-bar rfn-eshadow timer select
scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham
georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese hebrew greek romanian slovak czech european ethiopic
indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple
abbrev minibuffer nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote make-network-process
dbusbind gfilenotify dynamic-setting system-font-setting
font-render-setting move-toolbar gtk x-toolkit x multi-tty emacs)

Memory information:
((conses 8 527232 79627)
 (symbols 24 75886 181)
 (miscs 20 478 969)
 (strings 16 205046 22069)
 (string-bytes 1 5364881)
 (vectors 8 61330)
 (vector-slots 4 1897938 42824)
 (floats 8 10760 85288)
 (intervals 28 4770 567)
 (buffers 512 46)
 (heap 1024 41300 1101))

-- 
Dieter Deyke
mailto:dieter.deyke@gmail.com





^ permalink raw reply	[flat|nested] 10+ messages in thread

* bug#17663: 24.4.50; arc-mode.el has unrar-free hard-coded
  2014-06-02  9:05 bug#17663: 24.4.50; arc-mode.el has unrar-free hard-coded Dieter Deyke
@ 2014-06-02 14:12 ` Stefan Monnier
  2014-06-02 14:40   ` Dieter Deyke
  2015-09-30  8:18   ` Nicolas Petton
  0 siblings, 2 replies; 10+ messages in thread
From: Stefan Monnier @ 2014-06-02 14:12 UTC (permalink / raw)
  To: Dieter Deyke; +Cc: 17663

>     arc-mode.el in the trunk has unrar-free hard-coded. unrar-free is no
>     longer available in debian testing, and did not work correctly when
>     it was available in the past. It would be better to use unar/lsar
>     instead, see http://unarchiver.c3.cx/

Indeed, thanks for bringing it up.  Could you provide a patch that does that?


        Stefan





^ permalink raw reply	[flat|nested] 10+ messages in thread

* bug#17663: 24.4.50; arc-mode.el has unrar-free hard-coded
  2014-06-02 14:12 ` Stefan Monnier
@ 2014-06-02 14:40   ` Dieter Deyke
  2015-09-30  8:18   ` Nicolas Petton
  1 sibling, 0 replies; 10+ messages in thread
From: Dieter Deyke @ 2014-06-02 14:40 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: 17663

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>>     arc-mode.el in the trunk has unrar-free hard-coded. unrar-free is no
>>     longer available in debian testing, and did not work correctly when
>>     it was available in the past. It would be better to use unar/lsar
>>     instead, see http://unarchiver.c3.cx/
>
> Indeed, thanks for bringing it up.  Could you provide a patch that does that?

I wish I could, but my lisp skills are almost nil.

-- 
Dieter Deyke
mailto:dieter.deyke@gmail.com





^ permalink raw reply	[flat|nested] 10+ messages in thread

* bug#17663: 24.4.50; arc-mode.el has unrar-free hard-coded
  2014-06-02 14:12 ` Stefan Monnier
  2014-06-02 14:40   ` Dieter Deyke
@ 2015-09-30  8:18   ` Nicolas Petton
  2015-09-30  8:20     ` Nicolas Petton
                       ` (2 more replies)
  1 sibling, 3 replies; 10+ messages in thread
From: Nicolas Petton @ 2015-09-30  8:18 UTC (permalink / raw)
  To: Stefan Monnier, 17663

[-- Attachment #1: Type: text/plain, Size: 689 bytes --]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>>     arc-mode.el in the trunk has unrar-free hard-coded. unrar-free is no
>>     longer available in debian testing, and did not work correctly when
>>     it was available in the past. It would be better to use unar/lsar
>>     instead, see http://unarchiver.c3.cx/
>
> Indeed, thanks for bringing it up.  Could you provide a patch that
> does that?

I just installed a patch in master to use unar and lsar.

My patch removes the use of the "unrar-free" binary completely as 1) it
is no longer available in Fedora, Ubuntu and Debian and 2) it has been
reported not to work properly, but I guess that's up for discussion.

Cheers,
Nico

[-- Attachment #2.1: Type: text/plain, Size: 0 bytes --]



[-- Attachment #2.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 512 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* bug#17663: 24.4.50; arc-mode.el has unrar-free hard-coded
  2015-09-30  8:18   ` Nicolas Petton
@ 2015-09-30  8:20     ` Nicolas Petton
  2015-09-30  9:51     ` Stefan Monnier
  2015-09-30 10:16     ` Eli Zaretskii
  2 siblings, 0 replies; 10+ messages in thread
From: Nicolas Petton @ 2015-09-30  8:20 UTC (permalink / raw)
  To: 17663; +Cc: 17663-done

[-- Attachment #1: Type: text/plain, Size: 138 bytes --]

Nicolas Petton <nicolas@petton.fr> writes:

> I just installed a patch in master to use unar and lsar.

I'm now closing this issue.

Nico

[-- Attachment #2.1: Type: text/plain, Size: 0 bytes --]



[-- Attachment #2.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 512 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* bug#17663: 24.4.50; arc-mode.el has unrar-free hard-coded
  2015-09-30  8:18   ` Nicolas Petton
  2015-09-30  8:20     ` Nicolas Petton
@ 2015-09-30  9:51     ` Stefan Monnier
  2015-09-30 10:16     ` Eli Zaretskii
  2 siblings, 0 replies; 10+ messages in thread
From: Stefan Monnier @ 2015-09-30  9:51 UTC (permalink / raw)
  To: Nicolas Petton; +Cc: 17663

> I just installed a patch in master to use unar and lsar.

Thanks.

> My patch removes the use of the "unrar-free" binary completely as 1) it
> is no longer available in Fedora, Ubuntu and Debian and 2)

According to https://packages.qa.debian.org/u/unrar-free.html,
it's available (again) in Debian.

> it has been reported not to work properly, but I guess that's up
> for discussion.

AFAIK it was working OK, except for the fact that it did not handle all
compression methods supported by the nonfree "unrar".

But since unar works arguably better, it's OK to drop
unrar-free, indeed.


        Stefan


PS: Btw, if you're up for some maintenance work on arc-mode.el, there's
a real problem to fix in it: opening a large .zip file (for example) can
take a *very* long time.  This time is spent in set-buffer-multibyte
(turning the buffer from unibyte to multibyte) which ends up doing
O(N^2) work.  We have a workaround for this problem in auto-coding-alist
where we arrange for those binary files to be loaded directly into
a multibyte buffer (thanks to the no-conversion-multibyte
coding-system), thus avoiding the nasty O(N^2) problem.  But a better
solution would be to do what we do in tar-mode.el: rather than keep the
archive's binary data and its user-displayed listing both in the same
buffer, we use two different buffers: a unibyte one containing the
binary data, and a multibyte one displaying the contents.





^ permalink raw reply	[flat|nested] 10+ messages in thread

* bug#17663: 24.4.50; arc-mode.el has unrar-free hard-coded
  2015-09-30  8:18   ` Nicolas Petton
  2015-09-30  8:20     ` Nicolas Petton
  2015-09-30  9:51     ` Stefan Monnier
@ 2015-09-30 10:16     ` Eli Zaretskii
  2015-09-30 12:06       ` Nicolas Petton
  2 siblings, 1 reply; 10+ messages in thread
From: Eli Zaretskii @ 2015-09-30 10:16 UTC (permalink / raw)
  To: Nicolas Petton; +Cc: 17663, monnier

> From: Nicolas Petton <nicolas@petton.fr>
> Date: Wed, 30 Sep 2015 10:18:14 +0200
> 
> I just installed a patch in master to use unar and lsar.
> 
> My patch removes the use of the "unrar-free" binary completely as 1) it
> is no longer available in Fedora, Ubuntu and Debian and 2) it has been
> reported not to work properly, but I guess that's up for discussion.

Given the troubled history of the Free Software programs available to
access RAR archives, and its various format versions, I'd prefer that
we had more than one solution for RAR.  Having just one hard-coded
program sounds like a near-term maintenance headache.  Other
possibilities include unrar-free, GNA's unrar, and bsdtar from
libarchive.  I think we should make this more future-proof.  Nicolas,
would you like to work on that?

P.S. Full disclosure: I actually dislike RAR very much, due to its
non-free nature, and wish we've expressed our dislike by not
supporting it at all.  But given its widespread use (which I don't
quite comprehend, given the XZ format's performance), I don't expect
that to fly any time soon.





^ permalink raw reply	[flat|nested] 10+ messages in thread

* bug#17663: 24.4.50; arc-mode.el has unrar-free hard-coded
  2015-09-30 10:16     ` Eli Zaretskii
@ 2015-09-30 12:06       ` Nicolas Petton
  2015-09-30 13:56         ` Eli Zaretskii
  0 siblings, 1 reply; 10+ messages in thread
From: Nicolas Petton @ 2015-09-30 12:06 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 17663, monnier

[-- Attachment #1: Type: text/plain, Size: 974 bytes --]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Nicolas Petton <nicolas@petton.fr>
>> Date: Wed, 30 Sep 2015 10:18:14 +0200
>> 
>> I just installed a patch in master to use unar and lsar.
>> 
>> My patch removes the use of the "unrar-free" binary completely as 1) it
>> is no longer available in Fedora, Ubuntu and Debian and 2) it has been
>> reported not to work properly, but I guess that's up for discussion.
>
> Given the troubled history of the Free Software programs available to
> access RAR archives, and its various format versions, I'd prefer that
> we had more than one solution for RAR.  Having just one hard-coded
> program sounds like a near-term maintenance headache.  Other
> possibilities include unrar-free, GNA's unrar, and bsdtar from
> libarchive.  I think we should make this more future-proof.  Nicolas,
> would you like to work on that?

Would adding support for (GNA) unrar be enough for you?
If so, I'll gladly add it.

Nico

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 512 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* bug#17663: 24.4.50; arc-mode.el has unrar-free hard-coded
  2015-09-30 12:06       ` Nicolas Petton
@ 2015-09-30 13:56         ` Eli Zaretskii
  2015-10-05 11:19           ` Nicolas Petton
  0 siblings, 1 reply; 10+ messages in thread
From: Eli Zaretskii @ 2015-09-30 13:56 UTC (permalink / raw)
  To: Nicolas Petton; +Cc: 17663, monnier

> From: Nicolas Petton <nicolas@petton.fr>
> Cc: monnier@iro.umontreal.ca, 17663@debbugs.gnu.org
> Date: Wed, 30 Sep 2015 14:06:05 +0200
> 
> > Given the troubled history of the Free Software programs available to
> > access RAR archives, and its various format versions, I'd prefer that
> > we had more than one solution for RAR.  Having just one hard-coded
> > program sounds like a near-term maintenance headache.  Other
> > possibilities include unrar-free, GNA's unrar, and bsdtar from
> > libarchive.  I think we should make this more future-proof.  Nicolas,
> > would you like to work on that?
> 
> Would adding support for (GNA) unrar be enough for you?
> If so, I'll gladly add it.

Sure, please do, and thanks.





^ permalink raw reply	[flat|nested] 10+ messages in thread

* bug#17663: 24.4.50; arc-mode.el has unrar-free hard-coded
  2015-09-30 13:56         ` Eli Zaretskii
@ 2015-10-05 11:19           ` Nicolas Petton
  0 siblings, 0 replies; 10+ messages in thread
From: Nicolas Petton @ 2015-10-05 11:19 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 17663, monnier

[-- Attachment #1: Type: text/plain, Size: 521 bytes --]

Eli Zaretskii <eliz@gnu.org> writes:

>> Would adding support for (GNA) unrar be enough for you?
>> If so, I'll gladly add it.
>
> Sure, please do, and thanks.

After having a second look at the GNA unrar download page at
http://download.gna.org/unrar/ it appears that there hasn't been any
release since the 0.0.1 release in 2004, so I'm a lot less sure that
adding support for it in arc-mode would make sense.

libarchive seems to support extracting and listing rar files though, so
I might go with that instead.

Nico

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 512 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2015-10-05 11:19 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-02  9:05 bug#17663: 24.4.50; arc-mode.el has unrar-free hard-coded Dieter Deyke
2014-06-02 14:12 ` Stefan Monnier
2014-06-02 14:40   ` Dieter Deyke
2015-09-30  8:18   ` Nicolas Petton
2015-09-30  8:20     ` Nicolas Petton
2015-09-30  9:51     ` Stefan Monnier
2015-09-30 10:16     ` Eli Zaretskii
2015-09-30 12:06       ` Nicolas Petton
2015-09-30 13:56         ` Eli Zaretskii
2015-10-05 11:19           ` Nicolas Petton

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).