From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 43754@debbugs.gnu.org, syohex@gmail.com
Subject: bug#43754: [PATCH] configure help message of --with-json
Date: Sat, 03 Oct 2020 20:59:19 +0300 [thread overview]
Message-ID: <83ft6vfax4.fsf@gnu.org> (raw)
In-Reply-To: <871rifurma.fsf@gnus.org> (message from Lars Ingebrigtsen on Sat, 03 Oct 2020 19:49:33 +0200)
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: syohex@gmail.com, 43754@debbugs.gnu.org
> Date: Sat, 03 Oct 2020 19:49:33 +0200
>
> Oh, hey, whaddayaknow, it was a patch I applied a couple months ago:
>
> commit 43091e6c5069797ba17d2c7429e0122d3a5337d9
> Author: Noam Postavsky <npostavs@gmail.com>
> AuthorDate: Fri Aug 14 19:31:16 2020 +0200
> Commit: Lars Ingebrigtsen <larsi@gnus.org>
> CommitDate: Fri Aug 14 19:31:16 2020 +0200
>
> Make configure say so if we have "--with-json" but no jansson support
>
> * configure.ac (OPTION_DEFAULT_IFAVAILABLE): New macro. Use it to
> define the --with-json option. Add with_json and HAVE_JSON to the
> 'MISSING' checks (bug#39953).
>
> bug#39953 has the rationale behind the change.
What I said there notwithstanding, it looks like --with-json is the
odd one out nowadays, as we handle all the other optional libraries
differently. So it seems to me that we should switch to DEFAULT_ON
for this library.
Obviously, it is not a catastrophe to leave it as it is now...
prev parent reply other threads:[~2020-10-03 17:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 0:48 bug#43754: [PATCH] configure help message of --with-json Shohei Yoshida
2020-10-02 1:14 ` Lars Ingebrigtsen
2020-10-02 2:54 ` 황병희
2020-10-02 6:47 ` Eli Zaretskii
2020-10-02 14:28 ` Lars Ingebrigtsen
2020-10-02 15:06 ` Eli Zaretskii
2020-10-03 17:49 ` Lars Ingebrigtsen
2020-10-03 17:59 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ft6vfax4.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=43754@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=syohex@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).