From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#43754: [PATCH] configure help message of --with-json Date: Sat, 03 Oct 2020 20:59:19 +0300 Message-ID: <83ft6vfax4.fsf@gnu.org> References: <87o8llxwbz.fsf@gnus.org> <834kndgm47.fsf@gnu.org> <87ft6wwvl5.fsf@gnus.org> <83tuvcekfy.fsf@gnu.org> <871rifurma.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33842"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 43754@debbugs.gnu.org, syohex@gmail.com To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 03 20:00:25 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kOlpY-0008hz-W6 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 03 Oct 2020 20:00:24 +0200 Original-Received: from localhost ([::1]:60178 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kOlpY-0008Ud-1c for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 03 Oct 2020 14:00:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51208) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kOlpC-0008U1-VO for bug-gnu-emacs@gnu.org; Sat, 03 Oct 2020 14:00:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:32876) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kOlpC-0005PV-Aa for bug-gnu-emacs@gnu.org; Sat, 03 Oct 2020 14:00:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kOlpC-0000bl-6r for bug-gnu-emacs@gnu.org; Sat, 03 Oct 2020 14:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 Oct 2020 18:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43754 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed Original-Received: via spool by 43754-submit@debbugs.gnu.org id=B43754.16017479732274 (code B ref 43754); Sat, 03 Oct 2020 18:00:02 +0000 Original-Received: (at 43754) by debbugs.gnu.org; 3 Oct 2020 17:59:33 +0000 Original-Received: from localhost ([127.0.0.1]:44422 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kOloj-0000ab-Dh for submit@debbugs.gnu.org; Sat, 03 Oct 2020 13:59:33 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44336) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kOloi-0000aP-AC for 43754@debbugs.gnu.org; Sat, 03 Oct 2020 13:59:32 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:56409) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kOloc-0005M5-Us; Sat, 03 Oct 2020 13:59:26 -0400 Original-Received: from [176.228.60.248] (port=1539 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kOlob-0002aH-P5; Sat, 03 Oct 2020 13:59:26 -0400 In-Reply-To: <871rifurma.fsf@gnus.org> (message from Lars Ingebrigtsen on Sat, 03 Oct 2020 19:49:33 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:189715 Archived-At: > From: Lars Ingebrigtsen > Cc: syohex@gmail.com, 43754@debbugs.gnu.org > Date: Sat, 03 Oct 2020 19:49:33 +0200 > > Oh, hey, whaddayaknow, it was a patch I applied a couple months ago: > > commit 43091e6c5069797ba17d2c7429e0122d3a5337d9 > Author: Noam Postavsky > AuthorDate: Fri Aug 14 19:31:16 2020 +0200 > Commit: Lars Ingebrigtsen > CommitDate: Fri Aug 14 19:31:16 2020 +0200 > > Make configure say so if we have "--with-json" but no jansson support > > * configure.ac (OPTION_DEFAULT_IFAVAILABLE): New macro. Use it to > define the --with-json option. Add with_json and HAVE_JSON to the > 'MISSING' checks (bug#39953). > > bug#39953 has the rationale behind the change. What I said there notwithstanding, it looks like --with-json is the odd one out nowadays, as we handle all the other optional libraries differently. So it seems to me that we should switch to DEFAULT_ON for this library. Obviously, it is not a catastrophe to leave it as it is now...