unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Daniel Martín" <mardani29@yahoo.es>
Cc: 52605@debbugs.gnu.org
Subject: bug#52605: [PATCH] Add isearch-emoji-by-name
Date: Sun, 19 Dec 2021 08:53:35 +0200	[thread overview]
Message-ID: <83fsqp9jbk.fsf@gnu.org> (raw)
In-Reply-To: <m1czltv2qo.fsf@yahoo.es> (message from Daniel Martín on Sun, 19 Dec 2021 01:48:31 +0100)

> From: Daniel Martín <mardani29@yahoo.es>
> Cc: 52605@debbugs.gnu.org
> Date: Sun, 19 Dec 2021 01:48:31 +0100
> 
> > Likewise here, the doc string should clarify what kind of names are
> > acceptable.  I would also mention that completion is provided while
> > typing the name.
> 
> If I'm not mistaken, what the new emoji-search command accepts is
> technically the CLDR short name of an Emoji.  As the term is a bit
> obscure, I've added a few examples to the documentation.

I think examples are good, but they are not enough.  We should point
to the document which defines these names somewhere, I guess in the
manual.  Where did you see that terminology ("CLDR names"), and what
is the definitive document for it?

> And now 'C-x 8 e s' prompts with:
> 
>   Insert emoji (CLDR short name):

Is the "short" part necessary?  It immediately begs the question "how
does that differ from a long name?"

Btw, the same problem exists in doc strings in emoji.el.  I tried to
improve that yesterday, but it sounds like I understood the "name"
part incorrectly, so it will need another round of changes.

Thanks.





  reply	other threads:[~2021-12-19  6:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <m135mpyc8p.fsf.ref@yahoo.es>
2021-12-18 18:55 ` bug#52605: [PATCH] Add isearch-emoji-by-name Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-18 19:07   ` Eli Zaretskii
2021-12-19  0:48     ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-19  6:53       ` Eli Zaretskii [this message]
2021-12-19 11:47         ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-19 11:10   ` Lars Ingebrigtsen
2022-01-09 21:56     ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-10  8:07       ` Juri Linkov
2022-01-10 22:44         ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-12  6:02           ` Lars Ingebrigtsen
2022-01-12 17:50             ` Juri Linkov
2022-01-13  6:05               ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83fsqp9jbk.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=52605@debbugs.gnu.org \
    --cc=mardani29@yahoo.es \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).