From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#52605: [PATCH] Add isearch-emoji-by-name Date: Sun, 19 Dec 2021 08:53:35 +0200 Message-ID: <83fsqp9jbk.fsf@gnu.org> References: <83lf0hag05.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14101"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 52605@debbugs.gnu.org To: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 19 07:54:21 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1myq5N-0003SA-0I for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Dec 2021 07:54:21 +0100 Original-Received: from localhost ([::1]:57138 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1myq5L-0007yZ-E2 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Dec 2021 01:54:19 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:40604) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1myq55-0007wB-5q for bug-gnu-emacs@gnu.org; Sun, 19 Dec 2021 01:54:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33194) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1myq53-0005s6-RO for bug-gnu-emacs@gnu.org; Sun, 19 Dec 2021 01:54:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1myq53-0005Zw-MO for bug-gnu-emacs@gnu.org; Sun, 19 Dec 2021 01:54:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Dec 2021 06:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52605 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 52605-submit@debbugs.gnu.org id=B52605.163989683121425 (code B ref 52605); Sun, 19 Dec 2021 06:54:01 +0000 Original-Received: (at 52605) by debbugs.gnu.org; 19 Dec 2021 06:53:51 +0000 Original-Received: from localhost ([127.0.0.1]:44740 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myq4t-0005ZV-Gg for submit@debbugs.gnu.org; Sun, 19 Dec 2021 01:53:51 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:39846) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myq4s-0005ZJ-B8 for 52605@debbugs.gnu.org; Sun, 19 Dec 2021 01:53:50 -0500 Original-Received: from [2001:470:142:3::e] (port=53056 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1myq4n-0005rW-1t; Sun, 19 Dec 2021 01:53:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=RghdDEPhlqfmJHEMDNjsU9KDiuh2EyMFUTyVHOjDa9c=; b=jV5FW2od+JsCRHXwHCDD 6W3JWojUNlnb8tFxBCEVVOpIQ5QCRDORbhnmgXfsduQuro0osg7zdhfb+ZXJAvRNmUdQjtF4GpqRA /QKHXet9g47TpG58argDaHKBexsNuXQgsgDLbEoZ24Lb5ftWiWYF1yCDINECIHppE1dNQG8Vwl3If MELvnZ8mIy/lyNqe6vP9MksqGM3agRI3wprFCbWP2IOFlSE1djqci5Raf4SLOybZ5mHR0vU/7DB4i AF11g0Xvd58e9tQUheZRAFfgdrleCwQtNVCgN/oNYS7J5Wc88bF545iyHn0htC9CM9Km/6IhqxuVN zvZp9X0klVhZrg==; Original-Received: from [87.69.77.57] (port=1704 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1myq4m-0002J4-Uk; Sun, 19 Dec 2021 01:53:45 -0500 In-Reply-To: (message from Daniel =?UTF-8?Q?Mart=C3=ADn?= on Sun, 19 Dec 2021 01:48:31 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:222632 Archived-At: > From: Daniel Martín > Cc: 52605@debbugs.gnu.org > Date: Sun, 19 Dec 2021 01:48:31 +0100 > > > Likewise here, the doc string should clarify what kind of names are > > acceptable. I would also mention that completion is provided while > > typing the name. > > If I'm not mistaken, what the new emoji-search command accepts is > technically the CLDR short name of an Emoji. As the term is a bit > obscure, I've added a few examples to the documentation. I think examples are good, but they are not enough. We should point to the document which defines these names somewhere, I guess in the manual. Where did you see that terminology ("CLDR names"), and what is the definitive document for it? > And now 'C-x 8 e s' prompts with: > > Insert emoji (CLDR short name): Is the "short" part necessary? It immediately begs the question "how does that differ from a long name?" Btw, the same problem exists in doc strings in emoji.el. I tried to improve that yesterday, but it sounds like I understood the "name" part incorrectly, so it will need another round of changes. Thanks.