unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 57079@debbugs.gnu.org, stefan@marxist.se
Subject: bug#57079: 29.0.50; Performance of seq-uniq is not very good
Date: Tue, 09 Aug 2022 20:36:34 +0300	[thread overview]
Message-ID: <83fsi5tj31.fsf@gnu.org> (raw)
In-Reply-To: <87o7wtwcu9.fsf@gnus.org> (message from Lars Ingebrigtsen on Tue,  09 Aug 2022 19:23:10 +0200)

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: stefan@marxist.se,  57079@debbugs.gnu.org
> Date: Tue, 09 Aug 2022 19:23:10 +0200
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> delete-dups is destructive.  You can copy the list first, of course, but
> >> seq-uniq should be much faster than it is.
> >
> > How much faster?  Using copy-sequence and delete-dups is 7 times
> > faster here than seq-uniq and twice faster than
> > gnus-delete-duplicates.
> 
> I didn't claim that seq-uniq will be faster than copy + delete-dups; I
> just said that it's unnecessarily slow.

But the above means that using seq-uniq with TESTFN nil is going to be
unnecessarily slow from the get-go.  People shouldn't use seq-uniq if
they don't need a non-default TESTFN, because much faster
implementations exist.

IOW, since this bug is about speed, not anything else, I think making
seq-uniq faster when TESTFN is nil isn't the right solution, the right
solution is to point out that seq-uniq's purpose in this case is not
to be a Speedy Gonzales.





  reply	other threads:[~2022-08-09 17:36 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-09 16:11 bug#57079: 29.0.50; Performance of seq-uniq is not very good Stefan Kangas
2022-08-09 16:47 ` Eli Zaretskii
2022-08-09 16:57   ` Lars Ingebrigtsen
2022-08-09 17:07     ` Eli Zaretskii
2022-08-09 17:21       ` Lars Ingebrigtsen
2022-08-09 17:45         ` Stefan Kangas
2022-08-09 17:18     ` Eli Zaretskii
2022-08-09 17:23       ` Lars Ingebrigtsen
2022-08-09 17:36         ` Eli Zaretskii [this message]
2022-08-09 17:50           ` Eli Zaretskii
2022-08-09 17:52           ` Lars Ingebrigtsen
2022-08-09 17:59             ` Eli Zaretskii
2022-08-09 18:03               ` Lars Ingebrigtsen
2022-08-09 18:16                 ` Eli Zaretskii
2022-08-09 19:35                   ` Juri Linkov
2022-08-12 13:16                     ` Lars Ingebrigtsen
2022-08-12 23:59                       ` Michael Heerdegen
2022-08-13 11:50                         ` Lars Ingebrigtsen
2022-08-13 20:24                           ` Michael Heerdegen
2022-08-15  6:39                             ` Lars Ingebrigtsen
2022-08-15 23:37                               ` Michael Heerdegen
2022-08-17 11:01                                 ` Lars Ingebrigtsen
2022-08-20  3:17                                   ` Michael Heerdegen
2022-08-20  9:19                                     ` Lars Ingebrigtsen
2022-08-20 15:13                                       ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83fsi5tj31.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=57079@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).