From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#57079: 29.0.50; Performance of seq-uniq is not very good Date: Tue, 09 Aug 2022 20:36:34 +0300 Message-ID: <83fsi5tj31.fsf@gnu.org> References: <83tu6ltlcq.fsf@gnu.org> <87y1vxwe0y.fsf@gnus.org> <83k07htjxf.fsf@gnu.org> <87o7wtwcu9.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35673"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 57079@debbugs.gnu.org, stefan@marxist.se To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 09 19:37:24 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oLTAR-00092K-7n for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Aug 2022 19:37:23 +0200 Original-Received: from localhost ([::1]:41140 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oLTAP-0008St-QU for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Aug 2022 13:37:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53346) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLTA6-0008RQ-PM for bug-gnu-emacs@gnu.org; Tue, 09 Aug 2022 13:37:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55069) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oLTA6-00078M-H3 for bug-gnu-emacs@gnu.org; Tue, 09 Aug 2022 13:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oLTA6-0005Zs-Cp for bug-gnu-emacs@gnu.org; Tue, 09 Aug 2022 13:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Aug 2022 17:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57079 X-GNU-PR-Package: emacs Original-Received: via spool by 57079-submit@debbugs.gnu.org id=B57079.166006661121423 (code B ref 57079); Tue, 09 Aug 2022 17:37:02 +0000 Original-Received: (at 57079) by debbugs.gnu.org; 9 Aug 2022 17:36:51 +0000 Original-Received: from localhost ([127.0.0.1]:44818 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLT9v-0005ZT-Fc for submit@debbugs.gnu.org; Tue, 09 Aug 2022 13:36:51 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40364) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLT9u-0005ZH-98 for 57079@debbugs.gnu.org; Tue, 09 Aug 2022 13:36:50 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:44086) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLT9o-00076X-U1; Tue, 09 Aug 2022 13:36:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=+d1/oKtAiu7IGcxX7Ur1fatGzMgeQipJWevqa+RJDhY=; b=Led15/dcjWAf BjS83kaeI2Lg4tMBc+0FIHtLeppJK/Ufsl2+wCETiZZPxKYdNIe9SejxbPGnlRGIgf1D1x3uSvLs9 2Tz4DSSnAdMVTHnPFfAY/NWBGsA3eggTR22pVTOS2KymC5/4CM3FIFMtyM2AZ0qKFxKWhVlipxKIK 1VQ51UqfCwEbzLU6nNaXzqenHPgAmXbX/3Qed5hfM97ukI3vU1rHwRjKNJXRSiNmXvqV545tgTB8T ku9fBzk68CMgNfyzXV8uCzukCWldyULLEwRDaeQBIuBq4wvIQ2//Kwp21BMWh0PWiJLzLyz3wWFvs FJNhmhtklbalXr6SgqqTzw==; Original-Received: from [87.69.77.57] (port=1246 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLT9o-0007tQ-DM; Tue, 09 Aug 2022 13:36:44 -0400 In-Reply-To: <87o7wtwcu9.fsf@gnus.org> (message from Lars Ingebrigtsen on Tue, 09 Aug 2022 19:23:10 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:239179 Archived-At: > From: Lars Ingebrigtsen > Cc: stefan@marxist.se, 57079@debbugs.gnu.org > Date: Tue, 09 Aug 2022 19:23:10 +0200 > > Eli Zaretskii writes: > > >> delete-dups is destructive. You can copy the list first, of course, but > >> seq-uniq should be much faster than it is. > > > > How much faster? Using copy-sequence and delete-dups is 7 times > > faster here than seq-uniq and twice faster than > > gnus-delete-duplicates. > > I didn't claim that seq-uniq will be faster than copy + delete-dups; I > just said that it's unnecessarily slow. But the above means that using seq-uniq with TESTFN nil is going to be unnecessarily slow from the get-go. People shouldn't use seq-uniq if they don't need a non-default TESTFN, because much faster implementations exist. IOW, since this bug is about speed, not anything else, I think making seq-uniq faster when TESTFN is nil isn't the right solution, the right solution is to point out that seq-uniq's purpose in this case is not to be a Speedy Gonzales.