bug#10188: make-mode.el patch

bug#10188: make-mode.el patch

[Daniel Pfeiffer]

[-- Attachment #1.1: Type: text/plain, Size: 1292 bytes --]

Hi,

So sorry, I give up on Bazaar.  I can understand cvs was not optimal for such 
a big project, but the VC chaos that has sprung up since is terrible!  Somehow 
I managed some time ago to download a gigantic emacs bzr repository.  But I 
used emacs VC commands to check in my patch, it doesn't show up in the 
internet and neither your quick start guide, nor the doc tells me why.  So I 
try to follow your instructions to set up my local sandbox anew, to no avail:

$ bzr checkout *bzr+ssh*://pfeiffer@bzr.savannah.gnu.org/srv/bzr/emacs/trunk trunk
bzr: ERROR: Not a branch: 
"bzr+ssh://pfeiffer@bzr.savannah.gnu.org/srv/bzr/emacs/trunk/".
$ bzr checkout *sftp*://pfeiffer@bzr.savannah.gnu.org/srv/bzr/emacs/trunk trunk
subsystem request failed on channel 0
bzr: ERROR: Unable to connect to SSH host bzr.savannah.gnu.org; EOF during 
negotiation

This has been going on for several days.  So please just accept a plain old 
submission:

2011-12-01  pfeiffer <occitan@esperanto.org>

     * progmodes/make-mode.el: Bring it up to date with imminent makepp
     V2.0.

coralament / best Grötens / liebe Grüße / best regards / elkorajn salutojn
Daniel Pfeiffer

-- 
lerne / learn / apprends / lär dig / ucz się    Esperanto:
                     http://lernu.net  /  http://ikurso.net


[-- Attachment #1.2: Type: text/html, Size: 2055 bytes --]

[-- Attachment #2: make-mode.diff --]
[-- Type: text/x-patch, Size: 5074 bytes --]

--- old/progmodes/make-mode.el	2011-11-26 08:26:37.000000000 +0100
+++ new/progmodes/make-mode.el	2011-11-27 18:22:28.639636060 +0100
@@ -315,25 +315,32 @@
   "List of keywords understood by automake.")
 
 (defconst makefile-gmake-statements
-  `("-sinclude" "sinclude" "vpath"	; makefile-makepp-statements takes rest
+  `("-sinclude" "sinclude"		; makefile-makepp-statements takes rest
     "ifdef" "ifndef" "ifeq" "ifneq" "-include" "define" "endef" "export"
-    "override define" "override" "unexport"
+    "override define" "override" "unexport" "vpath"
     ,@(cdr makefile-automake-statements))
   "List of keywords understood by gmake.")
 
-;; These are even more silly, because you can have more spaces in between.
 (defconst makefile-makepp-statements
-  `("and ifdef" "and ifndef" "and ifeq" "and ifneq" "and ifperl"
-    "and ifmakeperl" "and ifsys" "and ifnsys" "build_cache" "build_check"
+  `(t					; - alternately means _
+    ;; todo: take if* out of these lists, and let the negation regexp do it all
+    "ifperl" "ifmakeperl" "ifsys" "ifnsys" "iftrue" "ifntrue"
+    "and ifdef" "and ifndef" "and ifeq" "and ifneq" "and ifperl"
+    "and ifmakeperl" "and ifsys" "and ifnsys" "and iftrue" "and ifntrue"
     "else ifdef" "else ifndef" "else ifeq" "else ifneq" "else ifperl"
-    "else ifmakeperl" "else ifsys" "else ifnsys" "enddef" "global"
-    "load_makefile" "ifperl" "ifmakeperl" "ifsys" "ifnsys" "_include"
-    "makeperl" "makesub" "no_implicit_load" "perl" "perl-begin" "perl_begin"
-    "perl-end" "perl_end" "prebuild" "or ifdef" "or ifndef" "or ifeq"
-    "or ifneq" "or ifperl" "or ifmakeperl" "or ifsys" "or ifnsys"
-    "override export" "override global" "register_command_parser"
-    "register_scanner" "repository" "runtime" "signature" "sub"
-    ,@(nthcdr 3 makefile-gmake-statements))
+    "else ifmakeperl" "else ifsys" "else ifnsys" "else iftrue" "else ifntrue"
+    "or ifdef" "or ifndef" "or ifeq" "or ifneq" "or ifperl"
+    "or ifmakeperl" "or ifsys" "or ifnsys" "or iftrue" "or ifntrue"
+
+    "autoload" "build-cache" "build-check" "enddef" "export define"
+    "global" "global build-cache" "global build-check" "global define"
+    "global signature" "global override signature" "load-makefile"
+    "make" "makeperl" "makesub" "no-implicit-load" "perl" "perl-begin"
+    "perl-end" "prebuild" "override export" "override global" "register-parser"
+    "register-command-parser" "register-input-suffix"
+    "register-scanner" "repository" "runtime" "signature" "sub"
+
+    ,@(nthcdr 2 makefile-gmake-statements))
   "List of keywords understood by gmake.")
 
 (defconst makefile-bsdmake-statements
@@ -372,7 +379,11 @@
 
     ;; Fontify conditionals and includes.
     (,(concat "^\\(?: [ \t]*\\)?"
-	      (regexp-opt keywords t)
+	      (replace-regexp-in-string
+	       " " "[ \t]+"
+	       (if (eq (car keywords) t)
+		   (replace-regexp-in-string "-" "[_-]" (regexp-opt (cdr keywords) t))
+		 (regexp-opt keywords t)))
 	      "\\>[ \t]*\\([^: \t\n#]*\\)")
      (1 font-lock-keyword-face) (2 font-lock-variable-name-face))
 
@@ -436,7 +447,7 @@
    makefile-var-use-regex
    makefile-makepp-statements
    nil
-   "^\\(?: [ \t]*\\)?\\(?:and[ \t]+\\|else[ \t]+\\|or[ \t]+\\)?if\\(n\\)\\(?:def\\|eq\\|sys\\)\\>"
+   "^\\(?: [ \t]*\\)?\\(?:and[ \t]+\\|else[ \t]+\\|or[ \t]+\\)?if\\(n\\)\\(?:def\\|eq\\|sys\\|true\\)\\>"
 
    '("[^$]\\(\\$[({]\\(?:output\\|stem\\|target\\)s?\\_>.*?[})]\\)"
      1 'makefile-targets append)
@@ -447,17 +458,17 @@
      (2 font-lock-keyword-face t)
      (3 font-lock-variable-name-face t))
 
-   ;; $(function ...) $((function ...)) ${function ...} ${{function ...}}
-   '("[^$]\\$\\(?:((?\\|{{?\\)\\([-a-zA-Z0-9_.]+\\s \\)"
+   ;; $(function ...) $((function ...)) ${...} ${{...}} $[...] $[[...]]
+   '("[^$]\\$\\(?:((?\\|{{?\\|\\[\\[?\\)\\([-a-zA-Z0-9_.]+\\s \\)"
      1 font-lock-function-name-face prepend)
 
-   ;; $(shell ...) $((shell ...)) ${shell ...} ${{shell ...}}
-   '("[^$]\\$\\(((?\\|{{?\\)shell\\(?:[-_]\\(?:global[-_]\\)?once\\)?[ \t]+"
+   ;; $(shell ...) $((shell ...)) ${...} ${{...}} $[...] $[[...]]
+   '("[^$]\\$\\(((?\\|{{?\\|\\[\\[?\\)shell\\(?:[-_]\\(?:global[-_]\\)?once\\)?[ \t]+"
      makefile-match-function-end nil nil
      (1 'makefile-shell prepend t))
 
-   ;; $(perl ...) $((perl ...)) ${perl ...} ${{perl ...}}
-   '("[^$]\\$\\(((?\\|{{?\\)makeperl[ \t]+"
+   ;; $(perl ...) $((perl ...)) ${...} ${{...}} $[...] $[[...]]
+   '("[^$]\\$\\(((?\\|{{?\\|\\[\\[?\\)makeperl[ \t]+"
      makefile-match-function-end nil nil
      (1 'makefile-makepp-perl prepend t))
    '("[^$]\\$\\(((?\\|{{?\\)perl[ \t]+"
@@ -1688,8 +1699,10 @@
     ;; FIXME forward-sexp or somesuch would be better?
     (if (setq s (cond ((string= s "(") ")")
 		      ((string= s "{") "}")
+		      ((string= s "[") "]")
 		      ((string= s "((") "))")
-		      ((string= s "{{") "}}")))
+		      ((string= s "{{") "}}")
+		      ((string= s "[[") "]]")))
 	(re-search-forward (concat "\\(.*\\)[ \t]*" s) (line-end-position) t))))
 
 (defun makefile-match-dependency (bound)

bug#10188: make-mode.el patch

[Glenn Morris]

Daniel Pfeiffer wrote:

> $ bzr checkout *bzr+ssh*://pfeiffer@bzr.savannah.gnu.org/srv/bzr/emacs/trunk trunk
> bzr: ERROR: Not a branch:
> "bzr+ssh://pfeiffer@bzr.savannah.gnu.org/srv/bzr/emacs/trunk/".

I think that URL is quite old. Try:

bzr checkout bzr+ssh://pfeiffer@bzr.savannah.gnu.org/emacs/trunk 

I don't know why the instructions for fetching Emacs from bzr got farmed
out to a community wiki, but that's probably why there are several
lengthy documents that give different recommendations and are not
entirely up-to-date.

bug#10188: make-mode.el patch

[Eli Zaretskii]

> From: Glenn Morris <rgm@gnu.org>
> Date: Thu, 01 Dec 2011 18:04:36 -0500
> Cc: 10188@debbugs.gnu.org
> 
> Daniel Pfeiffer wrote:
> 
> > $ bzr checkout *bzr+ssh*://pfeiffer@bzr.savannah.gnu.org/srv/bzr/emacs/trunk trunk
> > bzr: ERROR: Not a branch:
> > "bzr+ssh://pfeiffer@bzr.savannah.gnu.org/srv/bzr/emacs/trunk/".
> 
> I think that URL is quite old. Try:
> 
> bzr checkout bzr+ssh://pfeiffer@bzr.savannah.gnu.org/emacs/trunk 
> 
> I don't know why the instructions for fetching Emacs from bzr got farmed
> out to a community wiki

??? Which wiki?  If you mean this:

  http://www.emacswiki.org/emacs/BzrForEmacsDevs

then it gives the correct up-to-date URL.  I have no idea where did
the OP get the URL he used.

bug#10188: make-mode.el patch

[Glenn Morris]

Eli Zaretskii wrote:

>   http://www.emacswiki.org/emacs/BzrForEmacsDevs
>
> then it gives the correct up-to-date URL.  I have no idea where did
> the OP get the URL he used.

"quick start guide" was mentioned, so perhaps it was an attempt to adapt

http://www.emacswiki.org/emacs/BzrQuickStartForEmacsDevs

bug#10188: make-mode.el patch

[Eli Zaretskii]

> From: Glenn Morris <rgm@gnu.org>
> Cc: occitan@esperanto.org,  10188@debbugs.gnu.org
> Date: Fri, 02 Dec 2011 02:40:39 -0500
> 
> Eli Zaretskii wrote:
> 
> >   http://www.emacswiki.org/emacs/BzrForEmacsDevs
> >
> > then it gives the correct up-to-date URL.  I have no idea where did
> > the OP get the URL he used.
> 
> "quick start guide" was mentioned, so perhaps it was an attempt to adapt
> 
> http://www.emacswiki.org/emacs/BzrQuickStartForEmacsDevs

That one was talking about the SFTP URL, not bzr+ssh.

I fixed the URL.

bug#10188: make-mode.el patch

[Chong Yidong]

Closing, since the patch is checked in (revision 106669).