* bug#13723: 24.2.93; Fringe icons corrupt buffer separator line
@ 2013-02-15 17:45 David Engster
2013-02-15 19:23 ` Eli Zaretskii
0 siblings, 1 reply; 18+ messages in thread
From: David Engster @ 2013-02-15 17:45 UTC (permalink / raw)
To: 13723
Maybe a small thing, but nonetheless irritating: I noticed that when
scrolling buffers on a split frame with disabled scrollbars, the small
line separating two buffers can get corrupted by icons in the fringe. It
seems that this line doesn't get redrawn correctly, or maybe not at all.
You should be able to reproduce this issue with the following recipe:
* emacs -Q
* In the *scratch* buffer, insert
(progn
(scroll-bar-mode -1)
(setq truncate-partial-width-windows nil)
(toggle-truncate-lines -1)
(with-current-buffer (get-buffer-create "test")
(erase-buffer)
(dotimes (i 100)
(insert (make-string 500 65) "\n")))
(pop-to-buffer-same-window "test")
(goto-char (point-max))
(split-window-right)
(other-window 1)
(split-window-right)
(pop-to-buffer-same-window "test")
(goto-char (point-min))
(while (not (eobp))
(scroll-up-command)
(redisplay t)))
and evaluate.
* The separator line between the first and the second buffer should now
have gaps. Here's a screenshot:
http://www.randomsample.de/emacs-bug.jpg
As soon as the Emacs window gets redrawn, everything's back to
normal.
-David
^ permalink raw reply [flat|nested] 18+ messages in thread
* bug#13723: 24.2.93; Fringe icons corrupt buffer separator line
2013-02-15 17:45 bug#13723: 24.2.93; Fringe icons corrupt buffer separator line David Engster
@ 2013-02-15 19:23 ` Eli Zaretskii
2013-02-15 19:30 ` Glenn Morris
0 siblings, 1 reply; 18+ messages in thread
From: Eli Zaretskii @ 2013-02-15 19:23 UTC (permalink / raw)
To: David Engster; +Cc: 13723
> From: David Engster <deng@randomsample.de>
> Date: Fri, 15 Feb 2013 18:45:20 +0100
>
> Maybe a small thing, but nonetheless irritating: I noticed that when
> scrolling buffers on a split frame with disabled scrollbars, the small
> line separating two buffers can get corrupted by icons in the fringe. It
> seems that this line doesn't get redrawn correctly, or maybe not at all.
It does get redrawn, see x_draw_vertical_border.
> You should be able to reproduce this issue with the following recipe:
>
> * emacs -Q
>
> * In the *scratch* buffer, insert
>
> (progn
> (scroll-bar-mode -1)
> (setq truncate-partial-width-windows nil)
> (toggle-truncate-lines -1)
> (with-current-buffer (get-buffer-create "test")
> (erase-buffer)
> (dotimes (i 100)
> (insert (make-string 500 65) "\n")))
> (pop-to-buffer-same-window "test")
> (goto-char (point-max))
> (split-window-right)
> (other-window 1)
> (split-window-right)
> (pop-to-buffer-same-window "test")
> (goto-char (point-min))
> (while (not (eobp))
> (scroll-up-command)
> (redisplay t)))
>
> and evaluate.
>
> * The separator line between the first and the second buffer should now
> have gaps. Here's a screenshot:
>
> http://www.randomsample.de/emacs-bug.jpg
Unfortunately, I cannot reproduce this here, neither with stock Emacs
24.2 nor with the current trunk. I get a perfectly drawn border.
^ permalink raw reply [flat|nested] 18+ messages in thread
* bug#13723: 24.2.93; Fringe icons corrupt buffer separator line
2013-02-15 19:23 ` Eli Zaretskii
@ 2013-02-15 19:30 ` Glenn Morris
2013-02-15 19:39 ` David Engster
` (2 more replies)
0 siblings, 3 replies; 18+ messages in thread
From: Glenn Morris @ 2013-02-15 19:30 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 13723, David Engster
Eli Zaretskii wrote:
> Unfortunately, I cannot reproduce this here, neither with stock Emacs
> 24.2 nor with the current trunk. I get a perfectly drawn border.
I see the issue in emacs-24 and trunk. x86_64 GNU/Linux, Lucid toolkit.
^ permalink raw reply [flat|nested] 18+ messages in thread
* bug#13723: 24.2.93; Fringe icons corrupt buffer separator line
2013-02-15 19:30 ` Glenn Morris
@ 2013-02-15 19:39 ` David Engster
2013-02-15 19:57 ` Eli Zaretskii
2013-02-15 19:56 ` Eli Zaretskii
2013-02-16 17:15 ` Jan Djärv
2 siblings, 1 reply; 18+ messages in thread
From: David Engster @ 2013-02-15 19:39 UTC (permalink / raw)
To: Glenn Morris; +Cc: 13723
Glenn Morris writes:
> Eli Zaretskii wrote:
>
>> Unfortunately, I cannot reproduce this here, neither with stock Emacs
>> 24.2 nor with the current trunk. I get a perfectly drawn border.
>
> I see the issue in emacs-24 and trunk. x86_64 GNU/Linux, Lucid toolkit.
Thank you both for testing. I forgot to add that I've also seen this
under GNU/Linux with the Lucid toolkit, but on two different boxes
(running Ubuntu 12.04 and Arch Linux, resp.). Eli, you've probably
tested this under Windows?
-David
^ permalink raw reply [flat|nested] 18+ messages in thread
* bug#13723: 24.2.93; Fringe icons corrupt buffer separator line
2013-02-15 19:30 ` Glenn Morris
2013-02-15 19:39 ` David Engster
@ 2013-02-15 19:56 ` Eli Zaretskii
2013-02-15 20:12 ` Glenn Morris
2013-02-16 17:15 ` Jan Djärv
2 siblings, 1 reply; 18+ messages in thread
From: Eli Zaretskii @ 2013-02-15 19:56 UTC (permalink / raw)
To: Glenn Morris; +Cc: 13723, deng
> From: Glenn Morris <rgm@gnu.org>
> Cc: David Engster <deng@randomsample.de>, 13723@debbugs.gnu.org
> Date: Fri, 15 Feb 2013 14:30:57 -0500
>
> Eli Zaretskii wrote:
>
> > Unfortunately, I cannot reproduce this here, neither with stock Emacs
> > 24.2 nor with the current trunk. I get a perfectly drawn border.
>
> I see the issue in emacs-24 and trunk. x86_64 GNU/Linux, Lucid toolkit.
Do you see it in previous versions, like 24.2 and 23.3? That will
tell us how urgent it is to fix this.
If this is a regression that needs to be fixed ASAP, can you trace
through the code which draws the border and see what goes wrong there?
The immediate suspects are those parts that reference the
redraw_fringe_bitmaps_p flag, and the x_draw_vertical_window_border
function.
Another possible way to see whodunit is to step through update_window
and update_window_line, and see which code removes the portions of the
vertical line.
Or maybe the problem is in the order in which fringe bitmaps and the
vertical border are drawn.
^ permalink raw reply [flat|nested] 18+ messages in thread
* bug#13723: 24.2.93; Fringe icons corrupt buffer separator line
2013-02-15 19:39 ` David Engster
@ 2013-02-15 19:57 ` Eli Zaretskii
0 siblings, 0 replies; 18+ messages in thread
From: Eli Zaretskii @ 2013-02-15 19:57 UTC (permalink / raw)
To: David Engster; +Cc: 13723
> From: David Engster <deng@randomsample.de>
> Cc: Eli Zaretskii <eliz@gnu.org>, 13723@debbugs.gnu.org
> Date: Fri, 15 Feb 2013 20:39:20 +0100
>
> Eli, you've probably tested this under Windows?
Yes, but it shouldn't matter. This level of redisplay is
device-independent, at least most of it.
^ permalink raw reply [flat|nested] 18+ messages in thread
* bug#13723: 24.2.93; Fringe icons corrupt buffer separator line
2013-02-15 19:56 ` Eli Zaretskii
@ 2013-02-15 20:12 ` Glenn Morris
2013-02-15 20:20 ` David Engster
2013-02-15 20:21 ` Glenn Morris
0 siblings, 2 replies; 18+ messages in thread
From: Glenn Morris @ 2013-02-15 20:12 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 13723, deng
Eli Zaretskii wrote:
> Do you see it in previous versions, like 24.2 and 23.3? That will
> tell us how urgent it is to fix this.
Since at least 24.1 (recipe does not work as written in 23.x).
I don't think is at all urgent to fix.
I also see it in GTK-2 builds, but it is not as obvious because for some
reason the middle window ends up scrolled to a different position, with
less space after the end of the "A"s.
^ permalink raw reply [flat|nested] 18+ messages in thread
* bug#13723: 24.2.93; Fringe icons corrupt buffer separator line
2013-02-15 20:12 ` Glenn Morris
@ 2013-02-15 20:20 ` David Engster
2013-02-15 20:21 ` Glenn Morris
1 sibling, 0 replies; 18+ messages in thread
From: David Engster @ 2013-02-15 20:20 UTC (permalink / raw)
To: Glenn Morris; +Cc: 13723
Glenn Morris writes:
> Eli Zaretskii wrote:
>
>> Do you see it in previous versions, like 24.2 and 23.3? That will
>> tell us how urgent it is to fix this.
>
> Since at least 24.1 (recipe does not work as written in 23.x).
> I don't think is at all urgent to fix.
I agree; this is a purely cosmetic issue and just a bit irritating
(also, it only affects those with disabled scrollbars, which I guess
isn't very common).
-David
^ permalink raw reply [flat|nested] 18+ messages in thread
* bug#13723: 24.2.93; Fringe icons corrupt buffer separator line
2013-02-15 20:12 ` Glenn Morris
2013-02-15 20:20 ` David Engster
@ 2013-02-15 20:21 ` Glenn Morris
2013-02-15 20:38 ` Glenn Morris
1 sibling, 1 reply; 18+ messages in thread
From: Glenn Morris @ 2013-02-15 20:21 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 13723, deng
Glenn Morris wrote:
> Since at least 24.1 (recipe does not work as written in 23.x).
Since at least 23.2 GTK with
(progn
(scroll-bar-mode -1)
(setq truncate-partial-width-windows nil)
(toggle-truncate-lines -1)
(with-current-buffer (get-buffer-create "test")
(erase-buffer)
(dotimes (i 100)
(insert (make-string 500 65) "\n")))
(switch-to-buffer "test")
(goto-char (point-max))
(split-window nil nil t)
(other-window 1)
(split-window nil nil t)
(switch-to-buffer "test")
(goto-char (point-min))
(while (not (eobp))
(scroll-up)
(redisplay t)))
^ permalink raw reply [flat|nested] 18+ messages in thread
* bug#13723: 24.2.93; Fringe icons corrupt buffer separator line
2013-02-15 20:21 ` Glenn Morris
@ 2013-02-15 20:38 ` Glenn Morris
0 siblings, 0 replies; 18+ messages in thread
From: Glenn Morris @ 2013-02-15 20:38 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 13723, deng
Seen in 23.2 onwards, but not in 23.1 and earlier, if that tells you
anything.
^ permalink raw reply [flat|nested] 18+ messages in thread
* bug#13723: 24.2.93; Fringe icons corrupt buffer separator line
2013-02-15 19:30 ` Glenn Morris
2013-02-15 19:39 ` David Engster
2013-02-15 19:56 ` Eli Zaretskii
@ 2013-02-16 17:15 ` Jan Djärv
2013-02-16 19:14 ` Eli Zaretskii
2 siblings, 1 reply; 18+ messages in thread
From: Jan Djärv @ 2013-02-16 17:15 UTC (permalink / raw)
To: Glenn Morris; +Cc: 13723, David Engster
Hello.
15 feb 2013 kl. 20:30 skrev Glenn Morris <rgm@gnu.org>:
> Eli Zaretskii wrote:
>
>> Unfortunately, I cannot reproduce this here, neither with stock Emacs
>> 24.2 nor with the current trunk. I get a perfectly drawn border.
>
> I see the issue in emacs-24 and trunk. x86_64 GNU/Linux, Lucid toolkit.
>
I see the issue on trunk, built for NS.
Jan D.
^ permalink raw reply [flat|nested] 18+ messages in thread
* bug#13723: 24.2.93; Fringe icons corrupt buffer separator line
2013-02-16 17:15 ` Jan Djärv
@ 2013-02-16 19:14 ` Eli Zaretskii
2013-02-16 20:47 ` David Engster
2013-02-17 9:59 ` Jan Djärv
0 siblings, 2 replies; 18+ messages in thread
From: Eli Zaretskii @ 2013-02-16 19:14 UTC (permalink / raw)
To: Jan Djärv; +Cc: deng, 13723
> From: Jan Djärv <jan.h.d@swipnet.se>
> Date: Sat, 16 Feb 2013 18:15:36 +0100
> Cc: Eli Zaretskii <eliz@gnu.org>,
> 13723@debbugs.gnu.org,
> David Engster <deng@randomsample.de>
>
> 15 feb 2013 kl. 20:30 skrev Glenn Morris <rgm@gnu.org>:
>
> > Eli Zaretskii wrote:
> >
> >> Unfortunately, I cannot reproduce this here, neither with stock Emacs
> >> 24.2 nor with the current trunk. I get a perfectly drawn border.
> >
> > I see the issue in emacs-24 and trunk. x86_64 GNU/Linux, Lucid toolkit.
> >
>
> I see the issue on trunk, built for NS.
Does the change below solve the problem on GNU/Linux and NS?
=== modified file 'src/xdisp.c'
--- src/xdisp.c 2013-02-15 12:26:42 +0000
+++ src/xdisp.c 2013-02-16 19:11:29 +0000
@@ -28257,8 +28257,8 @@ x_draw_vertical_border (struct window *w
FRAME_RIF (f)->draw_vertical_window_border (w, x1, y0, y1);
}
- else if (!WINDOW_LEFTMOST_P (w)
- && !WINDOW_HAS_VERTICAL_SCROLL_BAR_ON_LEFT (w))
+ if (!WINDOW_LEFTMOST_P (w)
+ && !WINDOW_HAS_VERTICAL_SCROLL_BAR_ON_LEFT (w))
{
int x0, x1, y0, y1;
^ permalink raw reply [flat|nested] 18+ messages in thread
* bug#13723: 24.2.93; Fringe icons corrupt buffer separator line
2013-02-16 19:14 ` Eli Zaretskii
@ 2013-02-16 20:47 ` David Engster
2013-02-16 20:51 ` Eli Zaretskii
2013-02-17 9:59 ` Jan Djärv
1 sibling, 1 reply; 18+ messages in thread
From: David Engster @ 2013-02-16 20:47 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 13723
Eli Zaretskii writes:
>> From: Jan Djärv <jan.h.d@swipnet.se>
>> Date: Sat, 16 Feb 2013 18:15:36 +0100
>> Cc: Eli Zaretskii <eliz@gnu.org>,
>
>> 13723@debbugs.gnu.org,
>> David Engster <deng@randomsample.de>
>>
>> 15 feb 2013 kl. 20:30 skrev Glenn Morris <rgm@gnu.org>:
>>
>> > Eli Zaretskii wrote:
>> >
>> >> Unfortunately, I cannot reproduce this here, neither with stock Emacs
>> >> 24.2 nor with the current trunk. I get a perfectly drawn border.
>> >
>> > I see the issue in emacs-24 and trunk. x86_64 GNU/Linux, Lucid toolkit.
>> >
>>
>> I see the issue on trunk, built for NS.
>
> Does the change below solve the problem on GNU/Linux and NS?
Yes, it does for me on GNU/Linux. Thanks!
-David
^ permalink raw reply [flat|nested] 18+ messages in thread
* bug#13723: 24.2.93; Fringe icons corrupt buffer separator line
2013-02-16 20:47 ` David Engster
@ 2013-02-16 20:51 ` Eli Zaretskii
2013-02-17 0:34 ` Glenn Morris
0 siblings, 1 reply; 18+ messages in thread
From: Eli Zaretskii @ 2013-02-16 20:51 UTC (permalink / raw)
To: David Engster; +Cc: 13723
> From: David Engster <deng@randomsample.de>
> Cc: Jan Djärv <jan.h.d@swipnet.se>,
> 13723@debbugs.gnu.org
> Date: Sat, 16 Feb 2013 21:47:17 +0100
>
> >> > I see the issue in emacs-24 and trunk. x86_64 GNU/Linux, Lucid toolkit.
> >> >
> >>
> >> I see the issue on trunk, built for NS.
> >
> > Does the change below solve the problem on GNU/Linux and NS?
>
> Yes, it does for me on GNU/Linux. Thanks!
Thanks for testing.
Glenn, I'd like to install this on the emacs-24 branch, any
objections? The change looks a no-brainer, and obviously correct.
^ permalink raw reply [flat|nested] 18+ messages in thread
* bug#13723: 24.2.93; Fringe icons corrupt buffer separator line
2013-02-16 20:51 ` Eli Zaretskii
@ 2013-02-17 0:34 ` Glenn Morris
2013-02-17 16:23 ` Eli Zaretskii
0 siblings, 1 reply; 18+ messages in thread
From: Glenn Morris @ 2013-02-17 0:34 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 13723, David Engster
Eli Zaretskii wrote:
> Glenn, I'd like to install this on the emacs-24 branch, any
> objections? The change looks a no-brainer, and obviously correct.
If you want to, go ahead.
^ permalink raw reply [flat|nested] 18+ messages in thread
* bug#13723: 24.2.93; Fringe icons corrupt buffer separator line
2013-02-16 19:14 ` Eli Zaretskii
2013-02-16 20:47 ` David Engster
@ 2013-02-17 9:59 ` Jan Djärv
2013-02-17 16:24 ` Eli Zaretskii
1 sibling, 1 reply; 18+ messages in thread
From: Jan Djärv @ 2013-02-17 9:59 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: deng, 13723
Hello.
16 feb 2013 kl. 20:14 skrev Eli Zaretskii <eliz@gnu.org>:
>> From: Jan Djärv <jan.h.d@swipnet.se>
>> Date: Sat, 16 Feb 2013 18:15:36 +0100
>> Cc: Eli Zaretskii <eliz@gnu.org>,
>> 13723@debbugs.gnu.org,
>> David Engster <deng@randomsample.de>
>>
>> 15 feb 2013 kl. 20:30 skrev Glenn Morris <rgm@gnu.org>:
>>
>>> Eli Zaretskii wrote:
>>>
>>>> Unfortunately, I cannot reproduce this here, neither with stock Emacs
>>>> 24.2 nor with the current trunk. I get a perfectly drawn border.
>>>
>>> I see the issue in emacs-24 and trunk. x86_64 GNU/Linux, Lucid toolkit.
>>>
>>
>> I see the issue on trunk, built for NS.
>
> Does the change below solve the problem on GNU/Linux and NS?
>
> === modified file 'src/xdisp.c'
> --- src/xdisp.c 2013-02-15 12:26:42 +0000
> +++ src/xdisp.c 2013-02-16 19:11:29 +0000
> @@ -28257,8 +28257,8 @@ x_draw_vertical_border (struct window *w
>
> FRAME_RIF (f)->draw_vertical_window_border (w, x1, y0, y1);
> }
> - else if (!WINDOW_LEFTMOST_P (w)
> - && !WINDOW_HAS_VERTICAL_SCROLL_BAR_ON_LEFT (w))
> + if (!WINDOW_LEFTMOST_P (w)
> + && !WINDOW_HAS_VERTICAL_SCROLL_BAR_ON_LEFT (w))
> {
> int x0, x1, y0, y1;
>
Looks fine on NS.
Jan D.
^ permalink raw reply [flat|nested] 18+ messages in thread
* bug#13723: 24.2.93; Fringe icons corrupt buffer separator line
2013-02-17 0:34 ` Glenn Morris
@ 2013-02-17 16:23 ` Eli Zaretskii
0 siblings, 0 replies; 18+ messages in thread
From: Eli Zaretskii @ 2013-02-17 16:23 UTC (permalink / raw)
To: Glenn Morris; +Cc: 13723-done, deng
> From: Glenn Morris <rgm@gnu.org>
> Cc: David Engster <deng@randomsample.de>, 13723@debbugs.gnu.org
> Date: Sat, 16 Feb 2013 19:34:36 -0500
>
> Eli Zaretskii wrote:
>
> > Glenn, I'd like to install this on the emacs-24 branch, any
> > objections? The change looks a no-brainer, and obviously correct.
>
> If you want to, go ahead.
Done in revision 111273 on emacs-24 branch.
Closing.
^ permalink raw reply [flat|nested] 18+ messages in thread
* bug#13723: 24.2.93; Fringe icons corrupt buffer separator line
2013-02-17 9:59 ` Jan Djärv
@ 2013-02-17 16:24 ` Eli Zaretskii
0 siblings, 0 replies; 18+ messages in thread
From: Eli Zaretskii @ 2013-02-17 16:24 UTC (permalink / raw)
To: Jan Djärv; +Cc: deng, 13723
> From: Jan Djärv <jan.h.d@swipnet.se>
> Date: Sun, 17 Feb 2013 10:59:40 +0100
> Cc: rgm@gnu.org,
> 13723@debbugs.gnu.org,
> deng@randomsample.de
>
> Looks fine on NS.
Thanks for testing. I installed the change.
^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2013-02-17 16:24 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-15 17:45 bug#13723: 24.2.93; Fringe icons corrupt buffer separator line David Engster
2013-02-15 19:23 ` Eli Zaretskii
2013-02-15 19:30 ` Glenn Morris
2013-02-15 19:39 ` David Engster
2013-02-15 19:57 ` Eli Zaretskii
2013-02-15 19:56 ` Eli Zaretskii
2013-02-15 20:12 ` Glenn Morris
2013-02-15 20:20 ` David Engster
2013-02-15 20:21 ` Glenn Morris
2013-02-15 20:38 ` Glenn Morris
2013-02-16 17:15 ` Jan Djärv
2013-02-16 19:14 ` Eli Zaretskii
2013-02-16 20:47 ` David Engster
2013-02-16 20:51 ` Eli Zaretskii
2013-02-17 0:34 ` Glenn Morris
2013-02-17 16:23 ` Eli Zaretskii
2013-02-17 9:59 ` Jan Djärv
2013-02-17 16:24 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).