unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#27927: 25.2; Doc string of `region-extract-function'
@ 2017-08-02 22:46 Drew Adams
  2017-08-05  8:05 ` Eli Zaretskii
  0 siblings, 1 reply; 2+ messages in thread
From: Drew Adams @ 2017-08-02 22:46 UTC (permalink / raw)
  To: 27927

This doc string now reads a bit like a kludge was added to what was
there before.  There is nothing that should now favor the meaning of the
argument as "delete".  The parameter should be renamed from DELETE to
just ACTION or ARG (or something else).

"If DELETE is `delete-only'...
 If DELETE is nil...
 If DELETE is `bounds', then don't delete, but..."

Change that to something like

"If ACTION is `delete-only'...
 If ACTION is nil...
 If ACTION is `bounds'...

In GNU Emacs 25.2.1 (x86_64-w64-mingw32)
 of 2017-04-24 built on LAPHROAIG
Windowing system distributor 'Microsoft Corp.', version 6.1.7601
Configured using:
 'configure --without-dbus --without-compress-install 'CFLAGS=-O2
 -static -g3''





^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#27927: 25.2; Doc string of `region-extract-function'
  2017-08-02 22:46 bug#27927: 25.2; Doc string of `region-extract-function' Drew Adams
@ 2017-08-05  8:05 ` Eli Zaretskii
  0 siblings, 0 replies; 2+ messages in thread
From: Eli Zaretskii @ 2017-08-05  8:05 UTC (permalink / raw)
  To: Drew Adams; +Cc: 27927-done

> Date: Wed, 2 Aug 2017 15:46:15 -0700 (PDT)
> From: Drew Adams <drew.adams@oracle.com>
> 
> This doc string now reads a bit like a kludge was added to what was
> there before.  There is nothing that should now favor the meaning of the
> argument as "delete".

Actually, there is: the call to filter-buffer-substring.  But I don't
think that's strong enough, so I fixed the doc string.

Thanks.





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-08-05  8:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-02 22:46 bug#27927: 25.2; Doc string of `region-extract-function' Drew Adams
2017-08-05  8:05 ` Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).