From: Eli Zaretskii <eliz@gnu.org>
To: Imran Khan <contact@imrankhan.live>
Cc: 48734@debbugs.gnu.org
Subject: bug#48734: 28.0.50; Performance regression in `string-width`?
Date: Sun, 30 May 2021 13:00:32 +0300 [thread overview]
Message-ID: <83eedo4k3j.fsf@gnu.org> (raw)
In-Reply-To: <87y2bwk1nj.fsf@teknik.io> (message from Imran Khan on Sun, 30 May 2021 15:32:16 +0600)
> From: Imran Khan <contact@imrankhan.live>
> Date: Sun, 30 May 2021 15:32:16 +0600
>
> > Since you use insert-file-contents-literally, why don't you also make
> > the temporary buffer unibyte? That is:
> >
> > (benchmark-run 1
> > (let ((str))
> > (with-temp-buffer
> > (set-buffer-multibyte nil) ; <<<<<<<<<<<<<<<<<<<<<<<<<<<<<
> > (insert-file-contents-literally "/tmp/test")
> > (setq str (buffer-string)))
> > (string-width str)))
> >
> > Or maybe I don't understand your real-life use case? Because if you
> > treat the file as a raw bytestream, why do you need to compute the
> > width of its text?
>
> I would agree, my example was pointlessly contrived. For what it's
> worth, `insert-file-contents` exhibits same poor performance, and that's
> used by code in the wild (e.g. deft-mode, though I am sceptical if they
> should be needing to call `string-width` on entire buffer text either).
>
> Personally I am now going to use your `(set-buffer-multibyte nil)`
> suggestion to patch their code for myself (so thanks for this). Since
> I have no idea about the internal complexity of `string-width` or what
> should be justified performance expectation, I would let you decide if
> this is a bug or not.
I'm not yet sure whether this is a real problem, because I don't
really understand the relation between your example code and what you
really need to do in deft-mode. Specifically, generating random
characters isn't something that usually happens in real life.
So could you perhaps explain what you are using string-width for in
deft-mode, and what kind of text are you measuring there in your
real-life situations?
Thanks.
P.S. Please use Reply All to keep the bug address on the CC list.
next prev parent reply other threads:[~2021-05-30 10:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-29 20:45 bug#48734: 28.0.50; Performance regression in `string-width`? Imran Khan
2021-05-30 6:42 ` Eli Zaretskii
[not found] ` <87y2bwk1nj.fsf@teknik.io>
2021-05-30 10:00 ` Eli Zaretskii [this message]
2021-05-30 11:23 ` Imran Khan
2021-05-30 12:05 ` Eli Zaretskii
2021-05-30 12:18 ` Lars Ingebrigtsen
2021-05-30 13:32 ` Eli Zaretskii
2021-05-31 5:41 ` Lars Ingebrigtsen
2021-05-31 12:36 ` Imran Khan
2021-05-31 14:28 ` Eli Zaretskii
2021-05-31 18:51 ` Eli Zaretskii
2021-06-05 11:20 ` Eli Zaretskii
2021-06-05 15:25 ` Imran Khan
2021-06-05 15:45 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83eedo4k3j.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=48734@debbugs.gnu.org \
--cc=contact@imrankhan.live \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).