unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Imran Khan <contact@imrankhan.live>
Cc: 48734@debbugs.gnu.org
Subject: bug#48734: 28.0.50; Performance regression in `string-width`?
Date: Sun, 30 May 2021 15:05:52 +0300	[thread overview]
Message-ID: <835yz04ean.fsf@gnu.org> (raw)
In-Reply-To: <87v970jwik.fsf@teknik.io> (message from Imran Khan on Sun, 30 May 2021 17:23:15 +0600)

> From: Imran Khan <contact@imrankhan.live>
> Cc: 48734@debbugs.gnu.org
> Date: Sun, 30 May 2021 17:23:15 +0600
> 
> Basically deft-mode takes a folder full of normal org-mode files, and
> constructs a pretty "dashboard" view of the folder where you can browse,
> search, filter the files in said folder (and many other features).
> 
> The dashboard UI uses `string-width` to calculate how much space is to
> be allocated relative to window width to display metadata like file
> title, file content summary, mtime etc for each file per line. This is
> dynamic, the components size adjusts to window width change. Perhaps the
> screenshot they have in their project page would be more descriptive:
> 
> https://github.com/jrblevin/deft
> 
> Org-mode files typically have unicode chars in them. So when deft-mode
> uses `string-width` to construct view of file content part, it
> hangs. I think the performance problem here is exacerbated because
> deft-mode is stripping all vertical whitespace to squash the content to
> show in a single line summary view, before calling `string-width`.

If deft-mode wants to allocate space on display, then they really do
need to use string-width, but then the changes which make them "hang"
are really important, because before that string-width would compute
the result incorrectly when characters are composed on display.





  reply	other threads:[~2021-05-30 12:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-29 20:45 bug#48734: 28.0.50; Performance regression in `string-width`? Imran Khan
2021-05-30  6:42 ` Eli Zaretskii
     [not found]   ` <87y2bwk1nj.fsf@teknik.io>
2021-05-30 10:00     ` Eli Zaretskii
2021-05-30 11:23       ` Imran Khan
2021-05-30 12:05         ` Eli Zaretskii [this message]
2021-05-30 12:18           ` Lars Ingebrigtsen
2021-05-30 13:32             ` Eli Zaretskii
2021-05-31  5:41               ` Lars Ingebrigtsen
2021-05-31 12:36                 ` Imran Khan
2021-05-31 14:28                   ` Eli Zaretskii
2021-05-31 18:51                     ` Eli Zaretskii
2021-06-05 11:20                       ` Eli Zaretskii
2021-06-05 15:25                         ` Imran Khan
2021-06-05 15:45                           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=835yz04ean.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=48734@debbugs.gnu.org \
    --cc=contact@imrankhan.live \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).