* bug#63880: 29.0.91; typescript-ts-mode fails to highlight infer keyword
@ 2023-06-03 23:57 Jimmy Yuen Ho Wong
2023-06-04 5:09 ` Eli Zaretskii
0 siblings, 1 reply; 6+ messages in thread
From: Jimmy Yuen Ho Wong @ 2023-06-03 23:57 UTC (permalink / raw)
To: 63880
Reproduction:
1. echo 'type Flatten<Type> = Type extends Array<infer Item> ? Item :
Type;' > test.ts
2. C-x C-f test.ts
3. M-x typescript-ts-mode
4. Observe the infer keyword is not highlighted
Expectation:
Typescript has an
[`infer`](https://www.typescriptlang.org/docs/handbook/2/conditional-types.html#inferring-within-conditional-types)
keyword, it should be highlighted.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#63880: 29.0.91; typescript-ts-mode fails to highlight infer keyword
2023-06-03 23:57 bug#63880: 29.0.91; typescript-ts-mode fails to highlight infer keyword Jimmy Yuen Ho Wong
@ 2023-06-04 5:09 ` Eli Zaretskii
2023-06-04 8:11 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2023-06-04 5:09 UTC (permalink / raw)
To: Jimmy Yuen Ho Wong, Jostein Kjonigsen, Theodor Thornhill, Yuan Fu; +Cc: 63880
> From: Jimmy Yuen Ho Wong <wyuenho@gmail.com>
> Date: Sun, 04 Jun 2023 00:57:19 +0100
>
>
> Reproduction:
>
> 1. echo 'type Flatten<Type> = Type extends Array<infer Item> ? Item :
> Type;' > test.ts
> 2. C-x C-f test.ts
> 3. M-x typescript-ts-mode
> 4. Observe the infer keyword is not highlighted
>
> Expectation:
>
> Typescript has an
> [`infer`](https://www.typescriptlang.org/docs/handbook/2/conditional-types.html#inferring-within-conditional-types)
> keyword, it should be highlighted.
Thanks. CC'ing the relevant developers.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#63880: 29.0.91; typescript-ts-mode fails to highlight infer keyword
2023-06-04 5:09 ` Eli Zaretskii
@ 2023-06-04 8:11 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-06 4:28 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 1 reply; 6+ messages in thread
From: Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-06-04 8:11 UTC (permalink / raw)
To: Eli Zaretskii, Jimmy Yuen Ho Wong, Jostein Kjonigsen, Yuan Fu; +Cc: 63880
On 4 June 2023 07:09:28 CEST, Eli Zaretskii <eliz@gnu.org> wrote:
>> From: Jimmy Yuen Ho Wong <wyuenho@gmail.com>
>> Date: Sun, 04 Jun 2023 00:57:19 +0100
>>
>>
>> Reproduction:
>>
>> 1. echo 'type Flatten<Type> = Type extends Array<infer Item> ? Item :
>> Type;' > test.ts
>> 2. C-x C-f test.ts
>> 3. M-x typescript-ts-mode
>> 4. Observe the infer keyword is not highlighted
>>
>> Expectation:
>>
>> Typescript has an
>> [`infer`](https://www.typescriptlang.org/docs/handbook/2/conditional-types.html#inferring-within-conditional-types)
>> keyword, it should be highlighted.
>
>Thanks. CC'ing the relevant developers.
Thanks, I'll look at it :)
I'll try to follow the bugtracker a little more closely going forwards. Apologies for the absence :)
Theo
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#63880: 29.0.91; typescript-ts-mode fails to highlight infer keyword
2023-06-04 8:11 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-06-06 4:28 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-06 11:51 ` Eli Zaretskii
0 siblings, 1 reply; 6+ messages in thread
From: Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-06-06 4:28 UTC (permalink / raw)
To: Eli Zaretskii, Jimmy Yuen Ho Wong, Jostein Kjonigsen, Yuan Fu; +Cc: 63880
Theodor Thornhill <theo@thornhill.no> writes:
> On 4 June 2023 07:09:28 CEST, Eli Zaretskii <eliz@gnu.org> wrote:
>>> From: Jimmy Yuen Ho Wong <wyuenho@gmail.com>
>>> Date: Sun, 04 Jun 2023 00:57:19 +0100
>>>
>>>
>>> Reproduction:
>>>
>>> 1. echo 'type Flatten<Type> = Type extends Array<infer Item> ? Item :
>>> Type;' > test.ts
>>> 2. C-x C-f test.ts
>>> 3. M-x typescript-ts-mode
>>> 4. Observe the infer keyword is not highlighted
>>>
>>> Expectation:
>>>
>>> Typescript has an
>>> [`infer`](https://www.typescriptlang.org/docs/handbook/2/conditional-types.html#inferring-within-conditional-types)
>>> keyword, it should be highlighted.
>>
>>Thanks. CC'ing the relevant developers.
>
>
> Thanks, I'll look at it :)
>
> I'll try to follow the bugtracker a little more closely going forwards. Apologies for the absence :)
>
> Theo
Now fixed in emacs-29.
Thanks for the report.
Theo
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#63880: 29.0.91; typescript-ts-mode fails to highlight infer keyword
2023-06-06 4:28 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-06-06 11:51 ` Eli Zaretskii
2023-06-08 9:28 ` Eli Zaretskii
0 siblings, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2023-06-06 11:51 UTC (permalink / raw)
To: Theodor Thornhill; +Cc: 63880, casouri, jostein, wyuenho
> From: Theodor Thornhill <theo@thornhill.no>
> Cc: 63880@debbugs.gnu.org
> Date: Tue, 06 Jun 2023 06:28:03 +0200
>
> Now fixed in emacs-29.
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#63880: 29.0.91; typescript-ts-mode fails to highlight infer keyword
2023-06-06 11:51 ` Eli Zaretskii
@ 2023-06-08 9:28 ` Eli Zaretskii
0 siblings, 0 replies; 6+ messages in thread
From: Eli Zaretskii @ 2023-06-08 9:28 UTC (permalink / raw)
To: theo; +Cc: jostein, casouri, 63880-done, wyuenho
> Cc: 63880@debbugs.gnu.org, casouri@gmail.com, jostein@kjonigsen.net,
> wyuenho@gmail.com
> Date: Tue, 06 Jun 2023 14:51:33 +0300
> From: Eli Zaretskii <eliz@gnu.org>
>
> > From: Theodor Thornhill <theo@thornhill.no>
> > Cc: 63880@debbugs.gnu.org
> > Date: Tue, 06 Jun 2023 06:28:03 +0200
> >
> > Now fixed in emacs-29.
>
> Thanks.
No further comments, so I'm closing this bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-06-08 9:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-03 23:57 bug#63880: 29.0.91; typescript-ts-mode fails to highlight infer keyword Jimmy Yuen Ho Wong
2023-06-04 5:09 ` Eli Zaretskii
2023-06-04 8:11 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-06 4:28 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-06 11:51 ` Eli Zaretskii
2023-06-08 9:28 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).