unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#30077: 27.0.50; print-quoted should default to t
@ 2018-01-11 16:31 Stefan Monnier
  2018-01-11 16:44 ` Robert Pluim
  2018-01-11 17:53 ` Eli Zaretskii
  0 siblings, 2 replies; 4+ messages in thread
From: Stefan Monnier @ 2018-01-11 16:31 UTC (permalink / raw)
  To: 30077

Package: Emacs
Version: 27.0.50


I was reviewing some of my local patches and noticed that I tend to
let-bind print-quoted to t everywhere, and it occurred to me that
instead we should simply change the default.  I can't remember
a circumstance where I needed print-quoted to be nil (tho I wouldn't be
surprised if this patch ends up finding such a circumstance).

I suggest the patch below (for master, obviously).


        Stefan


diff --git a/src/print.c b/src/print.c
index 2c5cf108aa..b9d556c17c 100644
--- a/src/print.c
+++ b/src/print.c
@@ -2424,7 +2424,7 @@ This affects only `prin1'.  */);
   DEFVAR_BOOL ("print-quoted", print_quoted,
 	       doc: /* Non-nil means print quoted forms with reader syntax.
 I.e., (quote foo) prints as \\='foo, (function foo) as #\\='foo.  */);
-  print_quoted = 0;
+  print_quoted = true;
 
   DEFVAR_LISP ("print-gensym", Vprint_gensym,
 	       doc: /* Non-nil means print uninterned symbols so they will read as uninterned.





^ permalink raw reply related	[flat|nested] 4+ messages in thread

* bug#30077: 27.0.50; print-quoted should default to t
  2018-01-11 16:31 bug#30077: 27.0.50; print-quoted should default to t Stefan Monnier
@ 2018-01-11 16:44 ` Robert Pluim
  2018-01-11 17:53 ` Eli Zaretskii
  1 sibling, 0 replies; 4+ messages in thread
From: Robert Pluim @ 2018-01-11 16:44 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: 30077

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

> Package: Emacs
> Version: 27.0.50
>
>
> I was reviewing some of my local patches and noticed that I tend to
> let-bind print-quoted to t everywhere, and it occurred to me that
> instead we should simply change the default.  I can't remember
> a circumstance where I needed print-quoted to be nil (tho I wouldn't be
> surprised if this patch ends up finding such a circumstance).
>
> I suggest the patch below (for master, obviously).

Aagh, my customize settings changed!

But that doesn't break anything as far as I can see.

+1 from me

Robert





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#30077: 27.0.50; print-quoted should default to t
  2018-01-11 16:31 bug#30077: 27.0.50; print-quoted should default to t Stefan Monnier
  2018-01-11 16:44 ` Robert Pluim
@ 2018-01-11 17:53 ` Eli Zaretskii
  2018-01-15 18:43   ` Stefan Monnier
  1 sibling, 1 reply; 4+ messages in thread
From: Eli Zaretskii @ 2018-01-11 17:53 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: 30077

> From: Stefan Monnier <monnier@IRO.UMontreal.CA>
> Date: Thu, 11 Jan 2018 11:31:09 -0500
> 
> I suggest the patch below (for master, obviously).
> 
> 
>         Stefan
> 
> 
> diff --git a/src/print.c b/src/print.c
> index 2c5cf108aa..b9d556c17c 100644
> --- a/src/print.c
> +++ b/src/print.c
> @@ -2424,7 +2424,7 @@ This affects only `prin1'.  */);
>    DEFVAR_BOOL ("print-quoted", print_quoted,
>  	       doc: /* Non-nil means print quoted forms with reader syntax.
>  I.e., (quote foo) prints as \\='foo, (function foo) as #\\='foo.  */);
> -  print_quoted = 0;
> +  print_quoted = true;
>  
>    DEFVAR_LISP ("print-gensym", Vprint_gensym,
>  	       doc: /* Non-nil means print uninterned symbols so they will read as uninterned.

I have no opinion about the change, but if this is installed, please
mention the change in NEWS.

Thanks.





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#30077: 27.0.50; print-quoted should default to t
  2018-01-11 17:53 ` Eli Zaretskii
@ 2018-01-15 18:43   ` Stefan Monnier
  0 siblings, 0 replies; 4+ messages in thread
From: Stefan Monnier @ 2018-01-15 18:43 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 30077-done

> I have no opinion about the change, but if this is installed, please
> mention the change in NEWS.

Done,


        Stefan





^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-01-15 18:43 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-11 16:31 bug#30077: 27.0.50; print-quoted should default to t Stefan Monnier
2018-01-11 16:44 ` Robert Pluim
2018-01-11 17:53 ` Eli Zaretskii
2018-01-15 18:43   ` Stefan Monnier

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).