unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: 60999@debbugs.gnu.org
Subject: bug#60999: 30.0.50; [PATCH] Add support for negative indices and index ranges in Eshell
Date: Fri, 27 Jan 2023 09:38:11 +0200	[thread overview]
Message-ID: <83cz70ctr0.fsf@gnu.org> (raw)
In-Reply-To: <3de45afd-c721-9b3a-ff97-5e6dc8d0c390@gmail.com> (message from Jim Porter on Thu, 26 Jan 2023 17:23:19 -0800)

> Date: Thu, 26 Jan 2023 17:23:19 -0800
> From: Jim Porter <jporterbugs@gmail.com>
> Cc: 60999@debbugs.gnu.org
> 
> On 1/22/2023 12:13 AM, Jim Porter wrote:
> > Either way we decide about 'eshell-number-regexp', I can turn 
> > 'eshell-integer-regexp' into a regular defvar. (The only thing I can 
> > think of that a person would customize it to would be to allow a "+" at 
> > the start of an integer, like "+123".)
> 
> Ok, I've updated my patch to that 'eshell-integer-regexp' is just a 
> regular defvar. In the second patch, I also converted 
> 'eshell-number-regexp' to a defvar, and improved the regexp to match 
> more valid numbers. I think with those improvements, there's no real 
> reason for 'eshell-number-regexp' to be customizable anymore.

Thanks.

> Note: I haven't done anything with the range syntax though. If you feel 
> strongly that it should be a closed range like in Bash (instead of 
> half-open like it is in the current patch), then I don't mind changing 
> it. Personally though, I have a soft preference for half-open since it's 
> more consistent with the rest of Emacs Lisp.

I have no strong feelings, as I don't expect to be using this feature.
I just think this could be confusing to people who do use it in other
shells, and a potential source of complaints and bug reports.  But it
is your call.





  reply	other threads:[~2023-01-27  7:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-22  3:47 bug#60999: 30.0.50; [PATCH] Add support for negative indices and index ranges in Eshell Jim Porter
2023-01-22  6:29 ` Eli Zaretskii
2023-01-22  8:13   ` Jim Porter
2023-01-27  1:23     ` Jim Porter
2023-01-27  7:38       ` Eli Zaretskii [this message]
2023-01-27 18:02         ` Jim Porter
2023-01-27 18:57           ` Eli Zaretskii
2023-01-28  2:15             ` Jim Porter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83cz70ctr0.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=60999@debbugs.gnu.org \
    --cc=jporterbugs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).