From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60999: 30.0.50; [PATCH] Add support for negative indices and index ranges in Eshell Date: Fri, 27 Jan 2023 09:38:11 +0200 Message-ID: <83cz70ctr0.fsf@gnu.org> References: <83zgabjd4v.fsf@gnu.org> <3de45afd-c721-9b3a-ff97-5e6dc8d0c390@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32196"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60999@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 27 08:39:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pLJKU-0008Cb-MN for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 27 Jan 2023 08:39:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pLJKD-0004Ij-MA; Fri, 27 Jan 2023 02:39:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLJKB-0004IT-M8 for bug-gnu-emacs@gnu.org; Fri, 27 Jan 2023 02:39:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pLJKA-0005qY-Pa for bug-gnu-emacs@gnu.org; Fri, 27 Jan 2023 02:39:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pLJKA-0005Lb-AT for bug-gnu-emacs@gnu.org; Fri, 27 Jan 2023 02:39:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 27 Jan 2023 07:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60999 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60999-submit@debbugs.gnu.org id=B60999.167480511420502 (code B ref 60999); Fri, 27 Jan 2023 07:39:02 +0000 Original-Received: (at 60999) by debbugs.gnu.org; 27 Jan 2023 07:38:34 +0000 Original-Received: from localhost ([127.0.0.1]:36631 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLJJi-0005Kb-08 for submit@debbugs.gnu.org; Fri, 27 Jan 2023 02:38:34 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33134) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLJJg-0005KP-8i for 60999@debbugs.gnu.org; Fri, 27 Jan 2023 02:38:32 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLJJa-0005nB-RC; Fri, 27 Jan 2023 02:38:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=CyMgd6j9qwsM+m1hmJcckzrgIAG6yoiA5CWTY47x+qI=; b=i7YlC+yR3Puz f2hXy15yNDRHJNLp3XNd4u+bkZRgOwJ/sGGz4u5EzPVSMvMSY8A2ZZd48cVukQyqS7SzjUgOshD4L dpNYJF4ijBany1FVhrcvUgfDuXi3a12vFm4P5Nov1J9BwssCamx4Gb2NIykcCqOtYHHDOmJqYXOXj zi/3YgBYDHZjfpnCgn2tpWrybXDDe89pdMNIM2dgzIME1dGAvG06vQRsOpcr1ejlnmfllmDIorv8e IBZUBpyRrm8412Fp+A75C8SvAzx3odEJk4i9vKfq+h3905EEz5NlpqrReSxPZ0a442MzVmab0InRV ZC6oI9LKRpWNQ1bM0zGFZg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLJJa-0001d2-16; Fri, 27 Jan 2023 02:38:26 -0500 In-Reply-To: <3de45afd-c721-9b3a-ff97-5e6dc8d0c390@gmail.com> (message from Jim Porter on Thu, 26 Jan 2023 17:23:19 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254245 Archived-At: > Date: Thu, 26 Jan 2023 17:23:19 -0800 > From: Jim Porter > Cc: 60999@debbugs.gnu.org > > On 1/22/2023 12:13 AM, Jim Porter wrote: > > Either way we decide about 'eshell-number-regexp', I can turn > > 'eshell-integer-regexp' into a regular defvar. (The only thing I can > > think of that a person would customize it to would be to allow a "+" at > > the start of an integer, like "+123".) > > Ok, I've updated my patch to that 'eshell-integer-regexp' is just a > regular defvar. In the second patch, I also converted > 'eshell-number-regexp' to a defvar, and improved the regexp to match > more valid numbers. I think with those improvements, there's no real > reason for 'eshell-number-regexp' to be customizable anymore. Thanks. > Note: I haven't done anything with the range syntax though. If you feel > strongly that it should be a closed range like in Bash (instead of > half-open like it is in the current patch), then I don't mind changing > it. Personally though, I have a soft preference for half-open since it's > more consistent with the rest of Emacs Lisp. I have no strong feelings, as I don't expect to be using this feature. I just think this could be confusing to people who do use it in other shells, and a potential source of complaints and bug reports. But it is your call.