unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#61819: The CVE-2022-48337 fix seems to introduce a memory leak
@ 2023-02-26 10:40 Adrian Bunk
  2023-02-26 18:04 ` Eli Zaretskii
  0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2023-02-26 10:40 UTC (permalink / raw)
  To: 61819

In the upstream bug for CVE-2022-48337 there was originally[1]
+          free (new_real_name);
+          free (new_tmp_name);
in the fix that later disappeared (by accident?).

This seems to introduce a memory leak, this memory allocated
by escape_shell_arg_string() is now never freed.

cu
Adrian

[1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59817#23





^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#61819: The CVE-2022-48337 fix seems to introduce a memory leak
  2023-02-26 10:40 bug#61819: The CVE-2022-48337 fix seems to introduce a memory leak Adrian Bunk
@ 2023-02-26 18:04 ` Eli Zaretskii
  0 siblings, 0 replies; 2+ messages in thread
From: Eli Zaretskii @ 2023-02-26 18:04 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: 61819-done

> Date: Sun, 26 Feb 2023 12:40:45 +0200
> From: Adrian Bunk <bunk@debian.org>
> 
> In the upstream bug for CVE-2022-48337 there was originally[1]
> +          free (new_real_name);
> +          free (new_tmp_name);
> in the fix that later disappeared (by accident?).
> 
> This seems to introduce a memory leak, this memory allocated
> by escape_shell_arg_string() is now never freed.

Thanks, fixed.





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-02-26 18:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-26 10:40 bug#61819: The CVE-2022-48337 fix seems to introduce a memory leak Adrian Bunk
2023-02-26 18:04 ` Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).