From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 13419@debbugs.gnu.org
Subject: bug#13419: make 'eabs' act more like a function
Date: Sat, 12 Jan 2013 11:11:28 +0200 [thread overview]
Message-ID: <83bocuu5of.fsf@gnu.org> (raw)
In-Reply-To: <50F10643.8000408@cs.ucla.edu>
> Date: Fri, 11 Jan 2013 22:44:19 -0800
> From: Paul Eggert <eggert@cs.ucla.edu>
>
> The key part of this patch is to lisp.h; most of the rest
> is pulled in from gnulib automatically. I'm guessing about
> the change to nt/inc/inttypes.h, as I don't use Windows.
Thanks. The change to nt/inc/inttypes.h should be OK for the MS
compiler, I think, with one gotcha:
> +#define imaxabs labs
This should be just "abs". There's no 'labs' in the MS compiler,
according to the MS documentation, and 'long' is 32-bit wide, so 'abs'
is fine. The _abs64 definition for the 64-bit build is OK, AFAIU.
Given these macros, the Windows build doesn't need lib/imaxabs.c,
right (since MinGW defines imaxabs in its inttypes.h)? Because if it
does, lib/makefile.w32-in needs a suitable change.
next prev parent reply other threads:[~2013-01-12 9:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-12 6:44 bug#13419: make 'eabs' act more like a function Paul Eggert
2013-01-12 9:11 ` Eli Zaretskii [this message]
2013-01-12 13:25 ` Stefan Monnier
2013-01-12 23:06 ` Paul Eggert
2013-01-13 0:26 ` Stefan Monnier
2013-01-13 1:41 ` Paul Eggert
2013-01-19 22:36 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83bocuu5of.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=13419@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).