From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#13419: make 'eabs' act more like a function Date: Sat, 12 Jan 2013 11:11:28 +0200 Message-ID: <83bocuu5of.fsf@gnu.org> References: <50F10643.8000408@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1357985908 16317 80.91.229.3 (12 Jan 2013 10:18:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 12 Jan 2013 10:18:28 +0000 (UTC) Cc: 13419@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 12 11:18:45 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TtyAn-0002yR-6f for geb-bug-gnu-emacs@m.gmane.org; Sat, 12 Jan 2013 11:18:45 +0100 Original-Received: from localhost ([::1]:36224 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtyAW-0008Fq-W0 for geb-bug-gnu-emacs@m.gmane.org; Sat, 12 Jan 2013 05:18:28 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:56826) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtyAH-0007mm-MH for bug-gnu-emacs@gnu.org; Sat, 12 Jan 2013 05:18:26 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ttx82-0002eZ-VV for bug-gnu-emacs@gnu.org; Sat, 12 Jan 2013 04:12:01 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:50765) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ttx82-0002eV-RV for bug-gnu-emacs@gnu.org; Sat, 12 Jan 2013 04:11:50 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Ttx8D-0007iL-VQ for bug-gnu-emacs@gnu.org; Sat, 12 Jan 2013 04:12:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 Jan 2013 09:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13419 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 13419-submit@debbugs.gnu.org id=B13419.135798190929633 (code B ref 13419); Sat, 12 Jan 2013 09:12:01 +0000 Original-Received: (at 13419) by debbugs.gnu.org; 12 Jan 2013 09:11:49 +0000 Original-Received: from localhost ([127.0.0.1]:56229 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ttx80-0007ht-TW for submit@debbugs.gnu.org; Sat, 12 Jan 2013 04:11:49 -0500 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:54512) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ttx7y-0007hg-GQ for 13419@debbugs.gnu.org; Sat, 12 Jan 2013 04:11:47 -0500 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MGI00J009I5BM00@a-mtaout20.012.net.il> for 13419@debbugs.gnu.org; Sat, 12 Jan 2013 11:11:05 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MGI00IS09IHZ180@a-mtaout20.012.net.il>; Sat, 12 Jan 2013 11:11:05 +0200 (IST) In-reply-to: <50F10643.8000408@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:69646 Archived-At: > Date: Fri, 11 Jan 2013 22:44:19 -0800 > From: Paul Eggert > > The key part of this patch is to lisp.h; most of the rest > is pulled in from gnulib automatically. I'm guessing about > the change to nt/inc/inttypes.h, as I don't use Windows. Thanks. The change to nt/inc/inttypes.h should be OK for the MS compiler, I think, with one gotcha: > +#define imaxabs labs This should be just "abs". There's no 'labs' in the MS compiler, according to the MS documentation, and 'long' is 32-bit wide, so 'abs' is fine. The _abs64 definition for the 64-bit build is OK, AFAIU. Given these macros, the Windows build doesn't need lib/imaxabs.c, right (since MinGW defines imaxabs in its inttypes.h)? Because if it does, lib/makefile.w32-in needs a suitable change.