bug#25067: Emacs pretest 25.1.90 - ipython completion

bug#25067: Emacs pretest 25.1.90 - ipython completion

[Edward Flanigan]

[-- Attachment #1: Type: text/plain, Size: 441 bytes --]

The ipython shell no longer recognizes my company popup on import


Python 3.5.2 |Anaconda 4.2.0 (64-bit)| (default, Jul  2 2016, 17:53:06)

IPython 5.1.0 -- An enhanced Interactive Python.


import num    will trigger completions in Emacs 25.1.1 but not Emacs 25.1.90.1




Once I import a module everything works fine in both versions

import numpy as np

np.ara      # I get popup completion for both versions of Emacs.

[-- Attachment #2: Type: text/html, Size: 994 bytes --]

bug#25067: Acknowledgement (Emacs pretest 25.1.90 - ipython completion)

[Edward Flanigan]

[-- Attachment #1: Type: text/plain, Size: 225 bytes --]

I'm not sure if this is related but also in ipython.

I don't get tab completion when I try to use 'run'.


> run afile.py


afile.py is in the working directory and completes properly in emacs 25.1 but not 25.1.9.1

[-- Attachment #2: Type: text/html, Size: 720 bytes --]

bug#25067: Acknowledgement (Emacs pretest 25.1.90 - ipython completion)

[Noam Postavsky]

On Tue, Nov 29, 2016 at 4:12 PM, Edward Flanigan
<eflanigan00@hotmail.com> wrote:
> I'm not sure if this is related but also in ipython.
>
> I don't get tab completion when I try to use 'run'.
>
>
>> run afile.py
>
>
> afile.py is in the working directory and completes properly in emacs 25.1
> but not 25.1.9.1

This looks related to #24401.

bug#25067: Acknowledgement (Emacs pretest 25.1.90 - ipython completion)

[Eli Zaretskii]

> From: Noam Postavsky <npostavs@users.sourceforge.net>
> Date: Tue, 29 Nov 2016 18:02:40 -0500
> Cc: "25067@debbugs.gnu.org" <25067@debbugs.gnu.org>
> 
> On Tue, Nov 29, 2016 at 4:12 PM, Edward Flanigan
> <eflanigan00@hotmail.com> wrote:
> > I'm not sure if this is related but also in ipython.
> >
> > I don't get tab completion when I try to use 'run'.
> >
> >
> >> run afile.py
> >
> >
> > afile.py is in the working directory and completes properly in emacs 25.1
> > but not 25.1.9.1
> 
> This looks related to #24401.

Clément, could you please look into this?  I'd like to fix this for
Emacs 25.2.

Thanks.

bug#25067: Acknowledgement (Emacs pretest 25.1.90 - ipython completion)

[Clément Pit--Claudel]

[-- Attachment #1.1: Type: text/plain, Size: 755 bytes --]

On 2016-12-18 10:23, Eli Zaretskii wrote:
>> From: Noam Postavsky <npostavs@users.sourceforge.net>
>> Date: Tue, 29 Nov 2016 18:02:40 -0500
>> Cc: "25067@debbugs.gnu.org" <25067@debbugs.gnu.org>
>>
>> On Tue, Nov 29, 2016 at 4:12 PM, Edward Flanigan
>> <eflanigan00@hotmail.com> wrote:
>>> I'm not sure if this is related but also in ipython.
>>>
>>> I don't get tab completion when I try to use 'run'.
> 
> Clément, could you please look into this?  I'd like to fix this for
> Emacs 25.2.

Sure.

Edward, can you clarify which settings you're using? A recipe starting from emacs -Q would be ideal.
(IPython doesn't seem to work at all for me in Emacs; it was broken by 227e996946d4629fa8f6d665564a37668290c87f)

Cheers,
Clément.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

bug#25067: Acknowledgement (Emacs pretest 25.1.90 - ipython completion)

[Eli Zaretskii]

> Cc: eflanigan00@hotmail.com, 25067@debbugs.gnu.org
> From: Clément Pit--Claudel <clement.pit@gmail.com>
> Date: Sun, 18 Dec 2016 11:16:50 -0500
> 
> > Clément, could you please look into this?  I'd like to fix this for
> > Emacs 25.2.
> 
> Sure.

Thanks.

> (IPython doesn't seem to work at all for me in Emacs; it was broken by 227e996946d4629fa8f6d665564a37668290c87f)

Is there a bug report about that?

bug#25067: Acknowledgement (Emacs pretest 25.1.90 - ipython completion)

[Clément Pit--Claudel]

[-- Attachment #1.1: Type: text/plain, Size: 248 bytes --]

On 2016-12-18 12:01, Eli Zaretskii wrote:
>> (IPython doesn't seem to work at all for me in Emacs; it was broken by 227e996946d4629fa8f6d665564a37668290c87f)
> 
> Is there a bug report about that?

I just created one (#25222).

Clément.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

bug#25067: #25067 Emacs pretest 25.1.91 - ipython completion

[Edward Flanigan]

[-- Attachment #1: Type: text/plain, Size: 650 bytes --]

Python 3.5.2 |Anaconda 4.2.0 (64-bit)| (default, Jul  2 2016, 17:53:06)
IPython 5.1.0 -- An enhanced Interactive Python.


Recipe is the following:


emacs -q


eval-region on this:


(setq
 python-shell-interpreter "ipython3"
 python-shell-interpreter-args "--simple-prompt --pprint")



Then open *Python* which will be ipython 5.1.0

The following don't work anymore in the pre-test


1.) import num [TAB]  shows possible completions in 25.1.1 but doesn't in the pretest

2.) run afile [TAB] shows possible completions for the files in the directory that match afile*

3.) cd adirec [TAB] shows possible completions


[-- Attachment #2: Type: text/html, Size: 1292 bytes --]

bug#25067: #25067 Emacs pretest 25.1.91 - ipython completion

[npostavs]

Edward Flanigan <eflanigan00@hotmail.com> writes:

> Python 3.5.2 |Anaconda 4.2.0 (64-bit)| (default, Jul 2 2016, 17:53:06)
> IPython 5.1.0 -- An enhanced Interactive Python.
>
> Recipe is the following:
>
> emacs -q
>
> eval-region on this:
>
> (setq
> python-shell-interpreter "ipython3"
> python-shell-interpreter-args "--simple-prompt --pprint")
>
> Then open *Python* which will be ipython 5.1.0
>
> The following don't work anymore in the pre-test
>
> 1.) import num [TAB] shows possible completions in 25.1.1 but doesn't in the pretest
>
> 2.) run afile [TAB] shows possible completions for the files in the directory that match afile*
>
> 3.) cd adirec [TAB] shows possible completions 

The behaviour from 25.1 can be restored by doing

    (add-to-list 'python-shell-completion-native-disabled-interpreters
                 "ipython")

So it looks like the problem is the fix for #24401 which enables native
completion work for python 3.5, also enables it for ipython, but native
completion doesn't actually work for ipython.

bug#25067: #25067 Emacs pretest 25.1.91 - ipython completion

[Eli Zaretskii]

> From: npostavs@users.sourceforge.net
> Date: Fri, 03 Feb 2017 19:03:40 -0500
> Cc: "25067@debbugs.gnu.org" <25067@debbugs.gnu.org>
> 
> The behaviour from 25.1 can be restored by doing
> 
>     (add-to-list 'python-shell-completion-native-disabled-interpreters
>                  "ipython")
> 
> So it looks like the problem is the fix for #24401 which enables native
> completion work for python 3.5, also enables it for ipython, but native
> completion doesn't actually work for ipython.

Is there any safe way to fix this for Emacs 25.2?

Thanks.

bug#25067: #25067 Emacs pretest 25.1.91 - ipython completion

[npostavs]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: npostavs@users.sourceforge.net
>> Date: Fri, 03 Feb 2017 19:03:40 -0500
>> Cc: "25067@debbugs.gnu.org" <25067@debbugs.gnu.org>
>> 
>> The behaviour from 25.1 can be restored by doing
>> 
>>     (add-to-list 'python-shell-completion-native-disabled-interpreters
>>                  "ipython")
>> 
>> So it looks like the problem is the fix for #24401 which enables native
>> completion work for python 3.5, also enables it for ipython, but native
>> completion doesn't actually work for ipython.
>
> Is there any safe way to fix this for Emacs 25.2?

I think the patch below is safe.  Although I can't say that I understand
what "native completion" actually means.

--- i/lisp/progmodes/python.el
+++ w/lisp/progmodes/python.el
@@ -3255,8 +3255,10 @@ python-shell-completion-string-code
   "Completion string code must work for (i)pdb.")
 
 (defcustom python-shell-completion-native-disabled-interpreters
-  ;; PyPy's readline cannot handle some escape sequences yet.
-  (list "pypy")
+  ;; PyPy's readline cannot handle some escape sequences yet.  Native
+  ;; completion was found to be non-functional for IPython (see
+  ;; Bug#25067).
+  (list "pypy" "ipython")
   "List of disabled interpreters.
 When a match is found, native completion is disabled."
   :version "25.1"

bug#25067: #25067 Emacs pretest 25.1.91 - ipython completion

[Eli Zaretskii]

> From: npostavs@users.sourceforge.net
> Cc: 25067@debbugs.gnu.org,  eflanigan00@hotmail.com
> Date: Sat, 04 Feb 2017 09:39:46 -0500
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> From: npostavs@users.sourceforge.net
> >> Date: Fri, 03 Feb 2017 19:03:40 -0500
> >> Cc: "25067@debbugs.gnu.org" <25067@debbugs.gnu.org>
> >> 
> >> The behaviour from 25.1 can be restored by doing
> >> 
> >>     (add-to-list 'python-shell-completion-native-disabled-interpreters
> >>                  "ipython")
> >> 
> >> So it looks like the problem is the fix for #24401 which enables native
> >> completion work for python 3.5, also enables it for ipython, but native
> >> completion doesn't actually work for ipython.
> >
> > Is there any safe way to fix this for Emacs 25.2?
> 
> I think the patch below is safe.

I agree.  Clément, any objections?

Thanks.

bug#25067: #25067 Emacs pretest 25.1.91 - ipython completion

[Clément Pit--Claudel]

[-- Attachment #1.1: Type: text/plain, Size: 966 bytes --]

On 2017-02-04 11:52, Eli Zaretskii wrote:
>> From: npostavs@users.sourceforge.net
>> Cc: 25067@debbugs.gnu.org,  eflanigan00@hotmail.com
>> Date: Sat, 04 Feb 2017 09:39:46 -0500
>>
>> Eli Zaretskii <eliz@gnu.org> writes:
>>
>>>> From: npostavs@users.sourceforge.net
>>>> Date: Fri, 03 Feb 2017 19:03:40 -0500
>>>> Cc: "25067@debbugs.gnu.org" <25067@debbugs.gnu.org>
>>>>
>>>> The behaviour from 25.1 can be restored by doing
>>>>
>>>>     (add-to-list 'python-shell-completion-native-disabled-interpreters
>>>>                  "ipython")
>>>>
>>>> So it looks like the problem is the fix for #24401 which enables native
>>>> completion work for python 3.5, also enables it for ipython, but native
>>>> completion doesn't actually work for ipython.
>>>
>>> Is there any safe way to fix this for Emacs 25.2?
>>
>> I think the patch below is safe.
> 
> I agree.  Clément, any objections?

None.  The patch looks great, thanks!

Clément.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

bug#25067: #25067 Emacs pretest 25.1.91 - ipython completion

[Eli Zaretskii]

> Cc: 25067@debbugs.gnu.org, eflanigan00@hotmail.com
> From: Clément Pit--Claudel <clement.pitclaudel@live.com>
> Date: Mon, 6 Feb 2017 20:51:46 -0500
> 
> >>>> The behaviour from 25.1 can be restored by doing
> >>>>
> >>>>     (add-to-list 'python-shell-completion-native-disabled-interpreters
> >>>>                  "ipython")
> >>>>
> >>>> So it looks like the problem is the fix for #24401 which enables native
> >>>> completion work for python 3.5, also enables it for ipython, but native
> >>>> completion doesn't actually work for ipython.
> >>>
> >>> Is there any safe way to fix this for Emacs 25.2?
> >>
> >> I think the patch below is safe.
> > 
> > I agree.  Clément, any objections?
> 
> None.  The patch looks great, thanks!

Thanks.  Let's get it into the emacs-25 branch, then.

bug#25067: #25067 Emacs pretest 25.1.91 - ipython completion

[npostavs]

tags 25067 fixed
close 25067 25.2
quit

Eli Zaretskii <eliz@gnu.org> writes:

>> Cc: 25067@debbugs.gnu.org, eflanigan00@hotmail.com
>> From: Clément Pit--Claudel <clement.pitclaudel@live.com>
>> Date: Mon, 6 Feb 2017 20:51:46 -0500
>> 
>> >>>> The behaviour from 25.1 can be restored by doing
>> >>>>
>> >>>>     (add-to-list 'python-shell-completion-native-disabled-interpreters
>> >>>>                  "ipython")
>> >>>>
>> >>>> So it looks like the problem is the fix for #24401 which enables native
>> >>>> completion work for python 3.5, also enables it for ipython, but native
>> >>>> completion doesn't actually work for ipython.
>> >>>
>> >>> Is there any safe way to fix this for Emacs 25.2?
>> >>
>> >> I think the patch below is safe.
>> > 
>> > I agree.  Clément, any objections?
>> 
>> None.  The patch looks great, thanks!
>
> Thanks.  Let's get it into the emacs-25 branch, then.

Pushed [1: 0ba9932d14]

1: 2017-02-07 21:18:19 -0500 0ba9932d1446e91fcc96f1d3303fac5ca5029d71
  Disable native completion for ipython (Bug#25067)