unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Matt Kramer <mccleetus@gmail.com>
Cc: 39564@debbugs.gnu.org
Subject: bug#39564:
Date: Mon, 02 Mar 2020 10:46:50 +0200	[thread overview]
Message-ID: <83blpfywhx.fsf@gnu.org> (raw)
In-Reply-To: <CANGn5a6rebM4r1RfN9LC8O1FF50MOd-TnC1gAPKUVc6HJ6CaAQ@mail.gmail.com> (message from Matt Kramer on Sun, 1 Mar 2020 23:20:23 -0800)

> From: Matt Kramer <mccleetus@gmail.com>
> Date: Sun, 1 Mar 2020 23:20:23 -0800
> Cc: 39564@debbugs.gnu.org
> 
> Followup: The regression in Ivy appears to be fixed when
> set-message-function is bound to nil at the top of the misbehaving
> function.

That is indeed the simplest solution, but it is not the best one.  It
would be better for Ivy to provide its own set-message-function which
plays by the new Emacs 27 rules, i.e. presents the message text in a
way that doesn't completely obscure the original prompt.

> In general, it seems like, given the new defaults defined in
> http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=485b423e8f0df2711a850be7f254665f64ab0bdb,
> it will be necessary to make a similar change to any existing function
> that, say, calls read-key under the assumption that the prompt will
> take over the mini-window. (At least when the prompt contains multiple
> lines). I guess that's the fundamental issue here. The new behavior
> may be a nice improvement, but it's unclear how much code there is out
> there that relies on the old behavior.

Relying on the old behavior was always not a future-proof assumption,
so I see no way around the problem except fixing the code which makes
such assumptions, sorry.





  reply	other threads:[~2020-03-02  8:46 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200211144941.godmcifegapmqg6i.ref@Ergus>
2020-02-11 14:49 ` bug#39564: 28.0.50; read-key function do not display the prompt if called from read-from-minibuffer Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-02-11 15:50   ` Eli Zaretskii
2020-02-11 16:17   ` Oleh Krehel
2020-02-11 17:36     ` Eli Zaretskii
2020-02-12 13:21       ` Oleh Krehel
2020-02-12 17:22         ` Eli Zaretskii
2020-02-12 22:37   ` bug#39564: 28.0.50; read-key function do not display the prompt Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-02-26 20:04   ` bug#39564: Matt Kramer
2020-02-28  7:26     ` bug#39564: Eli Zaretskii
2020-02-28 17:33   ` bug#39564: Matt Kramer
2020-02-29  8:16     ` bug#39564: Eli Zaretskii
2020-03-01 22:26       ` bug#39564: Matt Kramer
2020-03-02  7:20         ` bug#39564: Matt Kramer
2020-03-02  8:46           ` Eli Zaretskii [this message]
2022-02-20 15:13             ` bug#39564: 28.0.50; read-key function do not display the prompt if called from read-from-minibuffer Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83blpfywhx.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=39564@debbugs.gnu.org \
    --cc=mccleetus@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).